- tz - lists.iana.org

Etc/GMT+nn and Etc/GMT-nn not working since zic 2021d
by Peter Krefting July 1, 2022

July 1, 2022

Hi! I am creating timezone data for an embedded device, and with space as a premium I run zic with the -r parameter to cut off all time change information from before the software release date, as this is not relevant for the system. Since commit 5f06f9a3182d2c2942be1b678e4defa9c7400653 (included in 2021d), this causes the Etc/GMT+xx and Etc/GMT-xx timezones not to work, they always report GMT ("-00"): ~ # TZ=Europe/Oslo date Mon Mar 21 13:08:32 CET 2022 ~ # TZ=Europe/London date Mon Mar 21 12:08:36 GMT 2022 ~ # TZ=Etc/GMT+1 date Mon Mar 21 12:08:43 -00 2022 ~ # TZ=Etc/GMT+2 date Mon Mar 21 12:08:45 -00 2022 This is particularly severe for our devices since previous versions of our software only supported UTC offsets, and these are automatically updated to these GMT+xx and GMT-xx timezones on update, so many of our customers are expected to have these zones configured. We are running with "-r cutoff -b fat", where cutoff depends on the release date, and the embedded software currenlty is using GNU libc 2.20. Reverting 5f06f9a3182d2c2942be1b678e4defa9c7400653 fixes the issue for us, but is probably not the correct approach. -- \\// Peter - http://www.softwolves.pp.se/

3 6

Re: [tz] tz Digest, Vol 129, Issue 1
by Santoni Francis July 1, 2022

July 1, 2022

Hello for Iran and 1977 the effective change is only 20 october (UIT n°143 17.XI.1977) and not 23 september (UIT n°141 13.IX.1977) UIT is the Operational Bulletin of International Telecommunication Union Francis Santoni

3 2

[PROPOSED] Refactor by using max and min macros
by Paul Eggert July 1, 2022

July 1, 2022

* localtime.c (SMALLEST, BIGGEST): Remove. All uses replaced by min and max. * private.h (max, min): New macros. * zdump.c (main): * zic.c (growalloc, timerange_option): Prefer max and min to doing it by hand. --- localtime.c | 17 ++++++----------- private.h | 5 +++++ zdump.c | 2 +- zic.c | 6 +++--- 4 files changed, 15 insertions(+), 15 deletions(-) diff --git a/localtime.c b/localtime.c index 8644aa6..3db7821 100644 --- a/localtime.c +++ b/localtime.c @@ -102,9 +102,6 @@ struct lsinfo { /* leap second information */ int_fast32_t ls_corr; /* correction to apply */ }; -#define SMALLEST(a, b) (((a) < (b)) ? (a) : (b)) -#define BIGGEST(a, b) (((a) > (b)) ? (a) : (b)) - /* This abbreviation means local time is unspecified. */ static char const UNSPEC[] = "-00"; @@ -112,7 +109,7 @@ static char const UNSPEC[] = "-00"; This needs to be at least 1 for null termination in case the input data isn't properly terminated, and it also needs to be big enough for ttunspecified to work without crashing. */ -enum { CHARS_EXTRA = BIGGEST(sizeof UNSPEC, 2) - 1 }; +enum { CHARS_EXTRA = max(sizeof UNSPEC, 2) - 1 }; #ifdef TZNAME_MAX #define MY_TZNAME_MAX TZNAME_MAX @@ -131,9 +128,8 @@ struct state { time_t ats[TZ_MAX_TIMES]; unsigned char types[TZ_MAX_TIMES]; struct ttinfo ttis[TZ_MAX_TYPES]; - char chars[BIGGEST(BIGGEST(TZ_MAX_CHARS + CHARS_EXTRA, - sizeof gmt), - (2 * (MY_TZNAME_MAX + 1)))]; + char chars[max(max(TZ_MAX_CHARS + CHARS_EXTRA, sizeof gmt), + 2 * (MY_TZNAME_MAX + 1))]; struct lsinfo lsis[TZ_MAX_LEAPS]; /* The time type to use for early times or if no transitions. @@ -394,8 +390,7 @@ union local_storage { } u; /* The file name to be opened. */ - char fullname[BIGGEST(sizeof(struct file_analysis), - sizeof tzdirslash + 1024)]; + char fullname[max(sizeof(struct file_analysis), sizeof tzdirslash + 1024)]; }; /* Load tz data from the file named NAME into *SP. Read extended @@ -2086,10 +2081,10 @@ time2sub(struct tm *const tmp, && (yourtm.TM_GMTOFF < 0 ? (-SECSPERDAY <= yourtm.TM_GMTOFF && (mytm.TM_GMTOFF <= - (SMALLEST(INT_FAST32_MAX, LONG_MAX) + (min(INT_FAST32_MAX, LONG_MAX) + yourtm.TM_GMTOFF))) : (yourtm.TM_GMTOFF <= SECSPERDAY - && ((BIGGEST(INT_FAST32_MIN, LONG_MIN) + && ((max(INT_FAST32_MIN, LONG_MIN) + yourtm.TM_GMTOFF) <= mytm.TM_GMTOFF)))) { /* MYTM matches YOURTM except with the wrong UT offset. diff --git a/private.h b/private.h index e8c0942..b083c1b 100644 --- a/private.h +++ b/private.h @@ -632,6 +632,11 @@ time_t time2posix_z(timezone_t, time_t) ATTRIBUTE_PURE; #define TYPE_SIGNED(type) (((type) -1) < 0) #define TWOS_COMPLEMENT(t) ((t) ~ (t) 0 < 0) +/* Minimum and maximum of two values. Use lower case to avoid + naming clashes with standard include files. */ +#define max(a, b) ((a) > (b) ? (a) : (b)) +#define min(a, b) ((a) < (b) ? (a) : (b)) + /* Max and min values of the integer type T, of which only the bottom B bits are used, and where the highest-order used bit is considered to be a sign bit if T is signed. */ diff --git a/zdump.c b/zdump.c index 8b6788a..b10f574 100644 --- a/zdump.c +++ b/zdump.c @@ -548,7 +548,7 @@ main(int argc, char *argv[]) for (i = optind; i < argc; i++) { size_t arglen = strlen(argv[i]); if (longest < arglen) - longest = arglen < INT_MAX ? arglen : INT_MAX; + longest = min(arglen, INT_MAX); } for (i = optind; i < argc; ++i) { diff --git a/zic.c b/zic.c index 436677f..c0ff561 100644 --- a/zic.c +++ b/zic.c @@ -488,7 +488,7 @@ growalloc(void *ptr, size_t itemsize, ptrdiff_t nitems, ptrdiff_t *nitems_alloc) return ptr; else { ptrdiff_t nitems_max = PTRDIFF_MAX - WORK_AROUND_QTBUG_53071; - ptrdiff_t amax = nitems_max < SIZE_MAX ? nitems_max : SIZE_MAX; + ptrdiff_t amax = min(nitems_max, SIZE_MAX); if ((amax - 1) / 3 * 2 < *nitems_alloc) memory_exhausted(_("integer overflow")); *nitems_alloc += (*nitems_alloc >> 1) + 1; @@ -707,8 +707,8 @@ timerange_option(char *timerange) } if (*hi_end || hi < lo || max_time < lo || hi < min_time) return false; - lo_time = lo < min_time ? min_time : lo; - hi_time = max_time < hi ? max_time : hi; + lo_time = max(lo, min_time); + hi_time = min(hi, max_time); return true; } -- 2.36.1

2 1

[PROPOSED] Upgrade GCC_DEBUG_FLAGS to GCC 12
by Paul Eggert June 30, 2022

June 30, 2022

* Makefile (GCC_DEBUG_FLAGS): Add -Wbidi-chars=any,ucn and -Wuse-after-free=3, from GCC 12. --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 56c4404..cbf5b96 100644 --- a/Makefile +++ b/Makefile @@ -264,7 +264,7 @@ GCC_DEBUG_FLAGS = -DGCC_LINT -g3 -O3 -fno-common \ $(GCC_INSTRUMENT) \ -Wall -Wextra \ -Walloc-size-larger-than=100000 -Warray-bounds=2 \ - -Wbad-function-cast -Wcast-align=strict -Wdate-time \ + -Wbad-function-cast -Wbidi-chars=any,ucn -Wcast-align=strict -Wdate-time \ -Wdeclaration-after-statement -Wdouble-promotion \ -Wduplicated-branches -Wduplicated-cond \ -Wformat=2 -Wformat-overflow=2 -Wformat-signedness -Wformat-truncation \ @@ -278,7 +278,7 @@ GCC_DEBUG_FLAGS = -DGCC_LINT -g3 -O3 -fno-common \ -Wsuggest-attribute=const -Wsuggest-attribute=format \ -Wsuggest-attribute=malloc \ -Wsuggest-attribute=noreturn -Wsuggest-attribute=pure \ - -Wtrampolines -Wundef -Wuninitialized -Wunused-macros \ + -Wtrampolines -Wundef -Wuninitialized -Wunused-macros -Wuse-after-free=3 \ -Wvariadic-macros -Wvla -Wwrite-strings \ -Wno-address -Wno-format-nonliteral -Wno-sign-compare \ -Wno-type-limits -Wno-unused-parameter -- 2.36.1

1 0

Correct time zone name
by Danylo Moshenskyi June 28, 2022

June 28, 2022

Hello! It's the perfect time to change officially "Europe/Kiev" to "Europe/Kyiv". Please check this post, Ukrainians support and need it so much: https://www.linkedin.com/posts/activity-6945658723713355776-NKJm

3 3

Ukraine time zone error
by Євген Доманський June 27, 2022

June 27, 2022

Dear All It has been 19 170 days since IANA time zone database has an error for Ukraine time zone. Be brave to support Ukraine in the war against russia and correct the mistake as quickly as possible. Thank you *Yevhen Domanskyi* *Study Coordinator* Department of Oncology and Medical Radiology Dnipro State Medical University 31, Blyzhnya Str., Dnipro, 49102, Ukraine *Mobile*: +380 93 060 26 92 *e-mail: *dom.eugene(a)gmail.com Website: http://www.sitetv.net/ <http:/www.sitetv.net/>

1 0

Re: [tz] Europe/Kiev update for 1992-1995
by Doug Ewell June 26, 2022

June 26, 2022

Євген Доманський wrote: > 'Kyiv' has been used word-wide as the only correct Latin spelling of > Ukrainian city since the V century. 'Kiev' was only used in soviet > union and russia for a relatively small period of time. > Here is a example of the book written in 1570 - see KYIV You accidentally attached a picture of a book written in Greek, in the Greek script. I'm sure you meant to attach one that had something to do with English and the Latin script. -- Doug Ewell, CC, ALB | Lakewood, CO, US | ewellic.org

2 3

Error in Ukraine time zone
by Євген Доманський June 26, 2022

June 26, 2022

Dear All It has been 19 169 days since IANA time zone database has an error for Ukraine time zone. Be brave to support Ukraine in the war against russia and correct the mistake as quickly as possible. Thank you *Yevhen Domanskyi* *Study Coordinator* Department of Oncology and Medical Radiology Dnipro State Medical University 31, Blyzhnya Str., Dnipro, 49102, Ukraine *Mobile*: +380 93 060 26 92 *e-mail: *dom.eugene(a)gmail.com Website: http://www.sitetv.net/ <http:/www.sitetv.net/>

1 0

Kyiv not Kiev error
by Євген Доманський June 24, 2022

June 24, 2022

Dear All There is an error in name of the capital city of Ukraine - Kiev ('Київ' in Ukrainian language). Kiev is the transliteration of the city name from Russian language. The only correct transliteration is Kyiv. Please update the name. Best regards. *Yevhen Domanskyi* *Study Coordinator* Department of Oncology and Medical Radiology Dnipro State Medical University 31, Blyzhnya Str., Dnipro, 49102, Ukraine *Mobile*: +380 93 060 26 92 *e-mail: *dom.eugene(a)gmail.com Website: http://www.sitetv.net/ <http:/www.sitetv.net/>

11 26

Change Request: Europe/Kiev to Europe/Kyiv
by Oleksandr Leskiv June 23, 2022

June 23, 2022

The history of timezones has some existing cases where a specific timezone has been renamed. For example, the *Asia/Calcutta* timezone has been deemed obsolete and replaced by *Asia/Kolkata*. In Ukraine, according to international standards, there is a timezone called *Europe/Kiev*. The capital of Ukraine is officially and internationally should be spelled as "Kyiv". "Kiev" is an incorrect version that emerged a long time before the Soviet Union collapsed in 1991. We have a really large community of programmers that would like to start the process of renaming the Europe/Kiev timezone to Europe/Kyiv. We understand that it will take a long time for everybody to transition, but it has to be done in the long term. Sincerely, Oleksandr. TakeUsEat.

7 10