October 2014 - tz - lists.iana.org

more changes (and a bug fix)
by christos＠zoulas.com Oct. 19, 2014

Oct. 19, 2014

Hi, Most of these changes make sure that errno is always set appropriately when the time functions fail. The bug fix below that when lclptr is allocated, is not zeroed and the result from zoneinit() was not checked. If zoneinit failed, then lclptr would contain garbage, and settzname() would coredump because it assumed that the lclptr contents were sane. christos --- localtime.c.orig 2014-10-07 16:20:32.000000000 -0400 +++ localtime.c 2014-10-16 14:10:03.000000000 -0400 @@ -690,17 +690,23 @@ register char c; register int num; - if (strp == NULL || !is_digit(c = *strp)) + if (strp == NULL || !is_digit(c = *strp)) { + errno = EINVAL; return NULL; + } num = 0; do { num = num * 10 + (c - '0'); - if (num > max) + if (num > max) { + errno = ERANGE; return NULL; /* illegal value */ + } c = *++strp; } while (is_digit(c)); - if (num < min) + if (num < min) { + errno = ERANGE; return NULL; /* illegal value */ + } *nump = num; return strp; } @@ -1202,14 +1208,20 @@ ? lcl_is_set < 0 : 0 < lcl_is_set && strcmp(lcl_TZname, name) == 0) return; - if (0 < lcl) - strcpy(lcl_TZname, name); #ifdef ALL_STATE if (! lclptr) lclptr = malloc(sizeof *lclptr); #endif /* defined ALL_STATE */ - zoneinit(lclptr, name); + if (!zoneinit(lclptr, name)) { +#ifdef ALL_STATE + free(lclptr); + lclptr = NULL; +#endif + return; + } settzname(); + if (0 < lcl) + strcpy(lcl_TZname, name); lcl_is_set = lcl; } @@ -1328,8 +1340,10 @@ newt += seconds; else newt -= seconds; if (newt < sp->ats[0] || - newt > sp->ats[sp->timecnt - 1]) - return NULL; /* "cannot happen" */ + newt > sp->ats[sp->timecnt - 1]) { + errno = EINVAL; + return NULL; /* "cannot happen" */ + } result = localsub(sp, &newt, offset, tmp); if (result) { register int_fast64_t newy; @@ -1338,8 +1352,10 @@ if (t < sp->ats[0]) newy -= years; else newy += years; - if (! (INT_MIN <= newy && newy <= INT_MAX)) + if (! (INT_MIN <= newy && newy <= INT_MAX)) { + errno = EOVERFLOW; return NULL; + } result->tm_year = newy; } return result; @@ -1528,13 +1544,13 @@ tdelta = tdays / DAYSPERLYEAR; if (! ((! TYPE_SIGNED(time_t) || INT_MIN <= tdelta) && tdelta <= INT_MAX)) - return NULL; + goto overflow; idelta = tdelta; if (idelta == 0) idelta = (tdays < 0) ? -1 : 1; newy = y; if (increment_overflow(&newy, idelta)) - return NULL; + goto overflow; leapdays = leaps_thru_end_of(newy - 1) - leaps_thru_end_of(y - 1); tdays -= ((time_t) newy - y) * DAYSPERNYEAR; @@ -1563,17 +1579,17 @@ } while (idays < 0) { if (increment_overflow(&y, -1)) - return NULL; + goto overflow; idays += year_lengths[isleap(y)]; } while (idays >= year_lengths[isleap(y)]) { idays -= year_lengths[isleap(y)]; if (increment_overflow(&y, 1)) - return NULL; + goto overflow; } tmp->tm_year = y; if (increment_overflow(&tmp->tm_year, -TM_YEAR_BASE)) - return NULL; + goto overflow; tmp->tm_yday = idays; /* ** The "extra" mods below avoid overflow problems. @@ -1604,6 +1620,8 @@ tmp->TM_GMTOFF = offset; #endif /* defined TM_GMTOFF */ return tmp; +overflow: + return NULL; } char * @@ -1753,20 +1771,21 @@ if (do_norm_secs) { if (normalize_overflow(&yourtm.tm_min, &yourtm.tm_sec, SECSPERMIN)) - return WRONG; + goto overflow; } if (normalize_overflow(&yourtm.tm_hour, &yourtm.tm_min, MINSPERHOUR)) - return WRONG; + goto overflow; if (normalize_overflow(&yourtm.tm_mday, &yourtm.tm_hour, HOURSPERDAY)) - return WRONG; + goto overflow; y = yourtm.tm_year; if (normalize_overflow32(&y, &yourtm.tm_mon, MONSPERYEAR)) - return WRONG; + goto overflow; /* ** Turn y into an actual year number for now. ** It is converted back to an offset from TM_YEAR_BASE later. */ if (increment_overflow32(&y, TM_YEAR_BASE)) + goto overflow; return WRONG; while (yourtm.tm_mday <= 0) { if (increment_overflow32(&y, -1)) @@ -1792,9 +1811,9 @@ } } if (increment_overflow32(&y, -TM_YEAR_BASE)) - return WRONG; + goto overflow; if (! (INT_MIN <= y && y <= INT_MAX)) - return WRONG; + goto overflow; yourtm.tm_year = y; if (yourtm.tm_sec >= 0 && yourtm.tm_sec < SECSPERMIN) saved_seconds = 0; @@ -1844,17 +1863,17 @@ if (dir != 0) { if (t == lo) { if (t == time_t_max) - return WRONG; + goto overflow; ++t; ++lo; } else if (t == hi) { if (t == time_t_min) - return WRONG; + goto overflow; --t; --hi; } if (lo > hi) - return WRONG; + goto invalid; if (dir > 0) hi = t; else lo = t; @@ -1898,7 +1917,7 @@ ** gets checked. */ if (sp == NULL) - return WRONG; + goto invalid; for (i = sp->typecnt - 1; i >= 0; --i) { if (sp->ttis[i].tt_isdst != yourtm.tm_isdst) continue; @@ -1920,16 +1939,22 @@ goto label; } } - return WRONG; + goto invalid; } label: newt = t + saved_seconds; if ((newt < t) != (saved_seconds < 0)) - return WRONG; + overflow; t = newt; if (funcp(sp, &t, offset, tmp)) *okayp = true; return t; +invalid: + errno = EINVAL; + return WRONG; +overflow: + errno = EOVERFLOW; + return WRONG; } static time_t @@ -1966,6 +1991,7 @@ char seen[TZ_MAX_TYPES]; unsigned char types[TZ_MAX_TYPES]; bool okay; + int save_errno; if (tmp == NULL) { errno = EINVAL; @@ -1973,9 +1999,12 @@ } if (tmp->tm_isdst > 1) tmp->tm_isdst = 1; + save_errno = errno; t = time2(tmp, funcp, sp, offset, &okay); - if (okay) + if (okay) { + errno = save_errno; return t; + } if (tmp->tm_isdst < 0) #ifdef PCTS /* @@ -2013,8 +2042,10 @@ sp->ttis[samei].tt_gmtoff; tmp->tm_isdst = !tmp->tm_isdst; t = time2(tmp, funcp, sp, offset, &okay); - if (okay) + if (okay) { + errno = save_errno; return t; + } tmp->tm_sec -= sp->ttis[otheri].tt_gmtoff - sp->ttis[samei].tt_gmtoff; tmp->tm_isdst = !tmp->tm_isdst;

2 4

Canadian time zones official site link
by Matt Johnson Oct. 18, 2014

Oct. 18, 2014

The TZ source comments for Canada references the INMS, but the link there is dead. Archive.org's last copy was taken in June 2006: https://web.archive.org/web/20060710032930/http://inms-ienm.nrc-cnrc.gc.ca/… It appears that the INMS is/was a division of the NRC, and I've found the current time zone page for the NRC here: http://www.nrc-cnrc.gc.ca/eng/services/time/time_zones.html The pages appear very similar. Please update the comments in the TZ source accordingly. Thanks.

3 3

Re: [tz] Carving shapes
by Marvel, Jim (CPCOE) Oct. 17, 2014

Oct. 17, 2014

Also, how to determine borders for Zabaykalsky Krai From: Marvel, Jim (CPCOE) Sent: Thursday, October 16, 2014 11:22 AM To: 'tz(a)iana.org' Subject: Carving shapes How to determine borders for these new zones? Two zones are added: Asia/Chita (split from Asia/Yakutsk, and also with two hours subtracted) and Asia/Srednekolymsk (split from Asia/Magadan, but with only one hour subtracted). thanks Jim Marvel

4 6

Incorrect timezone offset with current Russian rules - tzdata or glibc bug or normal?
by Andrei Borzenkov Oct. 17, 2014

Oct. 17, 2014

I hit strange problem which looks like a bug and actually caused serious problem due to different interpretation of current timezone offset. Current tzdata correctly - as far as I can tell - defines time today as UTC-4 with summer time inactive: /etc/localtime Sat Mar 26 23:00:00 2011 UT = Sun Mar 27 03:00:00 2011 MSK isdst=0 gmtoff=14400 /etc/localtime Sat Oct 25 21:59:59 2014 UT = Sun Oct 26 01:59:59 2014 MSK isdst=0 gmtoff=14400 /etc/localtime Sat Oct 25 22:00:00 2014 UT = Sun Oct 26 01:00:00 2014 MSK isdst=0 gmtoff=10800 /etc/localtime 9223372036854689407 = NULL /etc/localtime 9223372036854775807 = NULL But the valule of variable "timezone" (man timezone(3)) is set to UTC-3 ... bor@opensuse:~/tmp/sapttzz> ./sapttz Name of local time zone: no info (=TZ) Technical description of local time zone: UTC time +10800 sec Daylight Saving Time at the current/given date is: inaktiv where offset is computed as simply printf(" UTC time %+ld sec\n",- (long int)timezone); if(tm->tm_isdst == 1) printf(" aktiv\n"); else if(tm->tm_isdst == 0) printf(" inaktiv\n"); else printf(" unknown\n"); So basically any application which tries to compute current offset from UTC as based offset (timezone) + dst offset (if isdst) will fail. Or better, two programs running on the same system may have different idea of current time. What puzzles me - if I take previous timezone before last change (before 2014f) the same program displays correct time. But visually nothing has changed ... /etc/localtime Sat Mar 26 22:59:59 2011 UT = Sun Mar 27 01:59:59 2011 MSK isdst=0 gmtoff=10800 /etc/localtime Sat Mar 26 23:00:00 2011 UT = Sun Mar 27 03:00:00 2011 MSK isdst=0 gmtoff=14400 /etc/localtime 9223372036854689407 = NULL /etc/localtime 9223372036854775807 = NULL bor@opensuse:~/tmp/sapttzz> ./sapttz Name of local time zone: no info (=TZ) Technical description of local time zone: UTC time +14400 sec Daylight Saving Time at the current/given date is: inaktiv openSUSE 13.1 with glibc-2.18-4.21.1.x86_64 Any ideas? TIA -andrei

2 1

Utah may drop DST
by Paul Eggert Oct. 17, 2014

Oct. 17, 2014

The Utah Governor's Office of Economic Development, pursuant to a bill passed last year by the state legislature, polled citizens and held public meetings about daylight saving time. They got more than 27,000 responses, including 13,000 written comments totaling 574,000 words. The results: 67% preferred Mountain Standard Time (UTC-7) all year (like Arizona) 18% preferred daylight time (UTC-6) all year, essentially Central Standard Time 15% liked the current spring-forward/fall-back system The main argument of the majority was convenience. The tourism and recreation industries prefer daylight saving, though, and will lobby against switching to MST all year if (as seems likely) an MST bill is introduced in the legislature. My source: Davidson L. Something new under the sun: Utah may dump daylight saving time. Salt Lake Tribune 2014-10-15 http://www.sltrib.com/sltrib/politics/58526154-90/daylight-saving-malley-ut…

10 15

zone.tab deprecation
by Matt Johnson Oct. 16, 2014

Oct. 16, 2014

I understand the differences between zone.tab and zone1970.tab, but why does zone.tab have to be deprecated? Can't we just maintain both files indefinitely? Then developers can choose whichever file makes sense for their scenario. Is there a specific reason for the deprecation? If it is to be dropped at some point - how far out is that, and does it get maintained until then?

2 1

Carving shapes
by Marvel, Jim (CPCOE) Oct. 16, 2014

Oct. 16, 2014

How to determine borders for these new zones? Two zones are added: Asia/Chita (split from Asia/Yakutsk, and also with two hours subtracted) and Asia/Srednekolymsk (split from Asia/Magadan, but with only one hour subtracted). thanks Jim Marvel

1 0

zdump bug in Asia/Singapore
by Tim Parenti Oct. 15, 2014

Oct. 15, 2014

While sorting out some issues for tzdist, I noticed a bug in zdump, which is still present in 2014g. Running zdump on Asia/Singapore for both 1981 and 1982 together produces the expected transition from UTC+7:30 to UTC+8 at the boundary between those years: $ ./zdump.exe -vc 1981,1983 Asia/Singapore Asia/Singapore -9223372036854775808 = NULL Asia/Singapore -9223372036854689408 = NULL Asia/Singapore Thu Dec 31 16:29:59 1981 UT = Thu Dec 31 23:59:59 1981 SGT isdst=0 Asia/Singapore Thu Dec 31 16:30:00 1981 UT = Fri Jan 1 00:30:00 1982 SGT isdst=0 Asia/Singapore 9223372036854689407 = NULL Asia/Singapore 9223372036854775807 = NULL However, running it on 1981 and 1982 individually does not: $ ./zdump.exe -vc 1981,1982 Asia/Singapore Asia/Singapore -9223372036854775808 = NULL Asia/Singapore -9223372036854689408 = NULL Asia/Singapore 9223372036854689407 = NULL Asia/Singapore 9223372036854775807 = NULL $ ./zdump.exe -vc 1982,1983 Asia/Singapore Asia/Singapore -9223372036854775808 = NULL Asia/Singapore -9223372036854689408 = NULL Asia/Singapore 9223372036854689407 = NULL Asia/Singapore 9223372036854775807 = NULL Initially, I thought this might have to do with the fact that the transition is specified as a Zone continuation line rather than as a Rule, since zdump properly handled my extended edge-case examples to Jon Skeet a while back: http://mm.icann.org/pipermail/tz/2014-July/021162.html <http://mm.icann.org/pipermail/tz/2014-July/021162.html> zdump also properly handles Asia/Dhaka's DST transition at the end of 2009, but fails in some other similar cases. So it looks like it's more to do with the transition taking place too close to the year boundary. Part of the problem may be the transition happening in different years, UTC and local, but that doesn't seem to be all that's going on. Attached are some test cases to run against various versions of Singapore with 1981,1982 and 1982,1983; and various versions of Dhaka with 2009,2010 and 2010,2011. All of these should work, but most currently don't. (The ones that do are marked.) -- Tim Parenti

4 21

localtime.c patch
by christos＠zoulas.com Oct. 14, 2014

Oct. 14, 2014

Minor nits. christos --- localtime.c.orig 2014-10-07 16:20:32.000000000 -0400 +++ localtime.c 2014-10-07 16:22:47.000000000 -0400 @@ -306,3 +306,3 @@ register int stored; - register int nread; + register ssize_t nread; typedef union { @@ -934,3 +934,2 @@ register bool load_ok; - static struct ttinfo zttinfo; @@ -1006,3 +1005,3 @@ */ - sp->ttis[0] = sp->ttis[1] = zttinfo; + memset(sp->ttis, 0, sizeof(sp->ttis)); sp->ttis[0].tt_gmtoff = -dstoffset; @@ -1131,3 +1130,3 @@ */ - sp->ttis[0] = sp->ttis[1] = zttinfo; + memset(sp->ttis, 0, sizeof(sp->ttis)); sp->ttis[0].tt_gmtoff = -stdoffset; @@ -1145,3 +1144,3 @@ sp->timecnt = 0; - sp->ttis[0] = zttinfo; + memset(sp->ttis, 0, sizeof(sp->ttis)); sp->ttis[0].tt_gmtoff = -stdoffset; @@ -2108,3 +2107,2 @@ - sp = lclptr; i = sp->leapcnt;

5 12

[PROPOSED PATCH] new Zone Pacific/Bougainville
by Paul Eggert Oct. 14, 2014

Oct. 14, 2014

This is for the part of Papua New Guinea that plans to switch from UTC+10 to UTC+11 on 2014-12-28 at 02:00. (Thanks to Kiley Walbom for the heads-up.) * australasia (Pacific/Bougainville): New zone. * zone.tab, zone1970.tab: Add entries for it. * NEWS: Document this. --- NEWS | 6 ++++++ australasia | 25 +++++++++++++++++++++++++ zone.tab | 3 ++- zone1970.tab | 3 ++- 4 files changed, 35 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 69dc2ca..26dcbf6 100644 --- a/NEWS +++ b/NEWS @@ -2,6 +2,12 @@ News for the tz database Unreleased, experimental changes + Changes affecting future time stamps + + A new Zone Pacific/Bougainville, for the part of Papua New Guinea + that plans to switch from UTC+10 to UTC+11 on 2014-12-28 at 02:00. + (Thanks to Kiley Walbom for the heads-up.) + Changes affecting past time stamps Many time stamps have been corrected for Asia/Ho_Chi_Minh before 1976 diff --git a/australasia b/australasia index 5ea1f18..c06e62c 100644 --- a/australasia +++ b/australasia @@ -519,6 +519,30 @@ Zone Pacific/Palau 8:57:56 - LMT 1901 # Koror Zone Pacific/Port_Moresby 9:48:40 - LMT 1880 9:48:32 - PMMT 1895 # Port Moresby Mean Time 10:00 - PGT # Papua New Guinea Time +# +# From Paul Eggert (2014-10-13): +# Base the Bougainville entry on the Arawa-Kieta region, which appears to have +# the most people even though it was devastated in the Bougainville Civil War. +# +# Although Shanks gives 1942-03-15 / 1943-11-01 for JST, these dates +# are apparently rough guesswork from the starts of military campaigns. +# The World War II entries below are instead based on Arawa-Kieta. +# The Japanese occupied Kieta in July 1942, +# according to the Pacific War Online Encyclopedia +# http://pwencycl.kgbudge.com/B/o/Bougainville.htm +# and seem to have controlled it until their 1945-08-21 surrender. +# +# The Autonomous Region of Bougainville plans to switch from UTC+10 to UTC+11 +# on 2014-12-28 at 02:00. They call UTC+11 "Bougainville Standard Time"; +# abbreviate this as BST. See: +# http://www.bougainville24.com/bougainville-issues/bougainville-gets-own-tim… +# +Zone Pacific/Bougainville 10:22:16 - LMT 1880 + 9:48:32 - PMMT 1895 + 10:00 - PGT 1942 Jul + 9:00 - JST 1945 Aug 21 + 10:00 - PGT 2014 Dec 28 2:00 + 11:00 - BST # Pitcairn # Zone NAME GMTOFF RULES FORMAT [UNTIL] @@ -803,6 +827,7 @@ Zone Pacific/Wallis 12:15:20 - LMT 1901 # 10:00 AEST AEDT Eastern Australia # 10:00 ChST Chamorro # 10:30 LHST LHDT Lord Howe* +# 11:00 BST Bougainville* # 11:30 NZMT NZST New Zealand through 1945 # 12:00 NZST NZDT New Zealand 1946-present # 12:15 CHAST Chatham through 1945* diff --git a/zone.tab b/zone.tab index 084bb2f..a7373f1 100644 --- a/zone.tab +++ b/zone.tab @@ -307,7 +307,8 @@ PE -1203-07703 America/Lima PF -1732-14934 Pacific/Tahiti Society Islands PF -0900-13930 Pacific/Marquesas Marquesas Islands PF -2308-13457 Pacific/Gambier Gambier Islands -PG -0930+14710 Pacific/Port_Moresby +PG -0930+14710 Pacific/Port_Moresby most locations +PG -0613+15534 Pacific/Bougainville Bougainville PH +1435+12100 Asia/Manila PK +2452+06703 Asia/Karachi PL +5215+02100 Europe/Warsaw diff --git a/zone1970.tab b/zone1970.tab index 57c11f1..e971bc7 100644 --- a/zone1970.tab +++ b/zone1970.tab @@ -264,7 +264,8 @@ PE -1203-07703 America/Lima PF -1732-14934 Pacific/Tahiti Society Islands PF -0900-13930 Pacific/Marquesas Marquesas Islands PF -2308-13457 Pacific/Gambier Gambier Islands -PG -0930+14710 Pacific/Port_Moresby +PG -0930+14710 Pacific/Port_Moresby most locations +PG -0613+15534 Pacific/Bougainville Bougainville PH +1435+12100 Asia/Manila PK +2452+06703 Asia/Karachi PL +5215+02100 Europe/Warsaw -- 1.9.3

1 0