June 2005 - tz - lists.iana.org

Translate Windows timezone to TZID?
by Dave Cantor June 17, 2005

June 17, 2005

I've been thinking about this problem for a while. Anyone have any thoughts? Suppose you have a portable computer running Microsoft Windows (whatever version you dislike least) which you take with you when you travel. When you power it up and you're in a timezone different from the one you last used it in, you use Windows' Adjust Date/Time dialogue to set the correct timezone. Now Windows has bogus names for the zones, like "Dlt"="GMT Daylight Time" "Std"="GMT Standard Time" "Dlt"="Hawaiian Daylight Time" "Std"="Hawaiian Standard Time" which you can read out of the registry. Suppose I want to get the correct name of the time zone (from which maybe I'll generate the correct abbreviation). So for GMT, the proper strings would be "Greenwich Mean Time" for standard time, and there is no daylight time. For Hawaii, I believe that's properly Hawaiian-Aleutian Standard Time; again no daylight observance. Is there a way anyone can think of to map the incorrect Windows text strings to correct text strings algorithmically? (Too bad Windows doesn't have the exemplar city name in its database of time zones.) Dave Cantor -- David A. Cantor Groton, CT 06340-3731 DCantor(a)shore.net

4 4

FW: Daylight Saving in Australia
by Olson, Arthur David (NIH/NCI) June 14, 2005

June 14, 2005

David Grosz is not on the time zone mailing list; direct replies appropriately. --ado -----Original Message----- From: David_Grosz(a)amp.com.au [mailto:David_Grosz@amp.com.au] Sent: Monday, June 13, 2005 8:51 PM To: Olson, Arthur David (NIH/NCI) Cc: David Grosz Subject: Daylight Saving in Australia In case you haven't heard yet, it was announced last week that Daylight Saving would be extended by one week next year to allow for the 2006 Commonwealth Games. Daylight Saving is now to end for next year only on the first Sunday in April instead of the last Sunday in March. Even though the Commonwealth Games are to be held in Melbourne, Victoria, I have read that this change is for New South Wales. I would assume though that this change would include Victoria and the other states affected by Daylight Saving (ACT, Tasmania and South Australia). Kind Regards, David Grosz Sydney, NSW, Australia Mobile: 0411 884 335 Email: david_work(a)dlg.com.au This email message and any accompanying attachments may contain information that is confidential and is subject to legal privilege. If you are not the intended recipient, do not read, use, disseminate, distribute or copy this message or attachments. If you have received this message in error, please notify the sender immediately and delete this message. Any views expressed in this message are those of the individual sender, except where the sender expressly, and with authority, states them to be the views of AMP. Before opening any attachments, please check them for viruses and defects.

2 1

Re: Translate Windows timezone to TZID?
by kennykb＠crd.ge.com June 14, 2005

June 14, 2005

dcantor(a)shore.net said: > Is there a way anyone can think of to map the incorrect Windows text > strings to correct text strings algorithmically? No, or at least I never found any that's compatible with localisation. What I wound up doing in Tcl is extracting the complete Windows database of named time zones from the registry of a sample system, and mapping the TZI's back to city names using a table I constructed. The mapping is ambiguous; for instance, there's no way on Windows to distinguish America/New_York, America/Toronto, America/Montreal, America/Thunder_Bay, and several others, because they share a definition in Microsoft's world. I made a somewhat arbitrary (and US-centric) choice in those cases. The choices that are made give results that are at least correct this year. For whatever it's worth, the table I use looks like: # Translation table to map Windows TZI onto cities, so that # the Olson rules can apply. In some cases the mapping is ambiguous, # so it's wise to specify $::env(TCL_TZ) rather than simply depending # on the system time zone. # The keys are long lists of values obtained from the time zone # information in the Registry. In order, the list elements are: # Bias StandardBias DaylightBias # StandardDate.wYear StandardDate.wMonth StandardDate.wDayOfWeek # StandardDate.wDay StandardDate.wHour StandardDate.wMinute # StandardDate.wSecond StandardDate.wMilliseconds # DaylightDate.wYear DaylightDate.wMonth DaylightDate.wDayOfWeek # DaylightDate.wDay DaylightDate.wHour DaylightDate.wMinute # DaylightDate.wSecond DaylightDate.wMilliseconds # The values are the names of time zones where those rules apply. # There is considerable ambiguity in certain zones; an attempt has # been made to make a reasonable guess, but this table needs to be # taken with a grain of salt. variable WinZoneInfo [dict create \ {-43200 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :Pacific/Kwajalein \ {-39600 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :Pacific/Midway \ {-36000 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :Pacific/Honolulu \ {-32400 0 3600 0 10 0 5 2 0 0 0 0 4 0 1 2 0 0 0} :America/Anchorage \ {-28800 0 3600 0 10 0 5 2 0 0 0 0 4 0 1 2 0 0 0} :America/Los_Angeles \ {-25200 0 3600 0 10 0 5 2 0 0 0 0 4 0 1 2 0 0 0} :America/Denver \ {-25200 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :America/Phoenix \ {-21600 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :America/Regina \ {-21600 0 3600 0 10 0 5 2 0 0 0 0 4 0 1 2 0 0 0} :America/Chicago \ {-18000 0 3600 0 10 0 5 2 0 0 0 0 4 0 1 2 0 0 0} :America/New_York \ {-18000 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :America/Indianapolis \ {-14400 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :America/Caracas \ {-14400 0 3600 0 3 6 2 0 0 0 0 0 10 6 2 0 0 0 0} :America/Santiago \ {-14400 0 3600 0 10 0 5 2 0 0 0 0 4 0 1 2 0 0 0} :America/Halifax \ {-12600 0 3600 0 10 0 5 2 0 0 0 0 4 0 1 2 0 0 0} :America/St_Johns \ {-10800 0 3600 0 2 0 2 2 0 0 0 0 10 0 3 2 0 0 0} :America/Sao_Paulo \ {-10800 0 3600 0 10 0 5 2 0 0 0 0 4 0 1 2 0 0 0} :America/Godthab \ {-10800 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :America/Buenos_Aires \ {-7200 0 3600 0 9 0 5 2 0 0 0 0 3 0 5 2 0 0 0} :America/Noronha \ {-3600 0 3600 0 10 0 5 3 0 0 0 0 3 0 5 2 0 0 0} :Atlantic/Azores \ {-3600 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :Atlantic/Cape_Verde \ {0 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :UTC \ {0 0 3600 0 10 0 5 2 0 0 0 0 3 0 5 1 0 0 0} :Europe/London \ {3600 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :Africa/Kinshasa \ {3600 0 3600 0 10 0 5 3 0 0 0 0 3 0 5 2 0 0 0} :CET \ {7200 0 3600 0 9 3 5 2 0 0 0 0 5 5 1 2 0 0 0} :Africa/Cairo \ {7200 0 3600 0 10 0 5 4 0 0 0 0 3 0 5 3 0 0 0} :Europe/Helsinki \ {7200 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :Asia/Jerusalem \ {7200 0 3600 0 9 0 5 1 0 0 0 0 3 0 5 0 0 0 0} :Europe/Bucharest \ {7200 0 3600 0 10 0 5 3 0 0 0 0 3 0 5 2 0 0 0} :Europe/Athens \ {10800 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :Asia/Riyadh \ {10800 0 3600 0 10 0 1 4 0 0 0 0 4 0 1 3 0 0 0} :Asia/Baghdad \ {10800 0 3600 0 10 0 5 3 0 0 0 0 3 0 5 2 0 0 0} :Europe/Moscow \ {12600 0 3600 0 9 2 4 2 0 0 0 0 3 0 1 2 0 0 0} :Asia/Tehran \ {14400 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :Asia/Muscat \ {14400 0 3600 0 10 0 5 3 0 0 0 0 3 0 5 2 0 0 0} :Asia/Tbilisi \ {16200 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :Asia/Kabul \ {18000 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :Asia/Karachi \ {18000 0 3600 0 10 0 5 3 0 0 0 0 3 0 5 2 0 0 0} :Asia/Yekaterinburg \ {19800 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :Asia/Calcutta \ {20700 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :Asia/Katmandu \ {21600 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :Asia/Dhaka \ {21600 0 3600 0 10 0 5 3 0 0 0 0 3 0 5 2 0 0 0} :Asia/Novosibirsk \ {23400 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :Asia/Rangoon \ {25200 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :Asia/Bangkok \ {25200 0 3600 0 10 0 5 3 0 0 0 0 3 0 5 2 0 0 0} :Asia/Krasnoyarsk \ {28800 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :Asia/Chongqing \ {28800 0 3600 0 10 0 5 3 0 0 0 0 3 0 5 2 0 0 0} :Asia/Irkutsk \ {32400 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :Asia/Tokyo \ {32400 0 3600 0 10 0 5 3 0 0 0 0 3 0 5 2 0 0 0} :Asia/Yakutsk \ {34200 0 3600 0 3 0 5 3 0 0 0 0 10 0 5 2 0 0 0} :Australia/Adelaide \ {34200 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :Australia/Darwin \ {36000 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :Australia/Brisbane \ {36000 0 3600 0 10 0 5 3 0 0 0 0 3 0 5 2 0 0 0} :Asia/Vladivostok \ {36000 0 3600 0 3 0 5 3 0 0 0 0 10 0 1 2 0 0 0} :Australia/Hobart \ {36000 0 3600 0 3 0 5 3 0 0 0 0 10 0 5 2 0 0 0} :Australia/Sydney \ {39600 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :Pacific/Noumea \ {43200 0 3600 0 3 0 3 2 0 0 0 0 10 0 1 2 0 0 0} :Pacific/Auckland \ {43200 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :Pacific/Fiji \ {46800 0 3600 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0} :Pacific/Tongatapu] -- 73 de ke9tv/2, Kevin KENNY GE Corporate Research & Development kennykb(a)crd.ge.com P. O. Box 8, Bldg. K-1, Rm. 5B36A Schenectady, New York 12301-0008 USA

1 0

Multi-timezone clock
by peter.verthez＠alcatel.be June 14, 2005

June 14, 2005

Hello all, I've been making a multi-timezone clock based on the Olson timezone database, which may be interesting to the people on this mailing list. The freshmeat project page can be found here: http://freshmeat.net/projects/intclock The tz database is used in the configuration window, to select a timezone for each clock. The program is written in Perl and requires perl-Gtk2 (actually, perl-Gtk will also work, but with a much less polished user interface). It is currently available in English, Dutch and German. Country names are translated via the CLDR (currently version 1.3) for all languages automatically. Manual translation is only needed for some 30 strings in the user interface. Note that the translations for timezone names in the CLDR (i.e. the exemplarCity entries) are currently not used, because the available data is too sparse: all city names are shown in English. If the CLDR includes more entries later, this may change. All suggestions, and translations to other languages, are very welcome (see web page for details). Best regards, Peter.

4 10

Tzcode2005j.tar.gz and tzdata2005j.tar.gz
by Olson, Arthur David (NIH/NCI) June 13, 2005

June 13, 2005

The files... ftp://elsie.nci.nih.gov/pub/tzcode2005j.tar.gz ...and... ftp://elsie.nci.nih.gov/pub/tzdata2005j.tar.gz ...are now available. These reflect changes to limit the length of time zone abbreviations and the characters used in those abbreviations. There are also changes to handle POSIX-style "quoted" time zone environment variables. The changes were circulated on the time zone mailing list; the only change since then was the removal of a couple of minimum-length of abbreviation checks. --ado

1 0

No 1980 discrepancy in Denmark
by Jesper Norgaard Welen June 12, 2005

June 12, 2005

>> in another related law, the effecting DST changes are stated >> explicitly: to be from 6.th. of April 1980 at 2.00 to 28.th. of >> September 1980 at 2.00. If this is true, this differs slightly from >> the EU rule in that DST runs to 2.00, not 3.00. > > It would have been odd for the 1980 transitions to disagree with both old Danish > tradition (1945-1948) and with the then-current EU rules. For now, how about if > we assume that the 02:00 of the above source refers to standard time, not > wall-clock time, and so the EU rules were in effect? It would indeed have been strange also to disagree with old Danish tradition, but I decided instead to take the investigation a bit further and contacted a number of danish newspapers by email. Unfortunately I did not get many answers, but one was conclusive, EU rules were indeed followed: ===================== BEGIN Hej J. Nørgaard Vedr. Sommertid som du har sendt en mail angående. I Herning Folkeblad 1980, 26.september står der: Natten mellem lørdag og søndag skal urene stilles ind på vintertid eller rettere normaltid. Det betyder at natten bliver en time længere. Rent praktisk foretages skiftet på den måde, at når klokken er tre natten mellem lørdag og søndag stilles urene en time tilbage. Venlig hilsen Anne-Marie Hansen e-mail: amh(a)herningfolkeblad.dk ===================== END This is a quote from Herning Folkeblad (News), the 26.th. of September 1980. Quoting from the end of the article the night between Saturday and Sunday the clock is set back from three to two. By the way, I agree with all of Paul Eggerts comments to my suggested corrections to the tz database. I will probably send some more observations on the tz database, but later at a more convenient time (for me). Just a little taster, I think that the Mataveri (Easter Island) time zone change in 1982 was at 13.th. of March 1982 21:00, instead of 14.th. of March at 0:00 as the tz database has it, which in reality means that the actual time was changed from GMT-6 to GMT-7 and then back to GMT-6 four hours later. If the change had taken place at 21:00 the 13.th. of March, then there would be no actual time change, but the time would stay as GMT-6 all of March in 1982 in Easter Island. Regards, Jesper Jesper Nørgaard Welen Email: jnorgard(a)Prodigy.Net.mx Project Leader (Líder de Proyecto) Software CIMMYT - Centro Internacional de Mejoramiento de Maíz y Trigo Dirección: CIMMYT Int. c/o Jesper Nørgaard Km. 45, Carretera México-Veracruz El Batán Texcoco, Edo. de México CP 56130 MEXICO Tel.: +52 (5) 58-04-20-04 ext. 1374 Fax: +52 (5) 58-04-75-58 Tel. Casa: 53-10-05-95 ó 53-10-97-78 Download the free program World Time Explorer, I made: http://www.cimmyt.org/timezone/index.htm

1 0

RE: revised proposed time zone abbreviation changes
by Olson, Arthur David (NIH/NCI) June 7, 2005

June 7, 2005

> That "stdlen < 3" remains, I'd make it just be "if (stdlen == 0)" > (for the error return). < 0 is impossible the way the code is > written, so there's no need to test that. Anything > 0 in that > context should be OK. It might be best to simply remove the test, relying on the common-case code to catch any problems. (This would avoid surprises down the line involving a need to change two length tests rather than one.) --ado

2 1

RE: 64-bit work
by Olson, Arthur David (NIH/NCI) June 7, 2005

June 7, 2005

> > There are a few places (Cairo, Godthab, Chile) that can't be > > represented by POSIX-conforming strings; for these we'd punt to the > > "write 400 years worth of data and work modulo 400" approach (leaving off the trailing TZ string). > I'm not sure what the problem is with those timezones. Can you explain? The problem isn't with the time zones; the problem is with POSIX limitations on describing time zones. The easy case to explain is Chile, where transitions occur in March and October on the first Sunday on or after the 9th of the month. This will sometimes be the second Sunday of the month; other times it will be the third Sunday of the month. POSIX, however, only allows for first Sunday or second Sunday or third Sunday or fourth Sunday or last Sunday. Avoid the temptation to try to "fix" POSIX; the inherent POSIX assumption is that all time zones can be described with two annual transitions that are historically invariant and that simply won't fly in the real world. --ado

1 0

Proposed time zone abbreviation changes
by Arthur David Olson June 7, 2005

June 7, 2005

Here are changes (relative to what's currently available via ftp) to deal with time zone abbreviation issues. 1. The use of "??" as an abbreviation in the solar* files is eliminated. 2. The zic command warns about non-POSIX abbreviations. 3. The zdump command warns about non-POSIX abbreviations if its "-v" flag is used. 4. localtime.c is changed to restrict characters in abbreviations to [a-zA-Z0-9 :+-] (replacing other characters with 'X'), and to restrict abbreviation lengths to 16 (truncating longer abbreviations). Both zic.c and localtime.c have the long Factory "abbreviation" grandparented in. --ado diff -r -c old/Makefile new/Makefile *** old/Makefile Mon Apr 4 11:24:31 2005 --- new/Makefile Thu May 26 12:42:13 2005 *************** *** 1,4 **** ! # @(#)Makefile 7.108 # Change the line below for your time zone (after finding the zone you want in # the time zone files, or adding it to a time zone file). --- 1,4 ---- ! # @(#)Makefile 7.109 # Change the line below for your time zone (after finding the zone you want in # the time zone files, or adding it to a time zone file). *************** *** 111,117 **** # -DNO_RUN_TIME_WARNINGS_ABOUT_YEAR_2000_PROBLEMS_THANK_YOU=1 # if you do not want run time warnings about formats that may cause # year 2000 grief ! # GCC_DEBUG_FLAGS = -Dlint -g -O -fno-common \ -Wall -Wcast-qual -Wconversion -Wmissing-prototypes \ -Wnested-externs -Wpointer-arith -Wshadow \ --- 111,119 ---- # -DNO_RUN_TIME_WARNINGS_ABOUT_YEAR_2000_PROBLEMS_THANK_YOU=1 # if you do not want run time warnings about formats that may cause # year 2000 grief ! # -DZIC_MAX_ABBR_LEN_WO_WARN=3 ! # (or some other number) to set the maximum time zone abbreviation length ! # that zic will accept without a warning (the default is 6) GCC_DEBUG_FLAGS = -Dlint -g -O -fno-common \ -Wall -Wcast-qual -Wconversion -Wmissing-prototypes \ -Wnested-externs -Wpointer-arith -Wshadow \ diff -r -c old/localtime.c new/localtime.c *** old/localtime.c Mon Apr 4 11:24:32 2005 --- new/localtime.c Thu May 26 15:02:36 2005 *************** *** 5,11 **** #ifndef lint #ifndef NOID ! static char elsieid[] = "@(#)localtime.c 7.91"; #endif /* !defined NOID */ #endif /* !defined lint */ --- 5,11 ---- #ifndef lint #ifndef NOID ! static char elsieid[] = "@(#)localtime.c 7.93"; #endif /* !defined NOID */ #endif /* !defined lint */ *************** *** 22,27 **** --- 22,40 ---- #include "fcntl.h" #include "float.h" /* for FLT_MAX and DBL_MAX */ + #ifndef TZ_ABBR_MAX_LEN + #define TZ_ABBR_MAX_LEN 16 + #endif /* !defined TZ_ABBR_MAX_LEN */ + + #ifndef TZ_ABBR_CHAR_SET + #define TZ_ABBR_CHAR_SET \ + "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789 :+-" + #endif /* !defined TZ_ABBR_CHAR_SET */ + + #ifndef TZ_ABBR_ERR_CHAR + #define TZ_ABBR_ERR_CHAR 'X' + #endif /* !defined TZ_ABBR_ERR_CHAR */ + /* ** SunOS 4.1.1 headers lack O_BINARY. */ *************** *** 124,129 **** --- 137,143 ---- static long detzcode P((const char * codep)); static const char * getzname P((const char * strp)); + static const char * getqzname P((const char * strp, const char delim)); static const char * getnum P((const char * strp, int * nump, int min, int max)); static const char * getsecs P((const char * strp, long * secsp)); *************** *** 269,274 **** --- 283,306 ---- tzname[ttisp->tt_isdst] = &sp->chars[ttisp->tt_abbrind]; } + /* + ** Finally, scrub the abbreviations. + ** First, replace bogus characters. + */ + for (i = 0; i < sp->charcnt; ++i) + if (strchr(TZ_ABBR_CHAR_SET, sp->chars[i]) == NULL) + sp->chars[i] = TZ_ABBR_ERR_CHAR; + /* + ** Second, truncate long abbreviations. + */ + for (i = 0; i < sp->typecnt; ++i) { + register const struct ttinfo * const ttisp = &sp->ttis[i]; + register char * cp = &sp->chars[ttisp->tt_abbrind]; + + if (strlen(cp) > TZ_ABBR_MAX_LEN && + strcmp(cp, GRANDPARENTED) != 0) + *(cp + TZ_ABBR_MAX_LEN) = '\0'; + } } static int *************** *** 470,475 **** --- 502,528 ---- } /* + ** Given a pointer into an extended time zone string, scan until the ending + ** delimiter of the zone name is located. Return a pointer to the delimiter. + ** + ** As with getzname above, the legal character set is actually quite + ** restricted, with other characters producing undefined results. + ** We choose not to care - allowing almost anything to be in the zone abbrev. + */ + + static const char * + getqzname(strp, delim) + register const char * strp; + const char delim; + { + register char c; + + while ((c = *strp) != '\0' && c != delim) + ++strp; + return strp; + } + + /* ** Given a pointer into a time zone string, extract a number from that string. ** Check that the number is within a specified range; if it is not, return ** NULL. *************** *** 753,760 **** stdlen = (sizeof sp->chars) - 1; stdoffset = 0; } else { ! name = getzname(name); ! stdlen = name - stdname; if (stdlen < 3) return -1; if (*name == '\0') --- 806,823 ---- stdlen = (sizeof sp->chars) - 1; stdoffset = 0; } else { ! if (*name == '<') { ! name++; ! stdname = name; ! name = getqzname(name, '>'); ! if (*name != '>') ! return (-1); ! stdlen = name - stdname; ! name++; ! } else { ! name = getzname(name); ! stdlen = name - stdname; ! } if (stdlen < 3) return -1; if (*name == '\0') *************** *** 767,775 **** if (load_result != 0) sp->leapcnt = 0; /* so, we're off a little */ if (*name != '\0') { ! dstname = name; ! name = getzname(name); ! dstlen = name - dstname; /* length of DST zone name */ if (dstlen < 3) return -1; if (*name != '\0' && *name != ',' && *name != ';') { --- 830,847 ---- if (load_result != 0) sp->leapcnt = 0; /* so, we're off a little */ if (*name != '\0') { ! if (*name == '<') { ! dstname = ++name; ! name = getqzname(name, '>'); ! if (*name != '>') ! return -1; ! dstlen = name - dstname; ! name++; ! } else { ! dstname = name; ! name = getzname(name); ! dstlen = name - dstname; /* length of DST zone name */ ! } if (dstlen < 3) return -1; if (*name != '\0' && *name != ',' && *name != ';') { diff -r -c old/private.h new/private.h *** old/private.h Mon Apr 4 11:24:32 2005 --- new/private.h Thu May 26 14:54:07 2005 *************** *** 25,30 **** --- 25,32 ---- #endif /* !defined NOID */ #endif /* !defined lint */ + #define GRANDPARENTED "Local time zone must be set--see zic manual page" + /* ** Defaults for preprocessor symbols. ** You can override these in your C compiler options, e.g. `-DHAVE_ADJTIME=0'. diff -r -c old/solar87 new/solar87 *** old/solar87 Thu Apr 21 15:04:16 2005 --- new/solar87 Thu May 26 12:42:35 2005 *************** *** 1,4 **** ! # @(#)solar87 7.3 # So much for footnotes about Saudi Arabia. # Apparent noon times below are for Riyadh; your mileage will vary. --- 1,4 ---- ! # @(#)solar87 7.4 # So much for footnotes about Saudi Arabia. # Apparent noon times below are for Riyadh; your mileage will vary. *************** *** 381,388 **** # Before and after 1987, we'll operate on local mean solar time. # Zone NAME GMTOFF RULES/SAVE FORMAT [UNTIL] ! Zone Asia/Riyadh87 3:07:04 - ?? 1987 ! 3:07:04 sol87 ?? 1988 ! 3:07:04 - ?? # For backward compatibility... Link Asia/Riyadh87 Mideast/Riyadh87 --- 381,388 ---- # Before and after 1987, we'll operate on local mean solar time. # Zone NAME GMTOFF RULES/SAVE FORMAT [UNTIL] ! Zone Asia/Riyadh87 3:07:04 - zzz 1987 ! 3:07:04 sol87 zzz 1988 ! 3:07:04 - zzz # For backward compatibility... Link Asia/Riyadh87 Mideast/Riyadh87 diff -r -c old/solar88 new/solar88 *** old/solar88 Thu Apr 21 15:04:16 2005 --- new/solar88 Thu May 26 12:42:35 2005 *************** *** 1,4 **** ! # @(#)solar88 7.3 # Apparent noon times below are for Riyadh; they're a bit off for other places. # Times were computed using formulas in the U.S. Naval Observatory's --- 1,4 ---- ! # @(#)solar88 7.4 # Apparent noon times below are for Riyadh; they're a bit off for other places. # Times were computed using formulas in the U.S. Naval Observatory's *************** *** 381,388 **** # Before and after 1988, we'll operate on local mean solar time. # Zone NAME GMTOFF RULES/SAVE FORMAT [UNTIL] ! Zone Asia/Riyadh88 3:07:04 - ?? 1988 ! 3:07:04 sol88 ?? 1989 ! 3:07:04 - ?? # For backward compatibility... Link Asia/Riyadh88 Mideast/Riyadh88 --- 381,388 ---- # Before and after 1988, we'll operate on local mean solar time. # Zone NAME GMTOFF RULES/SAVE FORMAT [UNTIL] ! Zone Asia/Riyadh88 3:07:04 - zzz 1988 ! 3:07:04 sol88 zzz 1989 ! 3:07:04 - zzz # For backward compatibility... Link Asia/Riyadh88 Mideast/Riyadh88 diff -r -c old/solar89 new/solar89 *** old/solar89 Thu Apr 21 15:04:16 2005 --- new/solar89 Thu May 26 12:42:35 2005 *************** *** 1,4 **** ! # @(#)solar89 7.4 # Apparent noon times below are for Riyadh; they're a bit off for other places. # Times were computed using a formula provided by the U. S. Naval Observatory: --- 1,4 ---- ! # @(#)solar89 7.5 # Apparent noon times below are for Riyadh; they're a bit off for other places. # Times were computed using a formula provided by the U. S. Naval Observatory: *************** *** 386,393 **** # Before and after 1989, we'll operate on local mean solar time. # Zone NAME GMTOFF RULES/SAVE FORMAT [UNTIL] ! Zone Asia/Riyadh89 3:07:04 - ?? 1989 ! 3:07:04 sol89 ?? 1990 ! 3:07:04 - ?? # For backward compatibility... Link Asia/Riyadh89 Mideast/Riyadh89 --- 386,393 ---- # Before and after 1989, we'll operate on local mean solar time. # Zone NAME GMTOFF RULES/SAVE FORMAT [UNTIL] ! Zone Asia/Riyadh89 3:07:04 - zzz 1989 ! 3:07:04 sol89 zzz 1990 ! 3:07:04 - zzz # For backward compatibility... Link Asia/Riyadh89 Mideast/Riyadh89 diff -r -c old/zdump.c new/zdump.c *** old/zdump.c Mon Apr 4 11:24:32 2005 --- new/zdump.c Thu May 26 12:48:56 2005 *************** *** 1,4 **** ! static char elsieid[] = "@(#)zdump.c 7.64"; /* ** This code has been made independent of the rest of the time --- 1,4 ---- ! static char elsieid[] = "@(#)zdump.c 7.65"; /* ** This code has been made independent of the rest of the time *************** *** 144,151 **** --- 144,153 ---- static time_t absolute_max_time; static size_t longest; static char * progname; + static int warned; static char * abbr P((struct tm * tmp)); + static void abbrok P((const char * abbr, const char * zone)); static long delta P((struct tm * newp, struct tm * oldp)); static void dumptime P((const struct tm * tmp)); static time_t hunt P((char * name, time_t lot, time_t hit)); *************** *** 191,196 **** --- 193,236 ---- } #endif /* !defined TYPECHECK */ + static void + abbrok(abbr, zone) + const char * const abbr; + const char * const zone; + { + register int i; + register const char * cp; + register char * wp; + + if (warned) + return; + cp = abbr; + wp = NULL; + while (isascii(*cp) && isalpha(*cp)) + ++cp; + if (cp - abbr == 0) + wp = _("lacks alphabetic at start"); + if (cp - abbr < 3) + wp = _("has fewer than 3 alphabetics"); + if (cp - abbr > 6) + wp = _("has more than 6 alphabetics"); + if (wp == NULL && (*cp == '+' || *cp == '-')) { + ++cp; + if (isascii(*cp) && isdigit(*cp)) + if (*cp++ == '1' && *cp >= '0' && *cp <= '4') + ++cp; + } + if (*cp != '\0') + wp = _("differs from POSIX standard"); + if (wp == NULL) + return; + (void) fflush(stdout); + (void) fprintf(stderr, + "%s: warning: zone \"%s\" abbreviation \"%s\" %s\n", + progname, zone, abbr, wp); + warned = TRUE; + } + int main(argc, argv) int argc; *************** *** 297,302 **** --- 337,343 ---- show(argv[i], now, FALSE); continue; } + warned = FALSE; t = absolute_min_time; show(argv[i], t, TRUE); t += SECSPERHOUR * HOURSPERDAY; *************** *** 527,532 **** --- 568,575 ---- } } (void) printf("\n"); + if (tmp != NULL && *abbr(tmp) != '\0') + abbrok(abbr(tmp), zone); } static char * diff -r -c old/zic.c new/zic.c *** old/zic.c Mon Apr 4 11:24:32 2005 --- new/zic.c Thu May 26 14:54:07 2005 *************** *** 1,4 **** ! static char elsieid[] = "@(#)zic.c 7.122"; /* ** Regardless of the type of time_t, we do our work using this type. --- 1,4 ---- ! static char elsieid[] = "@(#)zic.c 7.124"; /* ** Regardless of the type of time_t, we do our work using this type. *************** *** 10,15 **** --- 10,19 ---- #include "locale.h" #include "tzfile.h" + #ifndef ZIC_MAX_ABBR_LEN_WO_WARN + #define ZIC_MAX_ABBR_LEN_WO_WARN 6 + #endif /* !defined ZIC_MAX_ABBR_LEN_WO_WARN */ + #if HAVE_SYS_STAT_H #include "sys/stat.h" #endif *************** *** 2196,2201 **** --- 2200,2240 ---- { register int i; + if (strcmp(string, GRANDPARENTED) != 0) { + register const char * cp; + register char * wp; + + /* + ** Want one to ZIC_MAX_ABBR_LEN_WO_WARN alphabetics + ** optionally followed by a + or - and a number from 1 to 14. + */ + cp = string; + wp = NULL; + while (isascii(*cp) && isalpha(*cp)) + ++cp; + if (cp - string == 0) + wp = _("time zone abbreviation lacks alphabetic at start"); + if (noise && cp - string > 3) + wp = _("time zone abbreviation has more than 3 alphabetics"); + if (cp - string > ZIC_MAX_ABBR_LEN_WO_WARN) + wp = _("time zone abbreviation has too many alphabetics"); + if (wp == NULL && (*cp == '+' || *cp == '-')) { + ++cp; + if (isascii(*cp) && isdigit(*cp)) + if (*cp++ == '1' && *cp >= '0' && *cp <= '4') + ++cp; + } + if (*cp != '\0') + wp = _("time zone abbreviation differs from POSIX standard"); + if (wp != NULL) { + wp = ecpyalloc(wp); + wp = ecatalloc(wp, " ("); + wp = ecatalloc(wp, string); + wp = ecatalloc(wp, ")"); + warning(wp); + ifree(wp); + } + } i = strlen(string) + 1; if (charcnt + i > TZ_MAX_CHARS) { error(_("too many, or too long, time zone abbreviations"));

12 34

revised proposed time zone abbreviation changes
by Arthur David Olson June 7, 2005

June 7, 2005

Thanks to folks for feedback on time zone abbreviation changes. Below find revised changes reflecting the feedback. The changes are relative to what's now available in the ftp directory. The revisions: 1. the set of characters allowed in time zone abbreviations has been expanded to include '.' (as in "E.S.T.") and '_' (on general principles). 2. the character substituted for those outside the approved set has been changed to '_' (a character which does not appear in any of the abbreviations that currently appear in the time zone data files). Regarding abbreviation lengths: I agree that some folks might want to use abbreviations shorter than three letters (in particular the old-style single-letter names for zones), so localtime.c is set up to allow fewer than three. It also allows up to 16 (covering abbreviations such as "XSTDST+hh:mm:ss" that Sun accepts). However, since the data files generated by zic might end up being used on systems with stricter requirements, it seems prudent to issue warnings (note: not errors) regarding short and long abbreviations. --ado diff -r -c old/Makefile new/Makefile *** old/Makefile Mon Apr 4 11:24:31 2005 --- new/Makefile Thu May 26 12:42:13 2005 *************** *** 1,4 **** ! # @(#)Makefile 7.108 # Change the line below for your time zone (after finding the zone you want in # the time zone files, or adding it to a time zone file). --- 1,4 ---- ! # @(#)Makefile 7.109 # Change the line below for your time zone (after finding the zone you want in # the time zone files, or adding it to a time zone file). *************** *** 111,117 **** # -DNO_RUN_TIME_WARNINGS_ABOUT_YEAR_2000_PROBLEMS_THANK_YOU=1 # if you do not want run time warnings about formats that may cause # year 2000 grief ! # GCC_DEBUG_FLAGS = -Dlint -g -O -fno-common \ -Wall -Wcast-qual -Wconversion -Wmissing-prototypes \ -Wnested-externs -Wpointer-arith -Wshadow \ --- 111,119 ---- # -DNO_RUN_TIME_WARNINGS_ABOUT_YEAR_2000_PROBLEMS_THANK_YOU=1 # if you do not want run time warnings about formats that may cause # year 2000 grief ! # -DZIC_MAX_ABBR_LEN_WO_WARN=3 ! # (or some other number) to set the maximum time zone abbreviation length ! # that zic will accept without a warning (the default is 6) GCC_DEBUG_FLAGS = -Dlint -g -O -fno-common \ -Wall -Wcast-qual -Wconversion -Wmissing-prototypes \ -Wnested-externs -Wpointer-arith -Wshadow \ diff -r -c old/localtime.c new/localtime.c *** old/localtime.c Mon Apr 4 11:24:32 2005 --- new/localtime.c Mon Jun 6 11:12:54 2005 *************** *** 5,11 **** #ifndef lint #ifndef NOID ! static char elsieid[] = "@(#)localtime.c 7.91"; #endif /* !defined NOID */ #endif /* !defined lint */ --- 5,11 ---- #ifndef lint #ifndef NOID ! static char elsieid[] = "@(#)localtime.c 7.94"; #endif /* !defined NOID */ #endif /* !defined lint */ *************** *** 22,27 **** --- 22,40 ---- #include "fcntl.h" #include "float.h" /* for FLT_MAX and DBL_MAX */ + #ifndef TZ_ABBR_MAX_LEN + #define TZ_ABBR_MAX_LEN 16 + #endif /* !defined TZ_ABBR_MAX_LEN */ + + #ifndef TZ_ABBR_CHAR_SET + #define TZ_ABBR_CHAR_SET \ + "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789 :+-._" + #endif /* !defined TZ_ABBR_CHAR_SET */ + + #ifndef TZ_ABBR_ERR_CHAR + #define TZ_ABBR_ERR_CHAR '_' + #endif /* !defined TZ_ABBR_ERR_CHAR */ + /* ** SunOS 4.1.1 headers lack O_BINARY. */ *************** *** 124,129 **** --- 137,143 ---- static long detzcode P((const char * codep)); static const char * getzname P((const char * strp)); + static const char * getqzname P((const char * strp, const char delim)); static const char * getnum P((const char * strp, int * nump, int min, int max)); static const char * getsecs P((const char * strp, long * secsp)); *************** *** 269,274 **** --- 283,306 ---- tzname[ttisp->tt_isdst] = &sp->chars[ttisp->tt_abbrind]; } + /* + ** Finally, scrub the abbreviations. + ** First, replace bogus characters. + */ + for (i = 0; i < sp->charcnt; ++i) + if (strchr(TZ_ABBR_CHAR_SET, sp->chars[i]) == NULL) + sp->chars[i] = TZ_ABBR_ERR_CHAR; + /* + ** Second, truncate long abbreviations. + */ + for (i = 0; i < sp->typecnt; ++i) { + register const struct ttinfo * const ttisp = &sp->ttis[i]; + register char * cp = &sp->chars[ttisp->tt_abbrind]; + + if (strlen(cp) > TZ_ABBR_MAX_LEN && + strcmp(cp, GRANDPARENTED) != 0) + *(cp + TZ_ABBR_MAX_LEN) = '\0'; + } } static int *************** *** 470,475 **** --- 502,528 ---- } /* + ** Given a pointer into an extended time zone string, scan until the ending + ** delimiter of the zone name is located. Return a pointer to the delimiter. + ** + ** As with getzname above, the legal character set is actually quite + ** restricted, with other characters producing undefined results. + ** We choose not to care - allowing almost anything to be in the zone abbrev. + */ + + static const char * + getqzname(strp, delim) + register const char * strp; + const char delim; + { + register char c; + + while ((c = *strp) != '\0' && c != delim) + ++strp; + return strp; + } + + /* ** Given a pointer into a time zone string, extract a number from that string. ** Check that the number is within a specified range; if it is not, return ** NULL. *************** *** 753,760 **** stdlen = (sizeof sp->chars) - 1; stdoffset = 0; } else { ! name = getzname(name); ! stdlen = name - stdname; if (stdlen < 3) return -1; if (*name == '\0') --- 806,823 ---- stdlen = (sizeof sp->chars) - 1; stdoffset = 0; } else { ! if (*name == '<') { ! name++; ! stdname = name; ! name = getqzname(name, '>'); ! if (*name != '>') ! return (-1); ! stdlen = name - stdname; ! name++; ! } else { ! name = getzname(name); ! stdlen = name - stdname; ! } if (stdlen < 3) return -1; if (*name == '\0') *************** *** 767,775 **** if (load_result != 0) sp->leapcnt = 0; /* so, we're off a little */ if (*name != '\0') { ! dstname = name; ! name = getzname(name); ! dstlen = name - dstname; /* length of DST zone name */ if (dstlen < 3) return -1; if (*name != '\0' && *name != ',' && *name != ';') { --- 830,847 ---- if (load_result != 0) sp->leapcnt = 0; /* so, we're off a little */ if (*name != '\0') { ! if (*name == '<') { ! dstname = ++name; ! name = getqzname(name, '>'); ! if (*name != '>') ! return -1; ! dstlen = name - dstname; ! name++; ! } else { ! dstname = name; ! name = getzname(name); ! dstlen = name - dstname; /* length of DST zone name */ ! } if (dstlen < 3) return -1; if (*name != '\0' && *name != ',' && *name != ';') { diff -r -c old/private.h new/private.h *** old/private.h Mon Apr 4 11:24:32 2005 --- new/private.h Thu May 26 14:54:07 2005 *************** *** 25,30 **** --- 25,32 ---- #endif /* !defined NOID */ #endif /* !defined lint */ + #define GRANDPARENTED "Local time zone must be set--see zic manual page" + /* ** Defaults for preprocessor symbols. ** You can override these in your C compiler options, e.g. `-DHAVE_ADJTIME=0'. diff -r -c old/solar87 new/solar87 *** old/solar87 Thu Apr 21 15:04:16 2005 --- new/solar87 Thu May 26 12:42:35 2005 *************** *** 1,4 **** ! # @(#)solar87 7.3 # So much for footnotes about Saudi Arabia. # Apparent noon times below are for Riyadh; your mileage will vary. --- 1,4 ---- ! # @(#)solar87 7.4 # So much for footnotes about Saudi Arabia. # Apparent noon times below are for Riyadh; your mileage will vary. *************** *** 381,388 **** # Before and after 1987, we'll operate on local mean solar time. # Zone NAME GMTOFF RULES/SAVE FORMAT [UNTIL] ! Zone Asia/Riyadh87 3:07:04 - ?? 1987 ! 3:07:04 sol87 ?? 1988 ! 3:07:04 - ?? # For backward compatibility... Link Asia/Riyadh87 Mideast/Riyadh87 --- 381,388 ---- # Before and after 1987, we'll operate on local mean solar time. # Zone NAME GMTOFF RULES/SAVE FORMAT [UNTIL] ! Zone Asia/Riyadh87 3:07:04 - zzz 1987 ! 3:07:04 sol87 zzz 1988 ! 3:07:04 - zzz # For backward compatibility... Link Asia/Riyadh87 Mideast/Riyadh87 diff -r -c old/solar88 new/solar88 *** old/solar88 Thu Apr 21 15:04:16 2005 --- new/solar88 Thu May 26 12:42:35 2005 *************** *** 1,4 **** ! # @(#)solar88 7.3 # Apparent noon times below are for Riyadh; they're a bit off for other places. # Times were computed using formulas in the U.S. Naval Observatory's --- 1,4 ---- ! # @(#)solar88 7.4 # Apparent noon times below are for Riyadh; they're a bit off for other places. # Times were computed using formulas in the U.S. Naval Observatory's *************** *** 381,388 **** # Before and after 1988, we'll operate on local mean solar time. # Zone NAME GMTOFF RULES/SAVE FORMAT [UNTIL] ! Zone Asia/Riyadh88 3:07:04 - ?? 1988 ! 3:07:04 sol88 ?? 1989 ! 3:07:04 - ?? # For backward compatibility... Link Asia/Riyadh88 Mideast/Riyadh88 --- 381,388 ---- # Before and after 1988, we'll operate on local mean solar time. # Zone NAME GMTOFF RULES/SAVE FORMAT [UNTIL] ! Zone Asia/Riyadh88 3:07:04 - zzz 1988 ! 3:07:04 sol88 zzz 1989 ! 3:07:04 - zzz # For backward compatibility... Link Asia/Riyadh88 Mideast/Riyadh88 diff -r -c old/solar89 new/solar89 *** old/solar89 Thu Apr 21 15:04:16 2005 --- new/solar89 Thu May 26 12:42:35 2005 *************** *** 1,4 **** ! # @(#)solar89 7.4 # Apparent noon times below are for Riyadh; they're a bit off for other places. # Times were computed using a formula provided by the U. S. Naval Observatory: --- 1,4 ---- ! # @(#)solar89 7.5 # Apparent noon times below are for Riyadh; they're a bit off for other places. # Times were computed using a formula provided by the U. S. Naval Observatory: *************** *** 386,393 **** # Before and after 1989, we'll operate on local mean solar time. # Zone NAME GMTOFF RULES/SAVE FORMAT [UNTIL] ! Zone Asia/Riyadh89 3:07:04 - ?? 1989 ! 3:07:04 sol89 ?? 1990 ! 3:07:04 - ?? # For backward compatibility... Link Asia/Riyadh89 Mideast/Riyadh89 --- 386,393 ---- # Before and after 1989, we'll operate on local mean solar time. # Zone NAME GMTOFF RULES/SAVE FORMAT [UNTIL] ! Zone Asia/Riyadh89 3:07:04 - zzz 1989 ! 3:07:04 sol89 zzz 1990 ! 3:07:04 - zzz # For backward compatibility... Link Asia/Riyadh89 Mideast/Riyadh89 diff -r -c old/zdump.c new/zdump.c *** old/zdump.c Mon Apr 4 11:24:32 2005 --- new/zdump.c Thu May 26 12:48:56 2005 *************** *** 1,4 **** ! static char elsieid[] = "@(#)zdump.c 7.64"; /* ** This code has been made independent of the rest of the time --- 1,4 ---- ! static char elsieid[] = "@(#)zdump.c 7.65"; /* ** This code has been made independent of the rest of the time *************** *** 144,151 **** --- 144,153 ---- static time_t absolute_max_time; static size_t longest; static char * progname; + static int warned; static char * abbr P((struct tm * tmp)); + static void abbrok P((const char * abbr, const char * zone)); static long delta P((struct tm * newp, struct tm * oldp)); static void dumptime P((const struct tm * tmp)); static time_t hunt P((char * name, time_t lot, time_t hit)); *************** *** 191,196 **** --- 193,236 ---- } #endif /* !defined TYPECHECK */ + static void + abbrok(abbr, zone) + const char * const abbr; + const char * const zone; + { + register int i; + register const char * cp; + register char * wp; + + if (warned) + return; + cp = abbr; + wp = NULL; + while (isascii(*cp) && isalpha(*cp)) + ++cp; + if (cp - abbr == 0) + wp = _("lacks alphabetic at start"); + if (cp - abbr < 3) + wp = _("has fewer than 3 alphabetics"); + if (cp - abbr > 6) + wp = _("has more than 6 alphabetics"); + if (wp == NULL && (*cp == '+' || *cp == '-')) { + ++cp; + if (isascii(*cp) && isdigit(*cp)) + if (*cp++ == '1' && *cp >= '0' && *cp <= '4') + ++cp; + } + if (*cp != '\0') + wp = _("differs from POSIX standard"); + if (wp == NULL) + return; + (void) fflush(stdout); + (void) fprintf(stderr, + "%s: warning: zone \"%s\" abbreviation \"%s\" %s\n", + progname, zone, abbr, wp); + warned = TRUE; + } + int main(argc, argv) int argc; *************** *** 297,302 **** --- 337,343 ---- show(argv[i], now, FALSE); continue; } + warned = FALSE; t = absolute_min_time; show(argv[i], t, TRUE); t += SECSPERHOUR * HOURSPERDAY; *************** *** 527,532 **** --- 568,575 ---- } } (void) printf("\n"); + if (tmp != NULL && *abbr(tmp) != '\0') + abbrok(abbr(tmp), zone); } static char * diff -r -c old/zic.c new/zic.c *** old/zic.c Mon Apr 4 11:24:32 2005 --- new/zic.c Thu May 26 14:54:07 2005 *************** *** 1,4 **** ! static char elsieid[] = "@(#)zic.c 7.122"; /* ** Regardless of the type of time_t, we do our work using this type. --- 1,4 ---- ! static char elsieid[] = "@(#)zic.c 7.124"; /* ** Regardless of the type of time_t, we do our work using this type. *************** *** 10,15 **** --- 10,19 ---- #include "locale.h" #include "tzfile.h" + #ifndef ZIC_MAX_ABBR_LEN_WO_WARN + #define ZIC_MAX_ABBR_LEN_WO_WARN 6 + #endif /* !defined ZIC_MAX_ABBR_LEN_WO_WARN */ + #if HAVE_SYS_STAT_H #include "sys/stat.h" #endif *************** *** 2196,2201 **** --- 2200,2240 ---- { register int i; + if (strcmp(string, GRANDPARENTED) != 0) { + register const char * cp; + register char * wp; + + /* + ** Want one to ZIC_MAX_ABBR_LEN_WO_WARN alphabetics + ** optionally followed by a + or - and a number from 1 to 14. + */ + cp = string; + wp = NULL; + while (isascii(*cp) && isalpha(*cp)) + ++cp; + if (cp - string == 0) + wp = _("time zone abbreviation lacks alphabetic at start"); + if (noise && cp - string > 3) + wp = _("time zone abbreviation has more than 3 alphabetics"); + if (cp - string > ZIC_MAX_ABBR_LEN_WO_WARN) + wp = _("time zone abbreviation has too many alphabetics"); + if (wp == NULL && (*cp == '+' || *cp == '-')) { + ++cp; + if (isascii(*cp) && isdigit(*cp)) + if (*cp++ == '1' && *cp >= '0' && *cp <= '4') + ++cp; + } + if (*cp != '\0') + wp = _("time zone abbreviation differs from POSIX standard"); + if (wp != NULL) { + wp = ecpyalloc(wp); + wp = ecatalloc(wp, " ("); + wp = ecatalloc(wp, string); + wp = ecatalloc(wp, ")"); + warning(wp); + ifree(wp); + } + } i = strlen(string) + 1; if (charcnt + i > TZ_MAX_CHARS) { error(_("too many, or too long, time zone abbreviations"));

2 1