RE: revised proposed time zone abbreviation changes
That "stdlen < 3" remains, I'd make it just be "if (stdlen == 0)" (for the error return). < 0 is impossible the way the code is written, so there's no need to test that. Anything > 0 in that context should be OK.
It might be best to simply remove the test, relying on the common-case code to catch any problems. (This would avoid surprises down the line involving a need to change two length tests rather than one.) --ado
Date: Tue, 7 Jun 2005 11:28:35 -0400 From: "Olson, Arthur David (NIH/NCI)" <olsona@dc37a.nci.nih.gov> Message-ID: <75DDD376F2B6B546B722398AC161106C740427@nihexchange2.nih.gov> | It might be best to simply remove the test, relying on the common-case code | to catch any problems. If that causes no problems to the code elsewhere, that's fine - I didn't analyse it fully enough to be able to be confident enough to suggest that. kre
participants (2)
-
Olson, Arthur David (NIH/NCI) -
Robert Elz