- tz - lists.iana.org

FW: Test cases for zoneinfo data
by Olson, Arthur David (NIH/NCI) [E] Dec. 16, 2010

Dec. 16, 2010

I'm forwarding this message from Christopher Hunt, who is not on the time zone mailing list. Those of you who are on the list, please direct replies appropriately. --ado -----Original Message----- From: Christopher Hunt [mailto:huntc@internode.on.net] Sent: Thursday, December 16, 2010 6:36 To: yoshito_umaoka(a)us.ibm.com Cc: tz(a)lecserver.nci.nih.gov; 'tz(a)elsie.nci.nih.gov' Subject: Re: Test cases for zoneinfo data Firstly, thanks for the responses. My responses are inline below. >> I'm creating a set of Java classes that closely reflect the structure >> of > the >> Zoneinfo database. My requirement is driven mostly by wanting to >> dynamically update Java TimeZone classes i.e. as opposed to compiling >> a zoneinfo data and re-starting my application. > > You probably want to look into JSR-310. TZDBZoneRulesCompiler in > JSR-310 creates ZoneRules from the tz database source files. Ah - I certainly didn't know about this so thanks for the "heads-up". At first glance though, I don't see that Zoneinfo's structures are being faithfully reproduced here. I suppose another motivation for me was to stick to the Zoneinfo structure given that it is highly evolved and flexible. Please see the attached class diagram of what I'm working to and do feel free to voice your opinion. ZoneinfoTimeZone is a JDK compatible TimeZone facade whereas the rest are intended to represent Zoneinfo structures in an object oriented manner.

1 0

Future time zone home
by Olson, Arthur David (NIH/NCI) [E] Dec. 16, 2010

Dec. 16, 2010

In response to the need to find a new time zone home before I'm eligible to retire in 2012, Eliot Lear and Paul Eggert have authored the draft document "IANA Procedures for Maintaining the Timezone Database" now available from the Internet Engineering Task Force (IETF) web site: http://tools.ietf.org/html/draft-lear-iana-timezone-database-00 Comments on how the draft can be improved are welcome. Also welcome: feedback on whether the proposed approach meets the needs of folks on the time zone mailing list--the proposed approach can't and won't go forward without support from the time zone community. The document includes electronic mail addresses for Eliot and Paul; general comments can also be sent to the time zone mailing list. --ado

6 6

Test cases for zoneinfo data
by Christopher Hunt Dec. 16, 2010

Dec. 16, 2010

Hi there, I'm creating a set of Java classes that closely reflect the structure of the Zoneinfo database. My requirement is driven mostly by wanting to dynamically update Java TimeZone classes i.e. as opposed to compiling a zoneinfo data and re-starting my application. In addition I feel that the ICU and Sun classes do not accurately reflect Zoneinfo structures. I shall open-source this project once it gets to a working point. It'd be terribly helpful if I could get hold of some test cases, automated or otherwise, that verify correct time zone calculations. Would anyone out there have such things? Kind regards, Christopher

1 0

time zone database open questions
by Arthur David Olson Dec. 9, 2010

Dec. 9, 2010

Here are the open time zone database questions I know of. Are the others? 1. Did all of Mexico's Baja California Norte use United States DST rules in 2010, or did only border areas use U.S. DST? What of other Mexican states on the U.S. border? 2. How was DST handled in the West Bank and in Gaza in 2010? How was it handled in previous years? 3. What's the accurate history of the change to use of Shanghai/Beijing time in China? 4. Is there an acceptable way of handling present-day dual timekeeping in Xinjiang, China without either losing track of past practices? 5. Did Windsor and other parts of Ontario, Canada use different DST rules in the past? (See Mark Brader's communication at the end of this message.) --ado # From Mark Brader (2010-03-06): # ... # In the (Toronto) Globe and Mail for Saturday, 1955-09-24, in the bottom # right corner of page 1, it says that Toronto will return to standard # time at 2 am Sunday morning (which agrees with the database), and that: # # The one-hour setback will go into effect throughout most of Ontario, # except in areas like Windsor which remains on standard time all year. # # Windsor is, of course, a lot larger than Nipigon. # # I only came across this incidentally. I don't know if Windsor began # observing DST when Detroit did, or in 1974, or on some other date. # # By the way, the article continues by noting that: # # Some cities in the United States have pushed the deadline back # three weeks and will change over from daylight saving in October.

4 3

update tz-link.htm to add mkdir tz and cd tz like in README
by Gilles Espinasse Dec. 6, 2010

Dec. 6, 2010

I just followed the instructions in tz-link.htm before to see there is no top directory in tz*.tar.gz To avoid that same mistake for others, please find a patch that update tz-link.htm to have the same instructions than in README ( with mkdir tz and cd tz before wget) Gilles

2 1

2nd reading of "Daylight Saving Bill 2010-11" in UK Parliament
by Philip.Pizzey＠sita.aero Dec. 1, 2010

Dec. 1, 2010

Hi there, you may already be aware of this but today's BBC Radio 4 programme "You and Yours" contained a feature about Rebecca Harris MP's Private Members Bill in the UK Parliament. The Bill is entitled "Daylight Saving Bill 2010-11" and proposes "The Bill would require the Government to conduct a cross-departmental analysis of the potential costs and benefits of advancing time by one hour for all, or part of, the year.". The Bill is due for it's second reading in the House of Commons on 3rd December 2010. Here is a link to the You and Yours homepage which does not at this time mention the feature: http://www.bbc.co.uk/radio4/features/you-and-yours and a link to the bill itself: http://services.parliament.uk/bills/2010-11/daylightsaving.html Cheers, Phil. This document is strictly confidential and intended only for use by the addressee unless otherwise stated. If you are not the intended recipient, please notify the sender immediately and delete it from your system.

1 0

FW: stack overflow in tzload
by Olson, Arthur David (NIH/NCI) [E] Nov. 26, 2010

Nov. 26, 2010

I'm forwarding this message from Ted Unangst, who is not on the time zone mailing list. Those of you who are on the list, please direct replies appropriately. --ado -----Original Message----- From: Ted Unangst [mailto:ted.unangst@gmail.com] Sent: Monday, November 22, 2010 6:22 To: tz(a)lecserver.nci.nih.gov Subject: stack overflow in tzload Stack overflow as in there's not enough stack. I ran into this problem running a program on openbsd that was using a fairly small thread size. I switched to using malloc. Index: localtime.c =================================================================== RCS file: /home/tedu/cvs/src/lib/libc/time/localtime.c,v retrieving revision 1.35 diff -u -r1.35 localtime.c --- localtime.c 23 Aug 2010 22:35:34 -0000 1.35 +++ localtime.c 20 Nov 2010 23:32:09 -0000 @@ -340,7 +340,7 @@ char buf[2 * sizeof(struct tzhead) + 2 * sizeof *sp + 4 * TZ_MAX_TIMES]; - } u; + } *u; sp->goback = sp->goahead = FALSE; if (name != NULL && issetugid() != 0) @@ -383,28 +383,33 @@ if ((fid = open(name, OPEN_MODE)) == -1) return -1; } - nread = read(fid, u.buf, sizeof u.buf); - if (close(fid) < 0 || nread <= 0) + u = malloc(sizeof(*u)); + if (!u) { + close(fid); return -1; + } + nread = read(fid, u->buf, sizeof u->buf); + if (close(fid) < 0 || nread <= 0) + goto bad; for (stored = 4; stored <= 8; stored *= 2) { int ttisstdcnt; int ttisgmtcnt; - ttisstdcnt = (int) detzcode(u.tzhead.tzh_ttisstdcnt); - ttisgmtcnt = (int) detzcode(u.tzhead.tzh_ttisgmtcnt); - sp->leapcnt = (int) detzcode(u.tzhead.tzh_leapcnt); - sp->timecnt = (int) detzcode(u.tzhead.tzh_timecnt); - sp->typecnt = (int) detzcode(u.tzhead.tzh_typecnt); - sp->charcnt = (int) detzcode(u.tzhead.tzh_charcnt); - p = u.tzhead.tzh_charcnt + sizeof u.tzhead.tzh_charcnt; + ttisstdcnt = (int) detzcode(u->tzhead.tzh_ttisstdcnt); + ttisgmtcnt = (int) detzcode(u->tzhead.tzh_ttisgmtcnt); + sp->leapcnt = (int) detzcode(u->tzhead.tzh_leapcnt); + sp->timecnt = (int) detzcode(u->tzhead.tzh_timecnt); + sp->typecnt = (int) detzcode(u->tzhead.tzh_typecnt); + sp->charcnt = (int) detzcode(u->tzhead.tzh_charcnt); + p = u->tzhead.tzh_charcnt + sizeof u->tzhead.tzh_charcnt; if (sp->leapcnt < 0 || sp->leapcnt > TZ_MAX_LEAPS || sp->typecnt <= 0 || sp->typecnt > TZ_MAX_TYPES || sp->timecnt < 0 || sp->timecnt > TZ_MAX_TIMES || sp->charcnt < 0 || sp->charcnt > TZ_MAX_CHARS || (ttisstdcnt != sp->typecnt && ttisstdcnt != 0) || (ttisgmtcnt != sp->typecnt && ttisgmtcnt != 0)) - return -1; - if (nread - (p - u.buf) < + goto bad; + if (nread - (p - u->buf) < sp->timecnt * stored + /* ats */ sp->timecnt + /* types */ sp->typecnt * 6 + /* ttinfos */ @@ -412,7 +417,7 @@ sp->leapcnt * (stored + 4) + /* lsinfos */ ttisstdcnt + /* ttisstds */ ttisgmtcnt) /* ttisgmts */ - return -1; + goto bad; for (i = 0; i < sp->timecnt; ++i) { sp->ats[i] = (stored == 4) ? detzcode(p) : detzcode64(p); @@ -421,7 +426,7 @@ for (i = 0; i < sp->timecnt; ++i) { sp->types[i] = (unsigned char) *p++; if (sp->types[i] >= sp->typecnt) - return -1; + goto bad; } for (i = 0; i < sp->typecnt; ++i) { register struct ttinfo * ttisp; @@ -431,11 +436,11 @@ p += 4; ttisp->tt_isdst = (unsigned char) *p++; if (ttisp->tt_isdst != 0 && ttisp->tt_isdst != 1) - return -1; + goto bad; ttisp->tt_abbrind = (unsigned char) *p++; if (ttisp->tt_abbrind < 0 || ttisp->tt_abbrind > sp->charcnt) - return -1; + goto bad; } for (i = 0; i < sp->charcnt; ++i) sp->chars[i] = *p++; @@ -460,7 +465,7 @@ ttisp->tt_ttisstd = *p++; if (ttisp->tt_ttisstd != TRUE && ttisp->tt_ttisstd != FALSE) - return -1; + goto bad; } } for (i = 0; i < sp->typecnt; ++i) { @@ -473,7 +478,7 @@ ttisp->tt_ttisgmt = *p++; if (ttisp->tt_ttisgmt != TRUE && ttisp->tt_ttisgmt != FALSE) - return -1; + goto bad; } } /* @@ -506,11 +511,11 @@ /* ** If this is an old file, we're done. */ - if (u.tzhead.tzh_version[0] == '\0') + if (u->tzhead.tzh_version[0] == '\0') break; - nread -= p - u.buf; + nread -= p - u->buf; for (i = 0; i < nread; ++i) - u.buf[i] = p[i]; + u->buf[i] = p[i]; /* ** If this is a narrow integer time_t system, we're done. */ @@ -518,13 +523,13 @@ break; } if (doextend && nread > 2 && - u.buf[0] == '\n' && u.buf[nread - 1] == '\n' && + u->buf[0] == '\n' && u->buf[nread - 1] == '\n' && sp->typecnt + 2 <= TZ_MAX_TYPES) { struct state ts; register int result; - u.buf[nread - 1] = '\0'; - result = tzparse(&u.buf[1], &ts, FALSE); + u->buf[nread - 1] = '\0'; + result = tzparse(&u->buf[1], &ts, FALSE); if (result == 0 && ts.typecnt == 2 && sp->charcnt + ts.charcnt <= TZ_MAX_CHARS) { for (i = 0; i < 2; ++i) @@ -568,7 +573,11 @@ break; } } + free(u); return 0; +bad: + free(u); + return -1; } static int

7 6

FW: FW: stack overflow in tzload
by Olson, Arthur David (NIH/NCI) [E] Nov. 23, 2010

Nov. 23, 2010

I'm forwarding this message from Ted Unangst, who is not on the time zone mailing list. Those of you who are on the list, please direct replies appropriately. --ado -----Original Message----- From: Ted Unangst [mailto:ted.unangst@gmail.com] Sent: Tuesday, November 23, 2010 10:08 To: Christos Zoulas Cc: tz(a)elsie.nci.nih.gov; tz(a)lecserver.nci.nih.gov; Olson, Arthur David (NIH/NCI) [E] Subject: Re: FW: stack overflow in tzload On Mon, Nov 22, 2010 at 11:28 PM, Christos Zoulas <christos(a)zoulas.com> wrote: > On Nov 22, 4:44pm, eggert(a)cs.ucla.edu (Paul Eggert) wrote: > -- Subject: Re: FW: stack overflow in tzload > > | Surely this sort of change should be put in only conditionally. > | On most machines, the change would will slow performance down due to the > | malloc overhead and would add one more point of failure. > | Only on machines with tiny stacks is the change a win. > > Sure, but these days the cost of malloc is really small, and having more > ifdefs in the code just cause more maintenance. So we either adopt the > change, or we just tell Ted that if you run with < 256K of stack you > can expect lots of things to break - not just that - so give yourself more All fair points, but it happens that this is the thing that broke. Smallish stacks are not uncommon if you expect to be creating many threads (the app in question is a of web server not of my own design, I'm not even sure what stack size it expects). The real wrinkle is that the tz code is part of the system library, I expect it to just work. If somebody had asked last week "How much stack does calling gmtime() require?", I suspect most people's answers would fall short of the mark, apart from maybe a very few people on this list. We can just patch this in openbsd, it's not that big a deal, but wanted to pass the change upstream as well.

1 0

stack overflow in tzload
by Ted Unangst Nov. 22, 2010

Nov. 22, 2010

Stack overflow as in there's not enough stack. I ran into this problem running a program on openbsd that was using a fairly small thread size. I switched to using malloc. Index: localtime.c =================================================================== RCS file: /home/tedu/cvs/src/lib/libc/time/localtime.c,v retrieving revision 1.35 diff -u -r1.35 localtime.c --- localtime.c 23 Aug 2010 22:35:34 -0000 1.35 +++ localtime.c 20 Nov 2010 23:32:09 -0000 @@ -340,7 +340,7 @@ char buf[2 * sizeof(struct tzhead) + 2 * sizeof *sp + 4 * TZ_MAX_TIMES]; - } u; + } *u; sp->goback = sp->goahead = FALSE; if (name != NULL && issetugid() != 0) @@ -383,28 +383,33 @@ if ((fid = open(name, OPEN_MODE)) == -1) return -1; } - nread = read(fid, u.buf, sizeof u.buf); - if (close(fid) < 0 || nread <= 0) + u = malloc(sizeof(*u)); + if (!u) { + close(fid); return -1; + } + nread = read(fid, u->buf, sizeof u->buf); + if (close(fid) < 0 || nread <= 0) + goto bad; for (stored = 4; stored <= 8; stored *= 2) { int ttisstdcnt; int ttisgmtcnt; - ttisstdcnt = (int) detzcode(u.tzhead.tzh_ttisstdcnt); - ttisgmtcnt = (int) detzcode(u.tzhead.tzh_ttisgmtcnt); - sp->leapcnt = (int) detzcode(u.tzhead.tzh_leapcnt); - sp->timecnt = (int) detzcode(u.tzhead.tzh_timecnt); - sp->typecnt = (int) detzcode(u.tzhead.tzh_typecnt); - sp->charcnt = (int) detzcode(u.tzhead.tzh_charcnt); - p = u.tzhead.tzh_charcnt + sizeof u.tzhead.tzh_charcnt; + ttisstdcnt = (int) detzcode(u->tzhead.tzh_ttisstdcnt); + ttisgmtcnt = (int) detzcode(u->tzhead.tzh_ttisgmtcnt); + sp->leapcnt = (int) detzcode(u->tzhead.tzh_leapcnt); + sp->timecnt = (int) detzcode(u->tzhead.tzh_timecnt); + sp->typecnt = (int) detzcode(u->tzhead.tzh_typecnt); + sp->charcnt = (int) detzcode(u->tzhead.tzh_charcnt); + p = u->tzhead.tzh_charcnt + sizeof u->tzhead.tzh_charcnt; if (sp->leapcnt < 0 || sp->leapcnt > TZ_MAX_LEAPS || sp->typecnt <= 0 || sp->typecnt > TZ_MAX_TYPES || sp->timecnt < 0 || sp->timecnt > TZ_MAX_TIMES || sp->charcnt < 0 || sp->charcnt > TZ_MAX_CHARS || (ttisstdcnt != sp->typecnt && ttisstdcnt != 0) || (ttisgmtcnt != sp->typecnt && ttisgmtcnt != 0)) - return -1; - if (nread - (p - u.buf) < + goto bad; + if (nread - (p - u->buf) < sp->timecnt * stored + /* ats */ sp->timecnt + /* types */ sp->typecnt * 6 + /* ttinfos */ @@ -412,7 +417,7 @@ sp->leapcnt * (stored + 4) + /* lsinfos */ ttisstdcnt + /* ttisstds */ ttisgmtcnt) /* ttisgmts */ - return -1; + goto bad; for (i = 0; i < sp->timecnt; ++i) { sp->ats[i] = (stored == 4) ? detzcode(p) : detzcode64(p); @@ -421,7 +426,7 @@ for (i = 0; i < sp->timecnt; ++i) { sp->types[i] = (unsigned char) *p++; if (sp->types[i] >= sp->typecnt) - return -1; + goto bad; } for (i = 0; i < sp->typecnt; ++i) { register struct ttinfo * ttisp; @@ -431,11 +436,11 @@ p += 4; ttisp->tt_isdst = (unsigned char) *p++; if (ttisp->tt_isdst != 0 && ttisp->tt_isdst != 1) - return -1; + goto bad; ttisp->tt_abbrind = (unsigned char) *p++; if (ttisp->tt_abbrind < 0 || ttisp->tt_abbrind > sp->charcnt) - return -1; + goto bad; } for (i = 0; i < sp->charcnt; ++i) sp->chars[i] = *p++; @@ -460,7 +465,7 @@ ttisp->tt_ttisstd = *p++; if (ttisp->tt_ttisstd != TRUE && ttisp->tt_ttisstd != FALSE) - return -1; + goto bad; } } for (i = 0; i < sp->typecnt; ++i) { @@ -473,7 +478,7 @@ ttisp->tt_ttisgmt = *p++; if (ttisp->tt_ttisgmt != TRUE && ttisp->tt_ttisgmt != FALSE) - return -1; + goto bad; } } /* @@ -506,11 +511,11 @@ /* ** If this is an old file, we're done. */ - if (u.tzhead.tzh_version[0] == '\0') + if (u->tzhead.tzh_version[0] == '\0') break; - nread -= p - u.buf; + nread -= p - u->buf; for (i = 0; i < nread; ++i) - u.buf[i] = p[i]; + u->buf[i] = p[i]; /* ** If this is a narrow integer time_t system, we're done. */ @@ -518,13 +523,13 @@ break; } if (doextend && nread > 2 && - u.buf[0] == '\n' && u.buf[nread - 1] == '\n' && + u->buf[0] == '\n' && u->buf[nread - 1] == '\n' && sp->typecnt + 2 <= TZ_MAX_TYPES) { struct state ts; register int result; - u.buf[nread - 1] = '\0'; - result = tzparse(&u.buf[1], &ts, FALSE); + u->buf[nread - 1] = '\0'; + result = tzparse(&u->buf[1], &ts, FALSE); if (result == 0 && ts.typecnt == 2 && sp->charcnt + ts.charcnt <= TZ_MAX_CHARS) { for (i = 0; i < 2; ++i) @@ -568,7 +573,11 @@ break; } } + free(u); return 0; +bad: + free(u); + return -1; } static int

1 0

2010m
by Olson, Arthur David (NIH/NCI) [E] Nov. 21, 2010

Nov. 21, 2010

The files... ftp://elsie.nci.nih.gov/pub/tzcode2010m.tar.gz ...and... ftp://elsie.nci.nih.gov/pub/tzdata2010m.tar.gz ...are now available; these reflect the Hong Kong, Vostok, and zic.c changes circulated recently on the time zone mailing list. --ado

3 2