- tz - lists.iana.org

FW: FW: stack overflow in tzload
by Olson, Arthur David (NIH/NCI) [E] Nov. 23, 2010

Nov. 23, 2010

I'm forwarding this message from Ted Unangst, who is not on the time zone mailing list. Those of you who are on the list, please direct replies appropriately. --ado -----Original Message----- From: Ted Unangst [mailto:ted.unangst@gmail.com] Sent: Tuesday, November 23, 2010 10:08 To: Christos Zoulas Cc: tz(a)elsie.nci.nih.gov; tz(a)lecserver.nci.nih.gov; Olson, Arthur David (NIH/NCI) [E] Subject: Re: FW: stack overflow in tzload On Mon, Nov 22, 2010 at 11:28 PM, Christos Zoulas <christos(a)zoulas.com> wrote: > On Nov 22, 4:44pm, eggert(a)cs.ucla.edu (Paul Eggert) wrote: > -- Subject: Re: FW: stack overflow in tzload > > | Surely this sort of change should be put in only conditionally. > | On most machines, the change would will slow performance down due to the > | malloc overhead and would add one more point of failure. > | Only on machines with tiny stacks is the change a win. > > Sure, but these days the cost of malloc is really small, and having more > ifdefs in the code just cause more maintenance. So we either adopt the > change, or we just tell Ted that if you run with < 256K of stack you > can expect lots of things to break - not just that - so give yourself more All fair points, but it happens that this is the thing that broke. Smallish stacks are not uncommon if you expect to be creating many threads (the app in question is a of web server not of my own design, I'm not even sure what stack size it expects). The real wrinkle is that the tz code is part of the system library, I expect it to just work. If somebody had asked last week "How much stack does calling gmtime() require?", I suspect most people's answers would fall short of the mark, apart from maybe a very few people on this list. We can just patch this in openbsd, it's not that big a deal, but wanted to pass the change upstream as well.

1 0

stack overflow in tzload
by Ted Unangst Nov. 22, 2010

Nov. 22, 2010

Stack overflow as in there's not enough stack. I ran into this problem running a program on openbsd that was using a fairly small thread size. I switched to using malloc. Index: localtime.c =================================================================== RCS file: /home/tedu/cvs/src/lib/libc/time/localtime.c,v retrieving revision 1.35 diff -u -r1.35 localtime.c --- localtime.c 23 Aug 2010 22:35:34 -0000 1.35 +++ localtime.c 20 Nov 2010 23:32:09 -0000 @@ -340,7 +340,7 @@ char buf[2 * sizeof(struct tzhead) + 2 * sizeof *sp + 4 * TZ_MAX_TIMES]; - } u; + } *u; sp->goback = sp->goahead = FALSE; if (name != NULL && issetugid() != 0) @@ -383,28 +383,33 @@ if ((fid = open(name, OPEN_MODE)) == -1) return -1; } - nread = read(fid, u.buf, sizeof u.buf); - if (close(fid) < 0 || nread <= 0) + u = malloc(sizeof(*u)); + if (!u) { + close(fid); return -1; + } + nread = read(fid, u->buf, sizeof u->buf); + if (close(fid) < 0 || nread <= 0) + goto bad; for (stored = 4; stored <= 8; stored *= 2) { int ttisstdcnt; int ttisgmtcnt; - ttisstdcnt = (int) detzcode(u.tzhead.tzh_ttisstdcnt); - ttisgmtcnt = (int) detzcode(u.tzhead.tzh_ttisgmtcnt); - sp->leapcnt = (int) detzcode(u.tzhead.tzh_leapcnt); - sp->timecnt = (int) detzcode(u.tzhead.tzh_timecnt); - sp->typecnt = (int) detzcode(u.tzhead.tzh_typecnt); - sp->charcnt = (int) detzcode(u.tzhead.tzh_charcnt); - p = u.tzhead.tzh_charcnt + sizeof u.tzhead.tzh_charcnt; + ttisstdcnt = (int) detzcode(u->tzhead.tzh_ttisstdcnt); + ttisgmtcnt = (int) detzcode(u->tzhead.tzh_ttisgmtcnt); + sp->leapcnt = (int) detzcode(u->tzhead.tzh_leapcnt); + sp->timecnt = (int) detzcode(u->tzhead.tzh_timecnt); + sp->typecnt = (int) detzcode(u->tzhead.tzh_typecnt); + sp->charcnt = (int) detzcode(u->tzhead.tzh_charcnt); + p = u->tzhead.tzh_charcnt + sizeof u->tzhead.tzh_charcnt; if (sp->leapcnt < 0 || sp->leapcnt > TZ_MAX_LEAPS || sp->typecnt <= 0 || sp->typecnt > TZ_MAX_TYPES || sp->timecnt < 0 || sp->timecnt > TZ_MAX_TIMES || sp->charcnt < 0 || sp->charcnt > TZ_MAX_CHARS || (ttisstdcnt != sp->typecnt && ttisstdcnt != 0) || (ttisgmtcnt != sp->typecnt && ttisgmtcnt != 0)) - return -1; - if (nread - (p - u.buf) < + goto bad; + if (nread - (p - u->buf) < sp->timecnt * stored + /* ats */ sp->timecnt + /* types */ sp->typecnt * 6 + /* ttinfos */ @@ -412,7 +417,7 @@ sp->leapcnt * (stored + 4) + /* lsinfos */ ttisstdcnt + /* ttisstds */ ttisgmtcnt) /* ttisgmts */ - return -1; + goto bad; for (i = 0; i < sp->timecnt; ++i) { sp->ats[i] = (stored == 4) ? detzcode(p) : detzcode64(p); @@ -421,7 +426,7 @@ for (i = 0; i < sp->timecnt; ++i) { sp->types[i] = (unsigned char) *p++; if (sp->types[i] >= sp->typecnt) - return -1; + goto bad; } for (i = 0; i < sp->typecnt; ++i) { register struct ttinfo * ttisp; @@ -431,11 +436,11 @@ p += 4; ttisp->tt_isdst = (unsigned char) *p++; if (ttisp->tt_isdst != 0 && ttisp->tt_isdst != 1) - return -1; + goto bad; ttisp->tt_abbrind = (unsigned char) *p++; if (ttisp->tt_abbrind < 0 || ttisp->tt_abbrind > sp->charcnt) - return -1; + goto bad; } for (i = 0; i < sp->charcnt; ++i) sp->chars[i] = *p++; @@ -460,7 +465,7 @@ ttisp->tt_ttisstd = *p++; if (ttisp->tt_ttisstd != TRUE && ttisp->tt_ttisstd != FALSE) - return -1; + goto bad; } } for (i = 0; i < sp->typecnt; ++i) { @@ -473,7 +478,7 @@ ttisp->tt_ttisgmt = *p++; if (ttisp->tt_ttisgmt != TRUE && ttisp->tt_ttisgmt != FALSE) - return -1; + goto bad; } } /* @@ -506,11 +511,11 @@ /* ** If this is an old file, we're done. */ - if (u.tzhead.tzh_version[0] == '\0') + if (u->tzhead.tzh_version[0] == '\0') break; - nread -= p - u.buf; + nread -= p - u->buf; for (i = 0; i < nread; ++i) - u.buf[i] = p[i]; + u->buf[i] = p[i]; /* ** If this is a narrow integer time_t system, we're done. */ @@ -518,13 +523,13 @@ break; } if (doextend && nread > 2 && - u.buf[0] == '\n' && u.buf[nread - 1] == '\n' && + u->buf[0] == '\n' && u->buf[nread - 1] == '\n' && sp->typecnt + 2 <= TZ_MAX_TYPES) { struct state ts; register int result; - u.buf[nread - 1] = '\0'; - result = tzparse(&u.buf[1], &ts, FALSE); + u->buf[nread - 1] = '\0'; + result = tzparse(&u->buf[1], &ts, FALSE); if (result == 0 && ts.typecnt == 2 && sp->charcnt + ts.charcnt <= TZ_MAX_CHARS) { for (i = 0; i < 2; ++i) @@ -568,7 +573,11 @@ break; } } + free(u); return 0; +bad: + free(u); + return -1; } static int

1 0

2010m
by Olson, Arthur David (NIH/NCI) [E] Nov. 21, 2010

Nov. 21, 2010

The files... ftp://elsie.nci.nih.gov/pub/tzcode2010m.tar.gz ...and... ftp://elsie.nci.nih.gov/pub/tzdata2010m.tar.gz ...are now available; these reflect the Hong Kong, Vostok, and zic.c changes circulated recently on the time zone mailing list. --ado

3 2

DST in the news :-)
by Olson, Arthur David (NIH/NCI) [E] Nov. 10, 2010

Nov. 10, 2010

"I put myself and my staff through this crazy, huge ordeal, all because I refused to go on at midnight, okay? And so I work, you know, and then I get this job at eleven, supposed to be a big deal. Then yesterday daylight savings [sic] time ended. Right now it's basically midnight." Conan O'Brien on the 2010-11-08 premier of "Conan."

1 0

FW: zone.tab change request
by Olson, Arthur David (NIH/NCI) [E] Nov. 8, 2010

Nov. 8, 2010

I'm forwarding this message from an address that's not on the time zone mailing list. Those of you who are on the list, please direct replies appropriately. --ado From: blacklight332(a)aol.com [mailto:blacklight332@aol.com] Sent: Friday, November 05, 2010 7:10 To: tz(a)lecserver.nci.nih.gov Subject: zone.tab change request tz(a)elsie.nci.nih.gov can you change the zone.tab file to say: ID -0610+10648 Asia/Jakarta Java & Sumatra ID -0002+10920 Asia/Pontianak west & central Borneo(Kalimantan) ID -0507+11924 Asia/Makassar east & south Borneo, Celebes(Sulawesi), Bali, Nusa Tengarra, west Timor ID -0232+14042 Asia/Jayapura Irian Jaya (Papua) & the Moluccas (Maluku) instead of ID -0610+10648 Asia/Jakarta Java & Sumatra ID -0002+10920 Asia/Pontianak west & central Borneo ID -0507+11924 Asia/Makassar east & south Borneo, Celebes, Bali, Nusa Tengarra, west Timor ID -0232+14042 Asia/Jayapura Irian Jaya & the Moluccas the regions have changed their names in 2007. bl

1 0

zone.tab change request
by blacklight332＠aol.com Nov. 5, 2010

Nov. 5, 2010

tz(a)elsie.nci.nih.gov can you change the zone.tab file to say: ID -0610+10648 Asia/Jakarta Java & Sumatra ID -0002+10920 Asia/Pontianak west & central Borneo(Kalimantan) ID -0507+11924 Asia/Makassar east & south Borneo, Celebes(Sulawesi), Bali, Nusa Tengarra, west Timor ID -0232+14042 Asia/Jayapura Irian Jaya (Papua) & the Moluccas (Maluku) instead of ID -0610+10648 Asia/Jakarta Java & Sumatra ID -0002+10920 Asia/Pontianak west & central Borneo ID -0507+11924 Asia/Makassar east & south Borneo, Celebes, Bali, Nusa Tengarra, west Timor ID -0232+14042 Asia/Jayapura Irian Jaya & the Moluccas the regions have changed their names in 2007. bl

1 0

Acre (Brazil) would like to return to old time zone GMT-5
by Alexander Krivenyshev Nov. 1, 2010

Nov. 1, 2010

According to the media from Brazil, during recent referendum state Acre rejected current time zone (GMT-4) and would like to return to old time zone (pre-2008) - GMT-5. The decision of Acre will be sent to the Congress to become law and to re-apply the old time. (in Portuguese): Acreanos decidem pelo horário antigo http://www.noticiasdahora.com/acre/4184-acreanos-decidem-voltar-ao-horario- antig.html Acreanos decidem voltar ao horário antigo em votação do referendo http://portalamazonia.globo.com/pscript/noticias/noticias.php?pag=old&idN=1… or http://www.worldtimezone.com/dst_news/dst_news_brazil07.html Quick reference page for current (2010) and old (pre-2008) Brazil Time Zones map http://www.worldtimezone.com/brazil-time-new-old.php Alexander Krivenyshev, http://www.worldtimezone.com

1 0

data2010o
by Olson, Arthur David (NIH/NCI) [E] Nov. 1, 2010

Nov. 1, 2010

The file... ftp://elsie.nci.nih.gov/pub/tzdata2010o.tar.gz ...is now available; this includes the change to the end of DST in Fiji in 2011 circulated last week on the time zone mailing list. --ado

1 0

proposed time zone package change (Fiji's 2001 DST end)
by Arthur David Olson Oct. 28, 2010

Oct. 28, 2010

Below is a proposed change to the time zone package's "australasia" file, moving Fiji's 2011 end of DST from March 27 to March 6. If there are no problems, the ftp site will be updated on 2010-11-01. --ado ------- australasia ------- *** /tmp/geta22811 Tue Oct 26 17:01:05 2010 --- /tmp/getb22811 Tue Oct 26 17:01:05 2010 *************** *** 1,5 **** # <pre> ! # @(#)australasia 8.19 # This file is in the public domain, so clarified as of # 2009-05-17 by Arthur David Olson. --- 1,5 ---- # <pre> ! # @(#)australasia 8.20 # This file is in the public domain, so clarified as of # 2009-05-17 by Arthur David Olson. *************** *** 284,289 **** --- 284,302 ---- # http://www.timeanddate.com/news/time/fiji-dst-ends-march-2010.html # </a> + # From Alexander Krivenyshev (2010-10-24): + # According to Radio Fiji and Fiji Times online, Fiji will end DST 3 + # weeks earlier than expected - on March 6, 2011, not March 27, 2011... + # Here is confirmation from Government of the Republic of the Fiji Islands, + # Ministry of Information (fiji.gov.fj) web site: + # <a href="http://www.fiji.gov.fj/index.php?option=com_content&view=article&id=2608:da…"> + # http://www.fiji.gov.fj/index.php?option=com_content&view=article&id=2608:da… + # </a> + # or + # <a href="http://www.worldtimezone.com/dst_news/dst_news_fiji04.html"> + # http://www.worldtimezone.com/dst_news/dst_news_fiji04.html + # </a> + # Rule NAME FROM TO TYPE IN ON AT SAVE LETTER/S Rule Fiji 1998 1999 - Nov Sun>=1 2:00 1:00 S Rule Fiji 1999 2000 - Feb lastSun 3:00 0 - *************** *** 290,296 **** Rule Fiji 2009 only - Nov 29 2:00 1:00 S Rule Fiji 2010 only - Mar lastSun 3:00 0 - Rule Fiji 2010 only - Oct 24 2:00 1:00 S ! Rule Fiji 2011 only - Mar lastSun 3:00 0 - # Zone NAME GMTOFF RULES FORMAT [UNTIL] Zone Pacific/Fiji 11:53:40 - LMT 1915 Oct 26 # Suva 12:00 Fiji FJ%sT # Fiji Time --- 303,309 ---- Rule Fiji 2009 only - Nov 29 2:00 1:00 S Rule Fiji 2010 only - Mar lastSun 3:00 0 - Rule Fiji 2010 only - Oct 24 2:00 1:00 S ! Rule Fiji 2011 only - Mar Sun>=1 3:00 0 - # Zone NAME GMTOFF RULES FORMAT [UNTIL] Zone Pacific/Fiji 11:53:40 - LMT 1915 Oct 26 # Suva 12:00 Fiji FJ%sT # Fiji Time

2 2

Extension to tzcode to support additional timezones
by John Baldwin Oct. 27, 2010

Oct. 27, 2010

Several of my employers have needed to work with data from multiple timezones within a single process. The traditional way to work with this has been to change the value of the TZ environment variable and invoke tzset() and switch between timezones one at a time. What I have done is extend the time(3) API to allow applications to load and use arbitrary timezones separate from the current local and GM timezones. I've done this by adding the following API calls: - void *tzopen(const char *name). This loads the rules for a specified timezone and returns a void * cookie. If the zone cannot be parsed it returns NULL and sets errno to EINVAL. - void tzclose(void *zone). This "closes" a set of rules opened via tzopen() by releasing the associated resources. - struct tm *tztime(void *zone, const time_t *t, struct tm *tm). This is like localtime_r() except that it uses the timezone rules from the passed in cookie instead of the local timezone indicated by TZ. - time_t timetz(void *zone, struct tm * const tm). This is like mktime() except that it uses the timezone rules from the passed in cookie instead of the local timezone indicated by TZ. The changes to the code are fairly simple since the per-zone state was already broken out into a standalone state object to handle GMT vs local time. In some cases the patches make things cleaner (I think) by removing hacks where a function pointer was queried to determine which state object to use since the state object pointer is now passed all the way down the internal time code stack. I have a patch that is relative to the FreeBSD source tree, but all of the real code changes are in localtime.c which I believe should apply directly to the tzcode distribution. The patch is available at http://www.FreeBSD.org/~jhb/patches/tzopen.patch Is this API something that you folks would be interested in? I currently have this as a private patch locally, but if possible I would like it adopted upstream. -- John Baldwin

9 22

2010n
by Olson, Arthur David (NIH/NCI) [E] Oct. 25, 2010

Oct. 25, 2010

The files... ftp://elsie.nci.nih.gov/pub/tzcode2010n.tar.gz ...and... ftp://elsie.nci.nih.gov/pub/tzdata2010n.tar.gz ...are now available; these reflect the changes circulated on 2010-10-13 on the time zone mailing list. I expect that data2010o will appear on 2010-11-01 in light of the change in the end of DST in Fiji in 2011. Folks wanting to avoid version thrash may want to hold off for a week. --ado

1 0

Fiji will end DST 3 weeks earlier than expected- on March 6, 2011
by Alexander Krivenyshev Oct. 24, 2010

Oct. 24, 2010

According to Radio Fiji and Fiji Times online, Fiji will end DST 3 weeks earlier than expected - on March 6, 2011, not March 27, 2011. Radio Fiji http://www.radiofiji.com.fj/fullstory.php?id=31740 Fiji Times online http://www.fijitimes.com/story.aspx?id=158517 or http://www.worldtimezone.com/dst_news/dst_news_fiji04.html Alex Krivenyshev, http://www.worldtimezone.com/dst_news/ New York, NY

1 1

Another China time zone question
by Jonathan Hassid Oct. 22, 2010

Oct. 22, 2010

Dear time zone list: I have been doing a little research on time zones in China, and one of the few sources on the matter seems to contradict the tz database. While the database indicates there were multiple time zones until 1980, Guo Qingheng of the Chinese Academy of Science Time Service Center published an article in 2003 in which he states that primary documents indicate that "probably in order to comply with instructions from central broadcasters, after liberation [that is, after 1949] the broadcasters in each area very quickly changed their local times to Beijing Time, in order to express unanimity with the center." And that "by the beginning of 1950, within a few months after establishing the country, the entire country except for Xinjiang and Tibet was all using the Beijing Time standard," with Tibet following in 1960 and Xinjiang by 1975 (Guo Qingsheng [郭庆生], "Beijing Time at the Beginning of the PRC [建国初期的北京时间]." The Chinese Journal for the History of Science and Technology [中国科技史料]. Vol. 24, No. 1, (2003), p2.) So I was wondering what the sources are for China having multiple time zones from 1949-1980, and who is correct here. Any help is appreciated! Best, Jonathan Hassid UTS CRICOS Provider Code: 00099F DISCLAIMER: This email message and any accompanying attachments may contain confidential information. If you are not the intended recipient, do not read, use, disseminate, distribute or copy this message or attachments. If you have received this message in error, please notify the sender immediately and delete this message. Any views expressed in this message are those of the individual sender, except where the sender expressly, and with authority, states them to be the views of the University of Technology Sydney. Before opening any attachments, please check them for viruses and defects. Think. Green. Do. Please consider the environment before printing this email.

5 6

Russia plan to abolish "summer time" in 2011
by Alexander Krivenyshev Oct. 19, 2010

Oct. 19, 2010

Another draft bill 441798-5 to abolish the "summer time" submitted to the State Duma on October 19, 2010: Instead of the seasonal clock change to "summer time", the bill proposes a change to actual working hours for organizations and institutions around the country beginning on the first Monday in April through the first Monday in November of each year. If the bill is approved, it would come into force on 1 January 2011. (in English) Transition of the Russian Federation to the International system of Time Zones: http://www.worldtimezone.com/dst_news/dst_news_russia019.html or media reports (in Russian): http://spb.rbc.ru/freenews/20101019132518.shtml http://newsru.com/russia/19oct2010/perevod.html Alexander Krivenyshev, http://www.worldtimezone.com

1 0

FW: New TZ data for Fiji
by Olson, Arthur David (NIH/NCI) [E] Oct. 19, 2010

Oct. 19, 2010

I'm forwarding this message from Franck Martin who is not on the time zone mailing list. Those of you who are on the list, please direct replies appropriately. --ado From: Franck Martin [mailto:franck@avonsys.com] Sent: Wednesday, September 29, 2010 9:00 To: tz(a)lecserver.nci.nih.gov Subject: New TZ data for Fiji http://www.fiji.gov.fj/index.php?option=com_content&view=article&id=2438:da… Franck Martin http://www.avonsys.com/ http://www.facebook.com/Avonsys twitter: FranckMartin Avonsys Check your domain reputation: http://gurl.im/b69d4o

2 3

Re: About China time zones
by CHancuff＠aol.com Oct. 17, 2010

Oct. 17, 2010

This sounds a bit like the town in Canada whose mayor must sign a proclamation each year to observe Daylight Savings Time by a certain date. If the mayor happens to be out fishing when this deadline comes and goes, DST does not get observed by the town. I can't for the life of me remember the name of that place. Cliff Hancuff In a message dated 10/17/2010 1:40:33 A.M. Eastern Daylight Time, ma.lude.xj(a)gmail.com writes: I think I understand now your reason for wanting dual time zones now, thanks. I think, though, that Jonathan Hassid has his the nail on the head as far as Xinjiang time is concerned with his access to Guo's article, that there is no single change or date from Xinjiang time to Beijing time. It seems rather that different ministries and different localities switched at different times.

1 0

Re: About China time zones
by Luther Ma Oct. 17, 2010

Oct. 17, 2010

I might also say here that adding a new population center in Xinjiang that is UTC +8:00 to the tz database (as originally suggested in "first pass at Uyghur time" 2009.11.21) is unnecessary and redundant (besides having other potential problems) because the population that uses +8:00 uses it precisely because they consider Beijing their center (which we, of course, call Shanghai/Asia). :P Just my opinion, of course. Once again, I'll accept "first pass" if it is to be the last pass. -mld

2 2

FW: environment independent time functions...
by Olson, Arthur David (NIH/NCI) [E] Oct. 14, 2010

Oct. 14, 2010

I'm forwarding this message from Christos Zoulas, who is not on the time zone mailing list. Those of you who are on the list, please direct replies appropriately. --ado -----Original Message----- From: Christos Zoulas [mailto:christos@zoulas.com] Sent: Thursday, September 30, 2010 4:36 To: tz(a)lecserver.nci.nih.gov Subject: environment independent time functions... Hello, What I want to achieve is to be able to use the time functions in a multi-threaded program that can handle multiple timezones at the same time. Right now, this is impossible, because the notion of timezone is expressed through the environment. I was careful to re-use the existing code and not change existing functionality so the following routines are just an add-on. I modified tzcode 2010l to add the following functions (as defined in timeextra.h). First I expose an opaque timezone type: typedef struct __state *timezone_t; which is no other than the internal state. Then I provide a way to allocate the handle on per timezone name and to free it. const timezone_t tzalloc(const char *); void tzfree(const timezone_t); Note that the handle is const, because I might want to enhance this in the future to use reference counting instead of allocating a new one per invocation. Then I provide a way to return the two (dst and nondst) strings (like tzname[0], and tzname[1]) with: const char * tzgetname(const timezone_t, int); The following functions are also provided, which are like the _r counterparts only they have an extra timezone argument: struct tm * localtime_z(const time_t *, struct tm *, const timezone_t); char * ctime_z(const time_t *, char *, const timezone_t); time_t timelocal_z(struct tm *, const timezone_t); time_t mktime_z(struct tm *, const timezone_t); time_t time2posix_z(time_t, const timezone_t); time_t posix2time_z(time_t, const timezone_t); The changes to the source are minimal (the diffs are slightly larger because I made things use ansi prototypes and removed 'register '. I don't care about the names or the signatures much, just something I came up as a proof of concept. Here's example code: #include "timeextra.h" #include <stdlib.h> #include <stdio.h> int main(int argc, char *argv[]) { size_t i; char buf[60]; time_t t = time(NULL); timezone_t *tz = malloc(argc * sizeof(*tz)); for (i = 1; i < argc; i++) { tz[i] = tzalloc(argv[i]); if (tz[i] == NULL) err(1, "Cannot find timezone %s", argv[i]); } for (i = 1; i < argc; i++) { printf("[%s] [%s] %s", tzgetname(tz[i], 0), tzgetname(tz[i], 1), ctime_z(&t, buf, tz[i])); tzfree(tz[i]); } return 0; } Has anyone done this work or similar? Do you think others might want something like this? Are you interested in taking a look at the changes/incorporating them? Do you have any other suggestions? Best Regards, christos

6 7

FW: Samoa
by Olson, Arthur David (NIH/NCI) [E] Oct. 13, 2010

Oct. 13, 2010

I'm forwarding this message from Raymond Hughes, who is not on the time zone mailing list. Those of you who are on the list, please direct replies appropriately. (Right now http://www.mcil.gov.ws is unavailable--at least from the system I'm using--but Googling "03/04/11 adjust clocks" and using the "Cache" link provides the content). --ado -----Original Message----- From: Raymond Hughes [mailto:raymond@hughes.ws] Sent: Thursday, October 07, 2010 9:36 To: tz(a)lecserver.nci.nih.gov Subject: Re: Samoa the start of DST here is Samoa was OK from what I've seen, but looking at my zdump I see the ending does not have the correct times. Sun Sep 26 10:59:59 2010 UTC = Sat Sep 25 23:59:59 2010 WST isdst=0 Sun Sep 26 11:00:00 2010 UTC = Sun Sep 26 01:00:00 2010 WSDT isdst=1 Sun Apr 3 09:59:59 2011 UTC = Sat Apr 2 23:59:59 2011 WSDT isdst=1 Sun Apr 3 10:00:00 2011 UTC = Sat Apr 2 23:00:00 2011 WST isdst=0 Please see www.mcil.gov.ws, the Ministry of Commerce, Industry and Labour (sideframe) "Last Sunday September 2010 (26/09/10) - adjust clocks forward from 12:00 midnight to 01:00am and First Sunday April 2011 (03/04/11) - adjust clocks backwards from 1:00am to 12:00am" PS. Thanks Maintainers Regards Ray

3 3

Re Fiji Timezone
by Franck Martin Oct. 13, 2010

Oct. 13, 2010

Seems the TZ file is not updated with the info: http://www.fiji.gov.fj/index.php?option=com_content&view=article&id=2438:da… Fiji will switch back to daylight saving time from 24th October, 2010 at 2am. This means members of the public will be required to switch their clocks one hour ahead to 3am. It is expected to end in March 2011, a date is yet to be confirmed. Franck Martin http://www.avonsys.com/ http://www.facebook.com/Avonsys twitter: FranckMartin Avonsys Check your domain reputation: http://gurl.im/b69d4o

1 0

Australia has changed the first day of daylight?
by Ahmed Hassan (ahmhassa) Oct. 13, 2010

Oct. 13, 2010

Dear, Since last year, Australia has changed the first day of daylight saving to the first Sunday of October, and ending first Sunday of April. Here is the URL for your reference for states specific changes: http://www.bom.gov.au/climate/averages/tables/dst_times.shtml, which version does capture this change? Best regards, Ahmed

1 0

A question about Amsterdam in 1900
by David Patte Oct. 10, 2010

Oct. 10, 2010

I was reviewing some historical zones & rules, and I can across a date for Amsterdam that has me a bit confused. I'm not sure if I'm misinterpreting the records, or whether a record is missing. Lets take Jan 1, 1900 for Amsterdam. The Zone table for Europe/Amsterdam shows: a GMT offset of 0:19:32 (and no rule) until 1835, then a GMT offset of 0:19:32 (and Neth rule) until July 1 1937 - using '%s' for letters So for Jan 1, 1900 I am assuming I should be looking for a rule in the Neth rules records But the first 'Neth' Rule starts 1916. I can easily easily understand that this means that there is no special save amount to apply on Jan 1st 1900, but what letters should I be using for that date given that the zone says the letters should be %s? Since the zone record says '%s' for that date, should there not be a rule record starting in 1835 that gives a save amount of 0, and provides the letters 'AMT'? Thanks

2 1

code question
by Zoidiasoft Tech Oct. 9, 2010

Oct. 9, 2010

Hi, I am a Delphi programmer and am working on a time zone problem. In the Olson database I'm having trouble differentiating between times that are strictly standard and those that include summer time / daylight savings. Is there a standard in the code for differentiating these? Most of it is fairly simple to understand but I am mystified by some of the abbreviations in the rule changes. For instance: # Rule NAME FROM TO TYPE IN ON AT SAVE LETTER/S Rule Finland 1942 only - Apr 3 0:00 1:00 S Rule Finland 1942 only - Oct 3 0:00 0 - Rule Finland 1981 1982 - Mar lastSun 2:00 1:00 S Rule Finland 1981 1982 - Sep lastSun 3:00 0 - # Zone NAME GMTOFF RULES FORMAT [UNTIL] Zone Europe/Helsinki 1:39:52 - LMT 1878 May 31 1:39:52 - HMT 1921 May # Helsinki Mean Time 2:00 Finland EE%sT 1983 2:00 EU EE%sT What is the % symbol I keep seeing in the code for? For instance, in "2:00 EU EE%sT" is "EE%sT" Eastern European Standard Time? I take this to mean that Finland is currently on EU rules with a UTC offset of +2. Every now and then I also find something like this: "2:00 1:00 EEST 1989 Sep 24 2:00s" Does this line mean that I add 1 hour to the 2:00 hours UTC? Or is this correction already included in the 2 hours? Thanks! Sincerely, Curtis Manwaring

1 0

Samoa
by Olson, Arthur David (NIH/NCI) [E] Oct. 8, 2010

Oct. 8, 2010

Can anyone with boots on the ground tell us what actually happened with clock changes over the weekend in Samoa? Thanks. --ado

3 3

Valgrind error "Conditional jump or move depends on uninitialised value" on 64-bit
by Ravindra Oct. 5, 2010

Oct. 5, 2010

[Sending this directly to you because POSTing it on website does not seem to be working for me. This is about reproducing valgrind issue and a compilation warning.] Arthur and Paul, I'm seeing two problems in localtime.c: 1. When I compile localtime.c using gcc 4.1.2 for 32-bit, I get following warning: $ gcc -m32 -g -c -o localtime.o localtime.c localtime.c: In function âdiffer_by_repeatâ: localtime.c:326: warning: comparison is always false due to limited range of data type 2. valgrind reports following error for some timezones (only when localtime.c is compiled as 64-bit binary, it does not happen when compiled as 32-bit binary): ==26671== Conditional jump or move depends on uninitialised value(s) ==26671== at 0x401CDA: typesequiv (localtime.c:588) ==26671== by 0x401B85: tzload (localtime.c:562) ==26671== by 0x405553: tz_validate (localtime.c:2017) ==26671== by 0x40560D: main (localtime.c:2040) One can reproduce it using following valgrind command and patch: valgrind -v --tool=memcheck --leak-check=full --leak-resolution=med --show-reachable=yes --error-limit=no --workaround-gcc296-bugs=yes --run-libc-freeres=no --log-file=valgrind-tzvalid ./tzvalid /<path/to/my/zoneinfo/EST5EDT> NOTE: I can consistently reproduce it for EST5EDT timezone and I don't get this error for GMT. Patch for localtime.c for reproducing above error: --- org/localtime.c 2010-08-16 16:27:05.000000000 +0530 +++ localtime.c 2010-10-01 17:34:45.999089000 +0530 @@ -2004,6 +2004,47 @@ #endif /* defined CMUCS */ +static int +tz_validate(const char * name) +{ + struct state state = {0}; + time_t now; + struct tm tm; + + time(&now); + tzload(gmt, &state, TRUE); + if (0 == tzload(name, &state, TRUE)) { + localsub(&now, 0L, &tm); + return TRUE; + } + if (0 == tzparse(name, &state, FALSE)) { + localsub(&now, 0L, &tm); + return TRUE; + } + return FALSE; +} + +/* + * Compile it simply as "$gcc -m64 -g -o tzvalid localtime.c" + */ +int main(int argc, char ** argv) { + + if (argc != 2) { + printf("Usage: ./tzvalid <timezone_file_path>\n"); + return 2; + } + + char * tz = argv[1]; + + if (tz_validate(tz)) { + printf("timezone %s is valid\n", tz); + return 0; + } else { + printf("timezone %s is not valid\n", tz); + return 1; + } +} + /* ** XXX--is the below the right way to conditionalize?? */ Thanks in advance, Ravindra

1 0