- tz - lists.iana.org

[PROPOSED] Generate nicer 'make check' output
by Paul Eggert Nov. 6, 2022

Nov. 6, 2022

* Makefile (DIFF_TZS): New macro. (check_tzs, $(TIME_T_ALTERNATIVES)): Use it. --- Makefile | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 8c4c6aba..9ee15607 100644 --- a/Makefile +++ b/Makefile @@ -499,6 +499,11 @@ TARFLAGS= `if tar $(GNUTARFLAGS) --version >/dev/null 2>&1; \ # Flags to give 'gzip' when making a distribution. GZIPFLAGS= -9n +# When comparing .tzs files, use GNU diff's -F'^TZ=' option if supported. +# This makes it easier to see which Zone has been affected. +DIFF_TZS= diff -u$$(! diff -u -F'^TZ=' - - <>/dev/null >&0 2>&1 \ + || echo ' -F^TZ=') + ############################################################################### #MAKE= make @@ -857,7 +862,7 @@ check_tables: checktab.awk $(YDATA) backward $(ZONETABLES) check_tzs: $(TZS) $(TZS_NEW) if test -s $(TZS); then \ - diff -u $(TZS) $(TZS_NEW); \ + $(DIFF_TZS) $(TZS) $(TZS_NEW); \ else \ cp $(TZS_NEW) $(TZS); \ fi @@ -1058,7 +1063,7 @@ $(TIME_T_ALTERNATIVES): $(VERSION_DEPS) TZS_YEAR="$$range" TZS_CUTOFF_FLAG="-t $$range" \ D=$$wd/$@.dir \ to$$range.tzs) && \ - diff -u $(TIME_T_ALTERNATIVES_HEAD).dir/to$$range.tzs \ + $(DIFF_TZS) $(TIME_T_ALTERNATIVES_HEAD).dir/to$$range.tzs \ $@.dir/to$$range.tzs && \ if diff -q Makefile Makefile 2>/dev/null; then \ quiet_option='-q'; \ -- 2.37.2

1 0

[PROPOSED] Fix unlikely conversion bug in zic
by Paul Eggert Nov. 5, 2022

Nov. 5, 2022

* zic.c (puttzcode): Arg is zic_t, not int_fast32_t. This fixes a portability bug on platforms where int_fast32_t is a 32-bit ones’ complement or signed-magnitude integer, and where the argument is -2**31 before conversion to int_fast32_t. Although I don’t know of any such platforms, the C standard allows them. --- zic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zic.c b/zic.c index d8bdbb96..548c1c5f 100644 --- a/zic.c +++ b/zic.c @@ -2216,7 +2216,7 @@ convert64(uint_fast64_t val, char *buf) } static void -puttzcode(const int_fast32_t val, FILE *const fp) +puttzcode(zic_t val, FILE *fp) { char buf[4]; -- 2.37.2

2 1

Mexico on track to abolish DST
by Paul Eggert Nov. 3, 2022

Nov. 3, 2022

Yesterday Mexico's Chamber of Deputies voted 445–33 to abolish DST in most of Mexico, and although there are more hurdles I expect this to become law. When that happens, I hope the following simple patch will suffice; it merely changes "max" to "2022" in the last two Mexico Rule lines. We'll also need to add commentary citing the law, etc., but you can try this patch now if you like, to debug any applications involving future time in Mexico. Today timeanddate updated their English-language summary of this <https://www.timeanddate.com/news/time/mexico-remove-dst-2022.html>. I haven't installed the following. diff --git a/northamerica b/northamerica index da84f354..2466d627 100644 --- a/northamerica +++ b/northamerica @@ -2634,2 +2634,2 @@ Rule Mexico 2001 only - Sep lastSun 2:00 0 S -Rule Mexico 2002 max - Apr Sun>=1 2:00 1:00 D -Rule Mexico 2002 max - Oct lastSun 2:00 0 S +Rule Mexico 2002 2022 - Apr Sun>=1 2:00 1:00 D +Rule Mexico 2002 2022 - Oct lastSun 2:00 0 S

4 16

Re: [tz] iana build failures on Windows
by Paul Eggert Nov. 2, 2022

Nov. 2, 2022

On 4/19/21 7:09 AM, Manuela Friedrich wrote: > I had to include signal.h in zic.c to prevent the following error: > > zic.c(610): error C2061: syntax error: identifier 'got_signal' This is a portability bug recently introduced to zic.c. I installed the first attached patch to fix it. > The I needed to resolved error > > zic.obj : error LNK2019: unresolved external symbol tz_time referenced in function random_dirent This appears to be another recent portability bug. It's related to a portability problem you reported on MS-Windows in response to which in 2018d I committed a patch that introduced RESERVE_STD_EXT_IDS: https://github.com/eggert/tz/commit/24b45243c5210b4196987fdd06e6c288c358a268 When I recently added the randomish filename code to the development version, I neglected to deal with RESERVE_STD_EXT_IDS. The second attached patch should fix this issue. Please give the two patches a try, as I don't use MS-Windows and can't easily test these patches on that platform. > a test run of zdump -v produced way more output than in the last release, the Linux output seems to have become longer too, but maybe this is still under development. That change is intentional, and was caused by this: https://github.com/eggert/tz/commit/ac07b446a3afaa4cb1ae11a91785a201c91f6351 along with some neighboring commits. Thanks for reporting the problems, and I hope the current development version of tzdb addresses the issues you mentioned.

5 23

Errors compiling 2022f on macOS
by Gilmore Davidson Nov. 1, 2022

Nov. 1, 2022

Hi, I’m getting errors when running make on the 2022f release, on my macOS Monterrey (12.6.1) machine. There are two separate errors. When I run `make` with no arguments, I get the following: cc -DTZDIR='"/usr/share/zoneinfo"' -c -o zic.o zic.c zic.c:1194:11: error: implicit declaration of function 'getrandom' is invalid in C99 [-Werror,-Wimplicit-function-declaration] s = getrandom(entropy_buffer, sizeof entropy_buffer, 0); ^ 1 error generated. After some digging, I tried running `make CFLAGS="-DHAVE_GETRANDOM=0”`, which then presents a different error: cc -DTZDIR='"/usr/share/zoneinfo"' -o zic -DHAVE_GETRANDOM=0 zic.o Undefined symbols for architecture x86_64: "_libintl_gettext", referenced from: _main in zic.o _close_file in zic.o _usage in zic.o _warning in zic.o _infile in zic.o _adjleap in zic.o _associate in zic.o ... "_libintl_setlocale", referenced from: _main in zic.o "_libintl_textdomain", referenced from: _main in zic.o ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) I’m not a C programmer so I’m out of my depth with trying to diagnose workarounds. Possibly there’s just another CFLAGS argument I need to provide, or I’ve got something else weird in my environment? Some extra bits of context: These errors also happen on latest `main` branch (commit 9f1f40cd). I can compile 2022e without issue. The getrandom error appears in commit 0733c65c ("Improve randomness of zic temp file names”). The linking error appears in commit e5b2ee63 ("Use C23 __has_include if available”). masOS 12.6.1 / Make 3.81 / clang 14.0.0 Also, the Makefile comment for the HAVE_GETRANDOM flag says "-DHAVE_GETRANDOM if getgrandom works (e.g., GNU/Linux)*” — is “getgrandom” a typo? Cheers, Gil

4 13

zic.c - compilation broken on gcc 4.8.3 after commit e5b2ee634c7151484c06740ea2c8a4d4a75409b6
by Иванов Игорь Oct. 31, 2022

Oct. 31, 2022

Good time of day. This commit breaks compilation at least on GCC 4.8.3: commit e5b2ee634c7151484c06740ea2c8a4d4a75409b6 Author: Paul Eggert <eggert(a)cs.ucla.edu> Date: Thu Oct 20 11:41:27 2022 -0700 Use C23 __has_include if available It causes this compilation error: zic.c: In function ‘main’: zic.c:813:16: error: ‘optarg’ undeclared (first use in this function) if (strcmp(optarg, "slim") == 0) { ^ zic.c:906:6: error: ‘optind’ undeclared (first use in this function) if (optind == argc - 1 && strcmp(argv[optind], "=") == 0) ^ Specifically hunks like this are problematic: @@ -55,8 +63,8 @@ #endif #ifndef HAVE_GETTEXT -# define HAVE_GETTEXT 0 -#endif /* !defined HAVE_GETTEXT */ +# define HAVE_GETTEXT HAS_INCLUDE(<libintl.h>, false) +#endif #ifndef HAVE_INCOMPATIBLE_CTIME_R # define HAVE_INCOMPATIBLE_CTIME_R 0 The culprit is the replacement 0 -> false and 1 -> true. Apparently it breaks #if preprocessor logic in older compilers somewhere downstream - what was #if 1 becomes #if true, which GCC treats as "false" and falls into #else branch. "Restoring" false and true back to 0 and 1 seems to fix the issue. Best regards, Igor Ivanov, Software engineer at DSSL

2 3

Syria Time has changed
by Rami M Oct. 31, 2022

Oct. 31, 2022

2 1

Grouped country lists are confusing
by Stephen Colebourne Oct. 31, 2022

Oct. 31, 2022

Recent changes merged the comments acting as country headers. Thus, a typical merged header is now: # Denmark # Germany # Norway # Sweden It is very confusing to suggest that all four countries are evenly represented here, as the commentary is typically all about the primary country (Germany in this case). The alphabetical list is decidedly unhelpful too, as nothing indicates which country the Zone's city relates to. Can I propose these comments be altered to something like: # Germany # also applicable since 1970 to Denmark # also applicable since 1970 to Norway # also applicable since 1970 to Sweden thanks Stephen

4 6

[tz-announce] 2022f release of tz code and data available
by Paul Eggert via tz-announce Oct. 30, 2022

Oct. 30, 2022

The 2022f release of the tz code and data is available. This release contains the following changes. The most urgent one is the change for Chihuahua, Mexico which affects timestamps starting Sunday. Briefly: Mexico will no longer observe DST except near the US border. Chihuahua moves to year-round -06 on 2022-10-30. Fiji no longer observes DST. Move links to 'backward'. In vanguard form, GMT is now a Zone and Etc/GMT a link. zic now supports links to links, and vanguard form uses this. Simplify four Ontario zones. Fix a Y2438 bug when reading TZif data. Enable 64-bit time_t on 32-bit glibc platforms. Omit large-file support when no longer needed. In C code, use some C23 features if available. Remove no-longer-needed workaround for Qt bug 53071. Changes to future timestamps Mexico will no longer observe DST after 2022, except for areas near the US border that continue to observe US DST rules. On 2022-10-30 at 02:00 the Mexican state of Chihuahua moves from -07 (-06 with DST) to year-round -06, thus not changing its clocks that day. The new law states that Chihuahua near the US border no longer observes US DST. (Thanks to gera for the heads-up about Chihuahua.) Fiji will not observe DST in 2022/3. (Thanks to Shalvin Narayan.) For now, assume DST is suspended indefinitely. Changes to data Move links to 'backward' to ease and simplify link maintenance. This affects generated data only if you use 'make BACKWARD='. GMT is now a Zone and Etc/GMT a link instead of vice versa, as GMT is needed for leap second support whereas Etc/GMT is not. However, this change exposes a bug in TZUpdater 2.3.2 so it is present only in vanguard form for now. Vanguard form now uses links to links, as zic now supports this. Changes to past timestamps Simplify four Ontario zones, as most of the post-1970 differences seem to have been imaginary. (Problem reported by Chris Walton.) Move America/Nipigon, America/Rainy_River, and America/Thunder_Bay to 'backzone'; backward-compatibility links still work, albeit with some different timestamps before November 2005. Changes to code zic now supports links to links regardless of input line order. For example, if Australia/Sydney is a Zone, the lines Link Australia/Canberra Australia/ACT Link Australia/Sydney Australia/Canberra now work correctly, even though the shell commands ln Australia/Canberra Australia/ACT ln Australia/Sydney Australia/Canberra would fail because the first command attempts to use a link Australia/Canberra that does not exist until after the second command is executed. Previously, zic had unspecified behavior if a Link line's target was another link, and zic often misbehaved if a Link line's target was a later Link line. Fix line number in zic's diagnostic for a link to a link. Fix a bug that caused localtime to mishandle timestamps starting in the year 2438 when reading data generated by 'zic -b fat' when distant-future DST transitions occur at times given in standard time or in UT, not the usual case of local time. This occurs when the corresponding .zi Rule lines specify DST transitions with TO columns of 'max' and AT columns that end in 's' or 'u'. The number 2438 comes from the 32-bit limit in the year 2038, plus the 400-year Gregorian cycle. (Problem reported by Bradley White.) On glibc 2.34 and later, which optionally supports 64-bit time_t on platforms like x86 where time_t was traditionally 32 bits, default time_t to 64 instead of 32 bits. This lets functions like localtime support timestamps after the year 2038, and fixes year-2038 problems in zic when accessing files dated after 2038. To continue to limit time_t to 32 bits on these platforms, use "make CFLAGS='-D_TIME_BITS=32'". In C code, do not enable large-file support on platforms like AIX and macOS that no longer need it now that tzcode does not use off_t or related functions like 'stat'. Large-file support is still enabled by default on GNU/Linux, as it is needed for 64-bit time_t support. In C code, prefer C23 keywords to pre-C23 macros for alignof, bool, false, and true. Also, use the following C23 features if available: __has_include, unreachable. zic no longer works around Qt bug 53071, as the relevant Qt releases have been out of support since 2019. This change affects only fat TZif files, as thin files never had the workaround. zdump no longer modifies the environ vector when compiled on platforms lacking tm_zone or when compiled with -DUSE_LTZ=0. This avoid undefined behavior on POSIX platforms. Here are links to the release files: https://www.iana.org/time-zones/repository/releases/tzcode2022f.tar.gz https://www.iana.org/time-zones/repository/releases/tzdata2022f.tar.gz https://www.iana.org/time-zones/repository/releases/tzdb-2022f.tar.lz The following convenience links are also available, although they may point to the previous release until the relevant caches are refreshed: https://www.iana.org/time-zones/repository/tzcode-latest.tar.gz https://www.iana.org/time-zones/repository/tzdata-latest.tar.gz https://www.iana.org/time-zones/repository/tzdb-latest.tar.lz Links are also available via plain HTTP, and via FTP from ftp://ftp.iana.org/tz/releases with the same basenames as above. Each release file has a GPG signature, which can be retrieved by appending ".asc" to the above URLs. Copies of these signatures are appended to this message. This release corresponds to commit d3dc2a9d65ce433555c994ce2cf84901b87d9357 dated 2022-10-28 18:04:57 -0700 and tagged '2022f' in the development GitHub repository at <https://github.com/eggert/tz>. Here are the SHA-512 checksums for the release files: 3e2ef91b972f1872e3e8da9eae9d1c4638bfdb32600f164484edd7147be45a116db80443cd5ae61b5c34f8b841e4362f4beefd957633f6cc9b7def543ed6752b tzcode2022f.tar.gz 72d05d05be999075cdf57b896c0f4238b1b862d4d0ed92cc611736592a4ada14d47bd7f0fc8be39e7938a7f5940a903c8af41e87859482bcfab787d889d429f6 tzdata2022f.tar.gz 1dd9f8fc3e9fa113a72010b9bceb04c7540b1175801fbd15b591a6bca9400503c6683a4c89f83e08d77f5b78624a005113a8fc428c552a2a4a2b8d26de110141 tzdb-2022f.tar.lz Here are the GPG digital signatures for the release files: -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEfjeSqdis99YzvBWI7ZfpDmKqfjQFAmNcfQQACgkQ7ZfpDmKq fjS19A//fGB4YH/GygGQkql4tlshrg7ykQIQCc3qDgBrj09JVeUfM/tAN5unx+lU jBK/V5BK4K9bkrNCmxmhEdoCfdyKqusPLJSrI+ZwqqPXzNOt46dkzUxbRNYH2pvy SZklxSpgJPa4h83I8C3afGOVJn6DYpnv8SKOV6jdOOk8C6aXMaDA6t16BxN1i1Ja UKN9EQtC7xjtvtq7LtLcwo9GMy4pWoyb+CbDayG2wBq4ym3VFLxRbKupVFIDa0I7 +1pzM3Ldg2dwDKvLH8GRzirsisXbfESNVI3v1DmGnm0xDrK5pOT3iPe95OyqvMvL NdjQCpbYpoaUuo8nCf5clU4nzGEDb1sEkI6Mb8tGl2ZgG5gdC5a4P2i20vNmyIt/ uSquD7xmcBZ0CggijpFx0ndZ+0y7XSJNf7mCPaxc7vHCj5jAgQv8HLE6UXChCLeq OazZOW7xEYTDyWQ9xt2HIY1RMVBeaEE5n9V3xyfBQpb/jYeIFm83nEP5X+KjlG0Z 0YGYrVieiwS1lzNTh+LXcXusMwe6B6wYt1G4pVUgasoFADUemfd9y0yzvpdkz6/2 +WvIAF4KbGwdVHteKFR+wq9UyaSFhTUL1f9f+DsYnSbApO4F7KFzDZ3tA9IVLxfy WuOZkqjAtldzkQhoTiygF2cyGwgzWeT1WwNF6oowYYvisDf1o2E= =JtyS -----END PGP SIGNATURE----- -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEfjeSqdis99YzvBWI7ZfpDmKqfjQFAmNcfQUACgkQ7ZfpDmKq fjRcIBAAhzux6C0XSQtma/RyLPGu18XmXNrFOATZ+pGxZVYEMQCbIwzS5K9yN1eD NqmcyRwI+57Kn4WHIaPcAXepcWq20yv9W30CNAZLmI6bgDlY2x2Hy+N+/TZfGWbQ FKa0gDKh/KMV5efOsgRQDm4RnM81yoJT7CV6abnaAnvUGtOzBlnsnCD5CbEUPA2s RsM/DnHISjofgfRuEyJk1oce/lji4VOaKnoR1u5omUHhOsowAZZs9AVS3dJcYdSc 58QPrwFoZjDtW5SpXV8lufgJBFEaWpDBzgvqwKyZz4SuRmezZLWedhu06iCLNedB ORkL9N5UJj2IXUD46uJGSaFgRyqtAElEzqWjgPsa2HjrTFoDlUfu2+I7HTzE+9ZN JldGwJz3P0ZGYUXldiCsV0dIgVsukcXE+8y2t3XSreTrgY+BQkipCaFz/y9vgMN+ ueudjvcTyTx9K6SCWeZ9UHLGhIPMsTgifmrTi/4Z2O8HHPROtYAF1aAMqKO0qMZ+ YEJnwsyHWDxty+3eB6NXRuvZjAIK3nTf1KUOy5zh4h0oG1/NG19eCNtzLLC3Zpt8 KLXrDPqWU2KRs3ts6l1kYTgiebb0w5iUBksMgTxwcslqYFHQfX++lov0PZOv1Mtl D46ODcN9NAHxsu+MmX9PtAotMVCyyJhhv6sFHnbqzEiA+faHVXw= =E16s -----END PGP SIGNATURE----- -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEfjeSqdis99YzvBWI7ZfpDmKqfjQFAmNcfQYACgkQ7ZfpDmKq fjT9mA/8CUb7Mz5G+ih1x9HkhqMFE4W8m9C0yQfDL4s3c50HcLIUfjyue0UUejW5 t6Ahs+nkFWXd9l2d0Twp/tRuSMJSuiNkcxcL12zAFD2PmP1gjmvObup56jNlOSut RzuCjhDCcNablZUCFnPJ7RtZ3CDfB4wQlp86QsELFhRyhOEIpp+dtPbJ6rRQctMt 8E3Bdk5CvmMrtosTWMRJRDP6e3ox1Dx1idUSFwTedHaxwpFw7edVyuS6rV5i7i3G hX+9osS1fxV7uLJ7dEd78Hlg55ygn2l5iaxyl7bEWnBpRjGjeuYzir34Y7ddWoKh 2feE4z1aG8zIzXJMCnojqiyFO4Thsm1naWKwBLzIx0L3y09NOtRAL/9HYbO4f0Zi /owClbYLQSjzqaVLxFfSscFt9iIwonmQsynG3/aJuNAHQVEXhAWg5dlaEqG0pCLo mKsvg8aeu5sC68bokEZbsGzcPnmQYFTnhU9ZXYvEIrCbBUuszv7FdlSsB6Jwwhqn dadNZF5mToxUSp6YfmwTY/STvf6WJOxMuU2bxF4Bi79xptY8mO2tEre/wamwId95 Vk0aNyFD8z9PJu8Sfk5cPijJXLcGI6MEXoZlJ9Ou9l/Ybio9Ns4YH7tjHf8O10Uu 9QM3XMKKyAG2G49mYbU1lJDmcM1VGtGmS/CibmL/d1eZdNFTBqw= =Eezp -----END PGP SIGNATURE-----

5 6

checklinks.awk validation too strict
by Stephen Colebourne Oct. 30, 2022

Oct. 30, 2022

Hi, The latest version of checklinks.awk includes the following check: if (backcheck && FILENAME != backcheck && $3 != "GMT") { printf "%s: Link should be in '%s'\n", $3, backcheck status = 1 } The effect of the check is to insist that all Links are in the backward file. I understand this makes sense for TZDB's default dataset, as it now contains no Links in the main set of data files. In my opinion however it is perfectly valid to have a Link in the main set of files. This has been long-standing practice for TZDB. We know that some downstream consumers edit the source files before compiling them, so it seems highly likely that someone will still be wanting to have a Link in one of the main files. (And no, I don't think a command line option to turn it off is the right solution. If the check needs retaining there should be a "strict" mode only used by the default TZDB dataset) In summary, I think that this check should be removed since it is complaining about perfectly valid input files. thanks Stephen

2 1