- tz - lists.iana.org

core dump from within asctime_r()
by Robert Elz Feb. 18, 2010

Feb. 18, 2010

A NetBSD user reported fsck dumping core (when attempting to correct a corrupted filesystem). That's not nice. Upon investigation, the core dump turns out to be from within asctime_r() (as called via asctime() from ctime()). The code in fsck just does p = ctime(&t); where "t" contains one of the time fields from an (already determined to be corrupted, or we wouldn't be printing) inode. ctime() is (or course) just asctime(locatime(t)) locatime() can return NULL these days, and given a nonsense time value (which is quite likely under these circumstances), probably did, but asctime() doesn't expect anything but a valus "struct tm *" and will simply dereference NULL is NULL is returned from localtime() - instant core. It would be possible to make ctime() be tm = localtime(t); if (tm == NULL) return NULL; return asctime(tm); and in theory that would be adequate, but I'm actually going to suggest moving the fix into asctime() (into asctime_r() really of course), and have asctime_r() start if (timeptr == NULL) return NULL; I think that's a safer fix. Appended is the patch I suggest, made against the tzcode2009t sources (latest I believe.) kre

8 14

FW: Paraguay modifies its DST schedule
by Olson, Arthur David (NIH/NCI) [E] Feb. 18, 2010

Feb. 18, 2010

I'm forwarding this message from Carlos Raúl Perasso, who is not on the time zone mailing list. Those of you who are on the list, please direct replies appropriately. --ado From: Carlos Raúl Perasso [mailto:crperasso@gmail.com] Sent: Thursday, February 18, 2010 7:59 To: tz(a)lecserver.nci.nih.gov Subject: Paraguay modifies its DST schedule By decree number 3958 issued yesterday (http://www.presidencia.gov.py/v1/wp-content/uploads/2010/02/decreto3958.pdf) Paraguay changes its DST schedule, postponing the March rule to April and modifying the October date. The decree reads: ... Art. 1. It is hereby established that from the second Sunday of the month of April of this year (2010), the official time is to be set back 60 minutes, and that on the first Sunday of the month of October, it is to be set forward 60 minutes, in all the territory of the Paraguayan Republic. ... I send the modified Paraguay file with the following rules modified (1-2) and added (3-4): Rule Paraguay 2004 2009 - Oct Sun>=15 0:00 1 D Rule Paraguay 2005 2009 - Mar Sun>=8 0:00 0 S Rule Paraguay 2010 max - Apr Sun>=8 0:00 0 S Rule Paraguay 2010 max - Oct Sun<=7 0:00 1 D Un abrazo desde Paraguay, Carlos Raúl Perasso

1 0

Paraguay modifies its DST schedule
by Carlos Raúl Perasso Feb. 18, 2010

Feb. 18, 2010

By decree number 3958 issued yesterday ( http://www.presidencia.gov.py/v1/wp-content/uploads/2010/02/decreto3958.pdf) Paraguay changes its DST schedule, postponing the March rule to April and modifying the October date. The decree reads: ... Art. 1. It is hereby established that from the second Sunday of the month of April of this year (2010), the official time is to be set back 60 minutes, and that on the first Sunday of the month of October, it is to be set forward 60 minutes, in all the territory of the Paraguayan Republic. ... I send the modified Paraguay file with the following rules modified (1-2) and added (3-4): Rule Paraguay 2004 2009 - Oct Sun>=15 0:00 1 D Rule Paraguay 2005 2009 - Mar Sun>=8 0:00 0 S Rule Paraguay 2010 max - Apr Sun>=8 0:00 0 S Rule Paraguay 2010 max - Oct Sun<=7 0:00 1 D Un abrazo desde Paraguay, Carlos Raúl Perasso

1 0

proposed time zone package changes--core dump avoidance
by Arthur David Olson Feb. 14, 2010

Feb. 14, 2010

Below find proposed changes to the time zone package: * asctime.c Set errno to EINVAL and return "??? ??? ?? ??:??:?? ????\n" if asctime_r is called with a NULL struct tm pointer. (Note that asctime_r is called by ctime_r and asctime; asctime is called by ctime.) * localtime.c Set errno to EINVAL and return WRONG if time1 is called with a NULL struct tm pointer; avoid dereference if a NULL struct tm pointer is passed to timelocal, timegm, or timeoff. (Note that time1 is called by mktime, timegm, and timeoff; mktime is called by timelocal.) Barring problems, expect these changes to show up in the ftp package on 2010-02-16 (a day later than usual given a U. S. federal holiday). --ado ------- asctime.c ------- *** /tmp/geta26934 Sat Feb 6 13:23:25 2010 --- /tmp/getb26934 Sat Feb 6 13:23:25 2010 *************** *** 11,17 **** #ifndef lint #ifndef NOID ! static char elsieid[] = "@(#)asctime.c 8.2"; #endif /* !defined NOID */ #endif /* !defined lint */ --- 11,17 ---- #ifndef lint #ifndef NOID ! static char elsieid[] = "@(#)asctime.c 8.3"; #endif /* !defined NOID */ #endif /* !defined lint */ *************** *** 91,96 **** --- 91,100 ---- char year[INT_STRLEN_MAXIMUM(int) + 2]; char result[MAX_ASCTIME_BUF_SIZE]; + if (timeptr == NULL) { + errno = EINVAL; + return "??? ??? ?? ??:??:?? ????\n"; + } if (timeptr->tm_wday < 0 || timeptr->tm_wday >= DAYSPERWEEK) wn = "???"; else wn = wday_name[timeptr->tm_wday]; ------- localtime.c ------- *** /tmp/geta26952 Sat Feb 6 13:23:25 2010 --- /tmp/getb26952 Sat Feb 6 13:23:25 2010 *************** *** 5,11 **** #ifndef lint #ifndef NOID ! static char elsieid[] = "@(#)localtime.c 8.9"; #endif /* !defined NOID */ #endif /* !defined lint */ --- 5,11 ---- #ifndef lint #ifndef NOID ! static char elsieid[] = "@(#)localtime.c 8.10"; #endif /* !defined NOID */ #endif /* !defined lint */ *************** *** 1889,1894 **** --- 1889,1898 ---- int types[TZ_MAX_TYPES]; int okay; + if (tmp == NULL) { + errno = EINVAL; + return WRONG; + } if (tmp->tm_isdst > 1) tmp->tm_isdst = 1; t = time2(tmp, funcp, offset, &okay); *************** *** 1960,1966 **** timelocal(tmp) struct tm * const tmp; { ! tmp->tm_isdst = -1; /* in case it wasn't initialized */ return mktime(tmp); } --- 1964,1971 ---- timelocal(tmp) struct tm * const tmp; { ! if (tmp != NULL) ! tmp->tm_isdst = -1; /* in case it wasn't initialized */ return mktime(tmp); } *************** *** 1968,1974 **** timegm(tmp) struct tm * const tmp; { ! tmp->tm_isdst = 0; return time1(tmp, gmtsub, 0L); } --- 1973,1980 ---- timegm(tmp) struct tm * const tmp; { ! if (tmp != NULL) ! tmp->tm_isdst = 0; return time1(tmp, gmtsub, 0L); } *************** *** 1977,1983 **** struct tm * const tmp; const long offset; { ! tmp->tm_isdst = 0; return time1(tmp, gmtsub, offset); } --- 1983,1990 ---- struct tm * const tmp; const long offset; { ! if (tmp != NULL) ! tmp->tm_isdst = 0; return time1(tmp, gmtsub, offset); }

3 2

30 Rock
by Arthur David Olson Feb. 11, 2010

Feb. 11, 2010

In the "30 Rock" episode "Anna Howard Shaw Day" (first broadcast 2010-02-11), Jack Donaghy's date realizes that a Geneva-to-New-York business phone call received in the evening must be fake given the difference in local times. (Expect the above in the next version of tz-art.htm.) --ado

1 0

Re: proposed time zone package changes (revised)
by Arthur David Olson Feb. 7, 2010

Feb. 7, 2010

Here are the proposed changes, revised to incorporate KRE's suggestion on how to handle NULLs passed to asctime_r. --ado ------- asctime.c ------- *** /tmp/geta27327 Sat Feb 6 14:46:35 2010 --- /tmp/getb27327 Sat Feb 6 14:46:35 2010 *************** *** 11,17 **** #ifndef lint #ifndef NOID ! static char elsieid[] = "@(#)asctime.c 8.2"; #endif /* !defined NOID */ #endif /* !defined lint */ --- 11,17 ---- #ifndef lint #ifndef NOID ! static char elsieid[] = "@(#)asctime.c 8.4"; #endif /* !defined NOID */ #endif /* !defined lint */ *************** *** 91,96 **** --- 91,101 ---- char year[INT_STRLEN_MAXIMUM(int) + 2]; char result[MAX_ASCTIME_BUF_SIZE]; + if (timeptr == NULL) { + errno = EINVAL; + (void) strcpy(buf, "??? ??? ?? ??:??:?? ????\n"); + return buf; + } if (timeptr->tm_wday < 0 || timeptr->tm_wday >= DAYSPERWEEK) wn = "???"; else wn = wday_name[timeptr->tm_wday]; ------- localtime.c ------- *** /tmp/geta27345 Sat Feb 6 14:46:35 2010 --- /tmp/getb27345 Sat Feb 6 14:46:35 2010 *************** *** 5,11 **** #ifndef lint #ifndef NOID ! static char elsieid[] = "@(#)localtime.c 8.9"; #endif /* !defined NOID */ #endif /* !defined lint */ --- 5,11 ---- #ifndef lint #ifndef NOID ! static char elsieid[] = "@(#)localtime.c 8.10"; #endif /* !defined NOID */ #endif /* !defined lint */ *************** *** 1889,1894 **** --- 1889,1898 ---- int types[TZ_MAX_TYPES]; int okay; + if (tmp == NULL) { + errno = EINVAL; + return WRONG; + } if (tmp->tm_isdst > 1) tmp->tm_isdst = 1; t = time2(tmp, funcp, offset, &okay); *************** *** 1960,1966 **** timelocal(tmp) struct tm * const tmp; { ! tmp->tm_isdst = -1; /* in case it wasn't initialized */ return mktime(tmp); } --- 1964,1971 ---- timelocal(tmp) struct tm * const tmp; { ! if (tmp != NULL) ! tmp->tm_isdst = -1; /* in case it wasn't initialized */ return mktime(tmp); } *************** *** 1968,1974 **** timegm(tmp) struct tm * const tmp; { ! tmp->tm_isdst = 0; return time1(tmp, gmtsub, 0L); } --- 1973,1980 ---- timegm(tmp) struct tm * const tmp; { ! if (tmp != NULL) ! tmp->tm_isdst = 0; return time1(tmp, gmtsub, 0L); } *************** *** 1977,1983 **** struct tm * const tmp; const long offset; { ! tmp->tm_isdst = 0; return time1(tmp, gmtsub, offset); } --- 1983,1990 ---- struct tm * const tmp; const long offset; { ! if (tmp != NULL) ! tmp->tm_isdst = 0; return time1(tmp, gmtsub, offset); }

3 3

Re: proposed time zone package changes (revised)
by Arthur David Olson Feb. 6, 2010

Feb. 6, 2010

> You could avoid the casing: > return strcpy(buf, "??? ??? ?? ??:??:?? ????\n"); The cast can also be avoided in another part of the asctime.c code; the latest is below. --ado ------- asctime.c ------- *** /tmp/geta27586 Sat Feb 6 15:08:55 2010 --- /tmp/getb27586 Sat Feb 6 15:08:55 2010 *************** *** 11,17 **** #ifndef lint #ifndef NOID ! static char elsieid[] = "@(#)asctime.c 8.2"; #endif /* !defined NOID */ #endif /* !defined lint */ --- 11,17 ---- #ifndef lint #ifndef NOID ! static char elsieid[] = "@(#)asctime.c 8.5"; #endif /* !defined NOID */ #endif /* !defined lint */ *************** *** 91,96 **** --- 91,100 ---- char year[INT_STRLEN_MAXIMUM(int) + 2]; char result[MAX_ASCTIME_BUF_SIZE]; + if (timeptr == NULL) { + errno = EINVAL; + return strcpy(buf, "??? ??? ?? ??:??:?? ????\n"); + } if (timeptr->tm_wday < 0 || timeptr->tm_wday >= DAYSPERWEEK) wn = "???"; else wn = wday_name[timeptr->tm_wday]; *************** *** 113,122 **** timeptr->tm_mday, timeptr->tm_hour, timeptr->tm_min, timeptr->tm_sec, year); ! if (strlen(result) < STD_ASCTIME_BUF_SIZE || buf == buf_asctime) { ! (void) strcpy(buf, result); ! return buf; ! } else { #ifdef EOVERFLOW errno = EOVERFLOW; #else /* !defined EOVERFLOW */ --- 117,125 ---- timeptr->tm_mday, timeptr->tm_hour, timeptr->tm_min, timeptr->tm_sec, year); ! if (strlen(result) < STD_ASCTIME_BUF_SIZE || buf == buf_asctime) ! return strcpy(buf, result); ! else { #ifdef EOVERFLOW errno = EOVERFLOW; #else /* !defined EOVERFLOW */

1 0

Russia may set clocks back one hour instead of going into DST
by Steffen Thorsen Feb. 3, 2010

Feb. 3, 2010

According to this article in Pravda, Russia might stop observing DST, and instead go back one hour in March to the time zones they were at until year 1930. http://english.pravda.ru/society/stories/03-02-2010/111995-time_zone-0 Best regards, Steffen Thorsen - timeanddate.com

1 0

FW: problem with java tz database
by Olson, Arthur David (NIH/NCI) [E] Jan. 25, 2010

Jan. 25, 2010

I'm (very belatedly, for which I apologize) forwarding this message from Mamun Shaheed, who is not on the time zone mailing list. Those of you who are on the list, please direct replies appropriately. --ado From: Mamun Shaheed [mailto:mamun.shaheed@gmail.com] Sent: Thursday, December 31, 2009 1:13 To: tz(a)lecserver.nci.nih.gov Subject: problem with java tz database Dear all, I was trying to modify the tzdatabase ($JRE_HOME/lib/zi/*) for JRE, but could not make it sucess. Here is what I have done so far... 1. Downloaded the code and latest tzdata from ftp://elsie.nci.nih.gov/pub/. 2. Modified the asia file and insert my rule there. 3. compile the file with zic. 4. copy the compiled file and put in in $JRE_HOME/lib/zi/Asia/ of my windows pcs 5. run the DSTTest file available in sun.com to check the time zone and got following error C:\Program Files\Java\jre1.5.0_06\bin>java DSTTest "12/30/2009 1:00 AM" ZoneInfo: wrong magic number: Asia/Dhaka ZoneInfo: wrong magic number: Asia/Dhaka JRE version : 1.5.0_06 Wed Dec 30 01:00:00 GMT 2009 TimeZone tested : Greenwich Mean Time Your tested time is not in daylight-savings time. C:\Program Files\Java\jre1.5.0_06\bin> Please help me. Mamun

1 0

tzdata2010b
by Olson, Arthur David (NIH/NCI) [E] Jan. 25, 2010

Jan. 25, 2010

The file... ftp://elsie.nci.nih.gov/pub/tzdata2010b.tar.gz ...is now available; this reflects the Mexico changes previously circulated on the time zone mailing list. With providence well enjoy a bit of stability now. --ado

1 0