- tz - lists.iana.org

Country heading for Morocco missing
by Stephen Colebourne Oct. 30, 2022

Oct. 30, 2022

I've noticed that the comment that acts as a heading for Morocco in the `africa` file is now missing. It is around line 591. I believe it was erroneously deleted. thanks Stephen

2 1

2022f and zonetab entries for Mexico
by Chris Walton Oct. 30, 2022

Oct. 30, 2022

According to 2022f, *America/Chihuahua* and *America/Ojinaga* switched from Mountain Time to Central Time. The descriptions in zone.tab and zone1970.tab still show "Mountain Time". -chris

3 5

[PROPOSED] Don’t assume nonempty argv
by Paul Eggert Oct. 29, 2022

Oct. 29, 2022

Don’t dump core if argv[0] is NULL, which is allowed on GNU/Linux if the invoker is sufficiently perverse. * zdump.c (progname): Now char const *, so that it can be given the address of a string constant. (tzalloc): Use optarg, not progname, since progname’s type is no longer correct. * zdump.c, zic.c (main): Initialize progname to non-null. --- zdump.c | 6 +++--- zic.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/zdump.c b/zdump.c index 512ba8cc..f0461ade 100644 --- a/zdump.c +++ b/zdump.c @@ -84,7 +84,7 @@ static time_t const absolute_max_time = ? (((time_t) 1 << atime_shift) - 1 + ((time_t) 1 << atime_shift)) : -1); static int longest; -static char * progname; +static char const *progname; static bool warned; static bool errout; @@ -234,7 +234,7 @@ tzalloc(char const *val) exit(EXIT_FAILURE); } tzset(); - return &progname; /* Any valid non-null char ** will do. */ + return &optarg; /* Any valid non-null char ** will do. */ # else enum { TZeqlen = 3 }; static char const TZeq[TZeqlen] = "TZ="; @@ -463,7 +463,7 @@ main(int argc, char *argv[]) # endif /* defined TEXTDOMAINDIR */ textdomain(TZ_DOMAIN); #endif /* HAVE_GETTEXT */ - progname = argv[0]; + progname = argv[0] ? argv[0] : "zdump"; for (i = 1; i < argc; ++i) if (strcmp(argv[i], "--version") == 0) { printf("zdump %s%s\n", PKGVERSION, TZVERSION); diff --git a/zic.c b/zic.c index 501718f4..f3b32ecc 100644 --- a/zic.c +++ b/zic.c @@ -943,7 +943,7 @@ main(int argc, char **argv) textdomain(TZ_DOMAIN); #endif /* HAVE_GETTEXT */ main_argv = argv; - progname = argv[0]; + progname = argv[0] ? argv[0] : "zic"; if (TYPE_BIT(zic_t) < 64) { fprintf(stderr, "%s: %s\n", progname, _("wild compilation-time specification of zic_t")); -- 2.37.2

4 5

[PROPOSED] Most of Mexico will no longer observe DST
by Paul Eggert Oct. 29, 2022

Oct. 29, 2022

Also, Chihuahua moves to year-round -06. * NEWS: Mention this. * northamerica (Mexico): No DST after 2022. (America/Ojinaga, America/Chihuahua): Switch from -07 to -06 on 2022-10-30 02:00. --- NEWS | 9 +++++++++ northamerica | 20 ++++++++++++++++---- 2 files changed, 25 insertions(+), 4 deletions(-) diff --git a/NEWS b/NEWS index 331c1d2..5689811 100644 --- a/NEWS +++ b/NEWS @@ -3,6 +3,8 @@ News for the tz database Unreleased, experimental changes Briefly: + Mexico will no longer observe DST except near the US border. + Chihuahua moves to year-round -06 on 2022-10-30. Fiji no longer observes DST. Move links to 'backward'. In vanguard form, GMT is now a Zone and Etc/GMT a link. @@ -16,6 +18,13 @@ Unreleased, experimental changes Changes to future timestamps. + Mexico will no longer observe DST after 2022, except for areas + near the US border that continue to observe US DST rules. + On 2022-10-30 at 02:00 the Mexican state of Chihuahua moves + from -07 (-06 with DST) to year-round -06, thus not changing + its clocks that day. The new law states that Chihuahua + near the US border no longer observes US DST. + Fiji will not observe DST in 2022/3. (Thanks to Shalvin Narayan.) For now, assume DST is suspended indefinitely. diff --git a/northamerica b/northamerica index 1f16a1c..df19543 100644 --- a/northamerica +++ b/northamerica @@ -2553,6 +2553,12 @@ Zone America/Dawson -9:17:40 - LMT 1900 Aug 20 # 5- The islands, reefs and keys shall take their timezone from the # longitude they are located at. +# From Paul Eggert (2022-10-28): +# The new Mexican law was published today: +# https://www.dof.gob.mx/nota_detalle.php?codigo=5670045&fecha=28/10/2022 +# This abolishes DST except where US DST rules are observed, +# and in addition changes all of Chihuahua to -06 with no DST. + # Rule NAME FROM TO - IN ON AT SAVE LETTER/S Rule Mexico 1931 only - May 1 23:00 1:00 D Rule Mexico 1931 only - Oct 1 0:00 0 S @@ -2568,8 +2574,8 @@ Rule Mexico 1996 2000 - Apr Sun>=1 2:00 1:00 D Rule Mexico 1996 2000 - Oct lastSun 2:00 0 S Rule Mexico 2001 only - May Sun>=1 2:00 1:00 D Rule Mexico 2001 only - Sep lastSun 2:00 0 S -Rule Mexico 2002 max - Apr Sun>=1 2:00 1:00 D -Rule Mexico 2002 max - Oct lastSun 2:00 0 S +Rule Mexico 2002 2022 - Apr Sun>=1 2:00 1:00 D +Rule Mexico 2002 2022 - Oct lastSun 2:00 0 S # Zone NAME STDOFF RULES FORMAT [UNTIL] # Quintana Roo; represented by Cancún Zone America/Cancun -5:47:04 - LMT 1922 Jan 1 6:00u @@ -2622,7 +2628,8 @@ Zone America/Ojinaga -6:57:40 - LMT 1922 Jan 1 7:00u -6:00 Mexico C%sT 1998 -6:00 - CST 1998 Apr Sun>=1 3:00 -7:00 Mexico M%sT 2010 - -7:00 US M%sT + -7:00 US M%sT 2022 Oct 30 2:00 + -6:00 - CST # Chihuahua (away from US border) Zone America/Chihuahua -7:04:20 - LMT 1922 Jan 1 7:00u -7:00 - MST 1927 Jun 10 23:00 @@ -2631,7 +2638,8 @@ Zone America/Chihuahua -7:04:20 - LMT 1922 Jan 1 7:00u -6:00 - CST 1996 -6:00 Mexico C%sT 1998 -6:00 - CST 1998 Apr Sun>=1 3:00 - -7:00 Mexico M%sT + -7:00 Mexico M%sT 2022 Oct 30 2:00 + -6:00 - CST # Sonora Zone America/Hermosillo -7:23:52 - LMT 1922 Jan 1 7:00u -7:00 - MST 1927 Jun 10 23:00 @@ -2729,6 +2737,10 @@ Zone America/Tijuana -7:48:04 - LMT 1922 Jan 1 7:00u # http://dof.gob.mx/nota_detalle.php?codigo=5127480&fecha=06/01/2010 # It has been moved to the 'backward' file. # +# From Paul Eggert (2022-10-28): +# Today's new law states that the entire state of Baja California +# follows US DST rules, which agrees with simplifications noted above. +# # # Revillagigedo Is # no information -- 2.37.3

1 0

Daylight Savings Time in Fiji Islands
by Shalvin Narayan Oct. 28, 2022

Oct. 28, 2022

Hi Contributors, Please note that there will not be any daylight savings time change in Fiji for 2022-2023. As per current tzdata, the time is scheduled to be changed on 13 November and moved back on 15 January. However, as per the government announcement, it will not be the case and they have canceled the DST change. You can find the announcement on: https://www.facebook.com/FijianGovernment/posts/pfbid0mmWVTYmTibn66ybpFda75… Requesting if the updated tzdata package can be provided so the patch can be implemented in the system and reflected in global time and data systems. zdump -v Pacific/Fiji | grep 2022 zdump: warning: zone "Pacific/Fiji" abbreviation "+12" lacks alphabetic at start Pacific/Fiji Sat Jan 15 13:59:59 2022 UTC = Sun Jan 16 02:59:59 2022 +13 isdst=1 gmtoff=46800 Pacific/Fiji Sat Jan 15 14:00:00 2022 UTC = Sun Jan 16 02:00:00 2022 +12 isdst=0 gmtoff=43200 Pacific/Fiji Sat Nov 12 13:59:59 2022 UTC = Sun Nov 13 01:59:59 2022 +12 isdst=0 gmtoff=43200 Pacific/Fiji Sat Nov 12 14:00:00 2022 UTC = Sun Nov 13 03:00:00 2022 +13 isdst=1 gmtoff=46800 zdump -v Pacific/Fiji | grep 2023 zdump: warning: zone "Pacific/Fiji" abbreviation "+12" lacks alphabetic at start Pacific/Fiji Sat Jan 14 13:59:59 2023 UTC = Sun Jan 15 02:59:59 2023 +13 isdst=1 gmtoff=46800 Pacific/Fiji Sat Jan 14 14:00:00 2023 UTC = Sun Jan 15 02:00:00 2023 +12 isdst=0 gmtoff=43200 Pacific/Fiji Sat Nov 11 13:59:59 2023 UTC = Sun Nov 12 01:59:59 2023 +12 isdst=0 gmtoff=43200 Pacific/Fiji Sat Nov 11 14:00:00 2023 UTC = Sun Nov 12 03:00:00 2023 +13 isdst=1 gmtoff=46800 timedatectl status Local time: Wed 2022-10-26 16:19:46 +12 Universal time: Wed 2022-10-26 04:19:46 UTC RTC time: Wed 2022-10-26 04:19:47 Time zone: Pacific/Fiji (+12, +1200) NTP enabled: yes NTP synchronized: yes RTC in local TZ: no DST active: no Last DST change: DST ended at Sun 2022-01-16 02:59:59 +13 Sun 2022-01-16 02:00:00 +12 Next DST change: DST begins (the clock jumps one hour forward) at Sun 2022-11-13 01:59:59 +12 Sun 2022-11-13 03:00:00 +13 Thanks Shalvin Narayan Head of ICT Telecom Fiji Limited [cidimage002.png(a)01D70F67.132FB220] P: (679) 321 0247 M: (679) 991 3793 This email (including any attachments) is confidential and intended solely for the use of the recipient it is addressed to. It may also be subject to legal or other professional privileges. Information contained in this email should not be copied or forwarded without the consent of the sender. If you have received this transmission in error, please notify the sender immediately and destroy and/or delete all hard and soft data relating to this transmission. Confidentiality or privilege is not waived or lost because this email has been sent to you by mistake. Telecom Fiji Limited has active anti-virus measures on its email systems but does not accept any liability in connection with any computer virus, data corruption, delay, interruption, unauthorized access, or unauthorized amendment. Any views expressed in this email are those of the individual sender, except where expressly stated to be a representation by Telecom Fiji Limited

3 3

Wrong day light savings (DST) in Syria
by MAHMAOD RADWAN Oct. 28, 2022

Oct. 28, 2022

Dear iana organization Right now in Syria government made a decision to cancel day light saving (DST) in Syria but for some reason smartphones (android and ios) devices reserve a change to it clock so the clock in the all smartphones are now late for an hour so I hope to fix this mistake and reasove the issue Note i live right now in Syria and my clock is late for an hour

4 4

[PROPOSED 1/7] Avoid undefined behavior if no Link lines
by Paul Eggert Oct. 28, 2022

Oct. 28, 2022

* zic.c (make_links): Don't call qsort(NULL, 0, ...) as this has undefined behavior in C. This fixes a bug introduced five days ago. --- zic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/zic.c b/zic.c index 78afa67..a699285 100644 --- a/zic.c +++ b/zic.c @@ -683,7 +683,8 @@ static void make_links(void) { ptrdiff_t i, j, nalinks; - qsort(links, nlinks, sizeof *links, qsort_linkcmp); + if (nlinks) + qsort(links, nlinks, sizeof *links, qsort_linkcmp); /* Ignore each link superseded by a later link with the same name. */ j = 0; -- 2.37.3

9 33

[PROPOSED] Fix recently-introduced zic infloop
by Paul Eggert Oct. 28, 2022

Oct. 28, 2022

* zic.c (make_links): Diagnose link cycles instead of looping. --- zic.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/zic.c b/zic.c index 4222869..501718f 100644 --- a/zic.c +++ b/zic.c @@ -688,7 +688,7 @@ bsearch_linkcmp(void const *key, void const *b) static void make_links(void) { - ptrdiff_t i, j, nalinks; + ptrdiff_t i, j, nalinks, pass_size; if (1 < nlinks) qsort(links, nlinks, sizeof *links, qsort_linkcmp); @@ -700,7 +700,7 @@ make_links(void) i++; links[j++] = links[i]; } - nlinks = j; + nlinks = pass_size = j; /* Walk through the link array making links. However, if a link's target has not been made yet, append a copy to the @@ -739,8 +739,22 @@ make_links(void) eat(links[i].l_filenum, links[i].l_linenum); /* If this pass examined all its links, start the next pass. */ - if (i == j) + if (i == j) { + if (nalinks - i == pass_size) { + error(_("\"Link %s %s\" is part of a link cycle"), + links[i].l_target, links[i].l_linkname); + break; + } j = nalinks; + pass_size = nalinks - i; + } + + /* Diagnose self links, which the cycle detection algorithm would not + otherwise catch. */ + if (strcmp(links[i].l_target, links[i].l_linkname) == 0) { + error(_("link %s targets itself"), links[i].l_target); + continue; + } /* Make this link unless its target has not been made yet. */ l = bsearch(links[i].l_target, &links[i + 1], j - (i + 1), -- 2.37.3

1 0

[PROPOSED 1/2] Don’t include <sys/type.h>
by Paul Eggert Oct. 27, 2022

Oct. 27, 2022

* private.h: Do not include <sys/types.h> for time_t. Including sys/types.h was added on 1989-04-10 to support pre-C89 platforms, but this is no longer needed now that we assume C89. --- private.h | 1 - 1 file changed, 1 deletion(-) diff --git a/private.h b/private.h index ffb9d48..baacdfb 100644 --- a/private.h +++ b/private.h @@ -179,7 +179,6 @@ #undef tzfree #include <stddef.h> -#include <sys/types.h> /* for time_t */ #include <string.h> #include <limits.h> /* for CHAR_BIT et al. */ #include <stdlib.h> -- 2.37.3

1 1

[PROPOSED] Fix zdump undefined behavior if !USE_LTZ
by Paul Eggert Oct. 27, 2022

Oct. 27, 2022

When compiled with -DUSE_LTZ=0, zdump modified pointers in the environ vector, which POSIX says results in undefined behavior. Fix this by using setenv if available, otherwise by arranging for the modifications to occur to the vector before it's assigned or re-assigned to ‘environ’. * Makefile, NEWS: Mention this. * private.h (HAVE_SETENV): Default to 1. * zdump.c (tzalloc): If HAVE_SETENV, just use setenv; it’s simpler. Otherwise, avoid modifying environ, environ[0], environ[0][0], etc. while environ is in use by getenv etc. Do this by keeping two independent environ vectors; the original one and fakeenv. If !HAVE_SETENV, return the initial environ array. (tzalloc, tzfree): Give the getenv family a chance of getting the correct answer, by calling tzset after each time the environment is modified. (tzfree): Restore the initial environ array. --- Makefile | 1 + NEWS | 4 ++++ private.h | 4 ++++ zdump.c | 57 ++++++++++++++++++++++++++++++++++++++----------------- 4 files changed, 49 insertions(+), 17 deletions(-) diff --git a/Makefile b/Makefile index d3cfbd0..34cec49 100644 --- a/Makefile +++ b/Makefile @@ -223,6 +223,7 @@ LDLIBS= # -DHAVE_MALLOC_ERRNO=0 if malloc etc. do not set errno on failure. # -DHAVE_POSIX_DECLS=0 if your system's include files do not declare # functions like 'link' or variables like 'tzname' required by POSIX +# -DHAVE_SETENV=0 if your system lacks the setenv function # -DHAVE_SNPRINTF=0 if your system lacks the snprintf function # -DHAVE_STDINT_H if you have a non-C99 compiler with <stdint.h>* # -DHAVE_STRFTIME_L if <time.h> declares locale_t and strftime_l diff --git a/NEWS b/NEWS index a918aed..546fe11 100644 --- a/NEWS +++ b/NEWS @@ -73,6 +73,10 @@ Unreleased, experimental changes releases have been out of support since 2019. This change affects only fat TZif files, as thin files never had the workaround. + zdump no longer modifies the environ vector when compiled on + platforms lacking tm_zone or when compiled with -DUSE_LTZ=0. + This avoid undefined behavior on POSIX platforms. + Release 2022e - 2022-10-11 11:13:02 -0700 diff --git a/private.h b/private.h index 2c7535d..ffb9d48 100644 --- a/private.h +++ b/private.h @@ -87,6 +87,10 @@ # define HAVE_POSIX_DECLS 1 #endif +#ifndef HAVE_SETENV +# define HAVE_SETENV 1 +#endif + #ifndef HAVE_STRDUP # define HAVE_STRDUP 1 #endif diff --git a/zdump.c b/zdump.c index 168f72a..ffb321a 100644 --- a/zdump.c +++ b/zdump.c @@ -228,33 +228,56 @@ mktime_z(timezone_t tz, struct tm *tmp) static timezone_t tzalloc(char const *val) { +# if HAVE_SETENV + if (setenv("TZ", val, 1) != 0) { + perror("setenv"); + exit(EXIT_FAILURE); + } + tzset(); + return NULL; +# else + enum { TZeqlen = 3 }; + static char const TZeq[TZeqlen] = "TZ="; static char **fakeenv; - char **env = fakeenv; - char *env0; - if (! env) { - char **e = environ; - int to; + static size_t fakeenv0size; + void *freeable = NULL; + char **env = fakeenv, **initial_environ; + size_t valsize = strlen(val) + 1; + if (fakeenv0size < valsize) { + char **e = environ, **to; + ptrdiff_t initial_nenvptrs; /* Counting the trailing NULL pointer. */ while (*e++) continue; - env = xmalloc(sumsize(sizeof *environ, - (e - environ) * sizeof *environ)); - to = 1; - for (e = environ; (env[to] = *e); e++) - to += strncmp(*e, "TZ=", 3) != 0; + initial_nenvptrs = e - environ; + fakeenv0size = sumsize(valsize, valsize); + fakeenv0size = max(fakeenv0size, 64); + freeable = env; + fakeenv = env = + xmalloc(sumsize(sumsize(sizeof *environ, + initial_nenvptrs * sizeof *environ), + sumsize(TZeqlen, fakeenv0size))); + to = env + 1; + for (e = environ; (*to = *e); e++) + to += strncmp(*e, TZeq, TZeqlen) != 0; + env[0] = memcpy(to + 1, TZeq, TZeqlen); } - env0 = xmalloc(sumsize(sizeof "TZ=", strlen(val))); - env[0] = strcat(strcpy(env0, "TZ="), val); - environ = fakeenv = env; + memcpy(env[0] + TZeqlen, val, valsize); + initial_environ = environ; + environ = env; tzset(); - return env; + free(freeable); + return initial_environ; +# endif } static void -tzfree(timezone_t env) +tzfree(timezone_t initial_environ) { - environ = env + 1; - free(env[0]); +# if !HAVE_SETENV + environ = initial_environ; + tzset(); +# endif } #endif /* ! USE_LOCALTIME_RZ */ -- 2.37.3

1 0