On Oct 7, 10:11pm, eggert@cs.ucla.edu (Paul Eggert) wrote: -- Subject: Re: [tz] localtime.c patch | Sorry, I don't see the bug there; can you explain? I assume you're talking | about either the code labeled "only standard time" or the code labeled "so, | we're off a little", and in both cases there is only one time type, so the rest | of the code should never access sp->ttis[1] and there should be no need to | initialize it. Well, this was the case before we returned a pointer of that data to the user. I prefer not to return random bits from the heap to the user. | In trying out the code under 'valgrind' I found that the command "zdump ''" | tickled some other uninitialized-storage usages: the "so, we're off a little" | code doesn't initialize charcnt, goback, goahead, or defaulttype. Thanks, that is a good idea. | I hope the attached proposed patch fixes all these problems; please let us know I'll take a look, thanks! christos