Date: Thu, 11 May 2017 01:50:14 -0700 From: Guy Harris <guy@alum.mit.edu> Message-ID: <0C3A5981-83B4-4453-84C3-DF940EA70502@alum.mit.edu> | On May 10, 2017, at 6:33 AM, Clive D.W. Feather <clive@davros.org> wrote: | > Hmm. It's legal, but it suggests dubious thinking on the part of whoever | > wrote it. It's exactly equivalent to "q = true". | | As long as you do it fewer than 2^{number of bits in q} times. I have no idea why we are still discussing this ... it has already been made quite clear that the problem really was that the var wasn't supposed to be a bool, but an int, and that the code in question wasn't supposed to be setting it to 1 (which assigning true would do) but 2 (it was already 1 - the code was in a section that started: if (hit) ... What's more, Paul has already written code to make the whole thing go away. When I sent in the original report, I hadn't bothered looking at the code, just the patch (which has now been corrected in NetBSD). kre