Christos Zoulas wrote:
Please fix it so that it does not pass char into the isfoo() functions
The code doesn't pass char into the isfoo() functions. But your message and its followups suggest that the code is overly confusing (especially the bit about isascii, which nowadays never tests whether its argument is ASCII!). And there is one real bug in this area: the code uses predicates like isalpha whose behavior can depend on the locale if HAVE_GETTEXT is true, and that dependency was not intended. I installed the attached patch to try to fix these problems. The basic idea was to discard <ctype.h> as being more trouble than it's worth. A nice little byproduct of this is that we no longer need to worry about ctype.h defining a macro 'isleap' that's incompatible with ours, something POSIX says it's entitled to do.