On Oct 12, 5:09pm, Paul_Koning@Dell.com (<Paul_Koning@Dell.com>) wrote: -- Subject: Re: [tz] [PATCH 1/3] Assume C89. | | On Oct 12, 2012, at 12:24 PM, Todd C. Miller wrote: | | > For this bit in date.c: | > | > - found = select(FD_SETSIZE, &ready, (fd_set *)0, (fd_set *)0, &tout); | > + found = select(FD_SETSIZE, &ready, 0, 0, &tout); | > | > You probably want to use NULL, not a bare 0 for the 3rd and 4th | > arguments. | | Makes no difference; NULL is just a macro that translates to 0, sometimes with a mostly-unnecessary cast to void*. Makes not difference, except: - When you are using varyadic functions - When the function prototype is not in scope (Unless I missed something) IMHO, it is safer to use NULL, and the cast to (void *) that most implementations currently have is nice because it differentiates between the value 0 and the pointer 0. christos