Aug. 26, 2014
9:24 p.m.
Thanks very much for that review. lennox@cs.columbia.edu wrote:
These functions aren't documented yet, as far as I can tell?
I had been lazy, and had taken the lead from the STD_INSPIRED functions, which aren't documented.... But you're right, the new functions should be, or at least the ones that aren't STD_INSPIRED.
Since NetBSD doesn't define what a NULL argument to tzalloc does, could I suggest that it indeed mean /etc/localtime?
As Alan mentioned NetBSD-current says NULL means UTC, but your idea is better and Alan likes it too so let's do that.
I'd also suggest that tzalloc should fail for unknown time zone names, rather than silently returning GMT.
Yes, that sounds good too. Proposed further patches attached for all the above.