On 2025-09-23 10:05, Dag-Erling Smørgrav wrote:
I don't see much point in upstreaming FreeBSD's changes en masse.
Yes, and I wasn't planning to do that. Just one feature at a time.
The one change I'd like to see upstreamed (because it would reduce future merge conflicts) is the offtime_r patch which I submitted and you rejected two years ago.
In hindsight I was perhaps too strict and after all, NetBSD has offtime_r too. So I installed the attached proposed patch to tzcode. (By the way, offtime_r is not documented in FreeBSD, so is it present only as a compatibility hack there?) Getting back to the failure to conform to ISO C and POSIX with respect to the pointers returned by gmtime and localtime - is that a bug that FreeBSD would be willing to fix? If so, that'd simplify things on tzcode's end, if we want to keep roughly in sync.
The DETECT_TZ_CHANGES patch may be of interest to others, but it should be attributed to NetApp, Inc. rather than to FreeBSD.
What form should the attribution take? I don't see attribution in the FreeBSD time source code. I assume Guy Harris wrote that so I'll cc him.