On Sun, 15 Sept 2024 at 19:37, Paul Eggert <eggert@cs.ucla.edu> wrote:
On 2024-09-15 02:50, Stephen Colebourne via tz wrote:
The Makefile contains a section called `check_now`. It references the files `zone1970.tab` and `zonenow.tab`. Other sections of the Makefile take account of the variable $ZONETABLES before using/checking zone files. Would it be possible to alter Makefile so it only runs check_now if at least one of zone1970/zonenow are in $ZONETABLES ?
ZONETABLES is outside the Makefile section marked "macros that one plausibly might want to tailor". It'd be helpful to know why one would want to change its value, as that would likely affect more than just the now.ck rule.
This reminds me of our October 2022 thread on a similar topic[1], which was addressed by adding a new target "check_mild". One way to address the current glitch might be to move now.ck from the "check_mild" to the "check" rule, as in the attached patch (which I have not installed). That way, one could run "make check_mild" to omit the test that fails when one changes ZONETABLES. Would that suffice?
This is pretty much the same problem as 2022 - where Makefile has extended checks that don't meet the goals of global-tz. To me, ZONETABLES is a suitable solution as it explicitly states which zone* files are the ones that should be checked/processed. I currently run `make check VERSION="test" ZONETABLES="zone.tab"` I'm willing to change to `make check_mild VERSION="test" ZONETABLES="zone.tab"` if you want, although it seems like a worse outcome because ZONETABLES appears to have a clear definition which isn't currently being respected. Stephen