On 2016-02-29 18:15, J William Piggott wrote:
On 02/24/2016 04:07 AM, Paul Eggert wrote:
J William Piggott wrote:
As it turns out, no abbreviations were need to prevent (any further) breaking of 80 columns (the current comments are already broken).
OK, but I'd rather fix the comments rather than leave them broken.
I anticipated push back against such an extensive reduction in content, so I was going to submit them as a separate patch set.
Establishing a standard format first seemed like the best sequence.
I am glad that you made the changes. It is great for tzselect to have proper paging now, good job.
Some of the notation I found confusing (e.g., the ", (" syntax) ...
I wasn't completely satisfied with that either. I was looking for a terse solution to issues like below; does 'west' apply to Sulawesi/Celebes, Bali, Nusa Tengarra? Does 'E' apply to 'AB'? What if it did (as with Coahuila)? ... and so on.
Borneo (east, south), Sulawesi/Celebes, Bali, Nusa Tengarra, Timor (west) Mountain - AB, BC (E), SK (W) Zaporozh'ye/Zaporizhia, Lugansk/Luhansk (east) Newfoundland, Labrador (southeast) Central Time - Durango; Coahuila, Nuevo León, Tamaulipas (all far from US)
I think it mostly looks good, this patch set has a few additions.
Not clear in lines such as those below that Eastern, Central refer to time zone and not the geographical part of the region - either add the word Time or some other indication e.g. EST/EDT, CST/CDT to keep it short: -CA +4339-07923 America/Toronto Eastern - ON & QC (most locations) -CA +4901-08816 America/Nipigon Eastern - ON & QC (no DST 1967-73) +CA +4339-07923 America/Toronto Eastern - ON, QC (most locations) +CA +4901-08816 America/Nipigon Eastern - ON, QC (no DST 1967-73) CA +4823-08915 America/Thunder_Bay Eastern - ON (Thunder Bay) CA +6344-06828 America/Iqaluit Eastern - NU (most east locations) CA +6608-06544 America/Pangnirtung Eastern - NU (Pangnirtung) -- Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada