July 5, 2026
5:27 p.m.
In the same vein of compiler-ish warnings, today we got our first Coverity report including the 2026b tzcode, and it complained about
CID 1650305: Error handling issues (CHECKED_RETURN) Calling "remove(tempname)" without checking return value. This library function may fail and return an error code.
1762 remove(tempname);
in rename_dest() and again in close_file(). Perhaps it would be appropriate to report the original error, and then try the remove() and warn if that fails? It's not hugely important since zic is about to fail in both cases, but it might be a good idea to let the user know we left a junk file behind. regards, tom lane