RE: compile errors on timezone database
Another possibility is to change from... lastSat 24:00 ...to... lastSat 23:59:59 (meaning that changes will be one second premature and that some binary output files will change, but avoiding the dread 60th second.) --ado -----Original Message----- From: Dave Rolsky [mailto:autarch@urth.org] Sent: Wednesday, December 03, 2003 12:41 PM To: Olson, Arthur David (NIH/NCI) Cc: 'Diane Kledzik'; Tz (tz@elsie.nci.nih.gov) Subject: RE: compile errors on timezone database On Wed, 3 Dec 2003, Olson, Arthur David (NIH/NCI) wrote:
Another possibility is to change the spelling of... 24:00 ...to... 23:59:60 ...which works with any version of zic issued 1988 or later. Let's hear it for leap seconds!
Please don't do this. This is a bogus time, because there is no leap second at that time. 24:00 makes a lot more sense. Plus my parsing code already handles it and I don't want to have to make more changes ;) -dave /*======================= House Absolute Consulting www.houseabsolute.com =======================*/
Olson, Arthur David (NIH/NCI) wrote:
Another possibility is to change from... lastSat 24:00 ...to... lastSat 23:59:59 (meaning that changes will be one second premature and that some binary output files will change, but avoiding the dread 60th second.)
This looks to me as introducing a new error to solve a previous error which is itself already solved. Doesn't sounds as a good idea to me. I will try not to comment on this matter anymore as my position is clear enough ;) Rodrigo Severo -- ---------------------------------------------------- Rodrigo Severo Fábrica de Idéias Fone: +55(61)321 1357 Fax: +55(61)223 1712 SBS - Quadra 2 - Ed. Empire Center - Sala 1301 Brasília/DF - Brasil CEP: 70.070-904 ----------------------------------------------------
Here's a better fix, which I'll propose as part of my next major patch. It keeps the transition times asis, without any tricks and without using 24:00, by using May 1 and Oct 1 when lastSat 24:00 does not equal lastSun 00:00. (As it happens, I got the transition times wrong in Toronto anyway: Shanks says they were at 02:00, not at 00:00. I must have copied the Montreal entries. Oops. The following part-of-a-patch fixes that too.) @@ -951,10 +961,13 @@ Rule Mont 1922 only - Apr 30 2:00 1:00 D Rule Mont 1924 only - May 17 2:00 1:00 D Rule Mont 1924 1926 - Sep lastSun 2:30 0 S Rule Mont 1925 1926 - May Sun>=1 2:00 1:00 D -Rule Mont 1927 1937 - Apr lastSat 24:00 1:00 D -Rule Mont 1927 1937 - Sep lastSat 24:00 0 S -Rule Mont 1938 1940 - Apr lastSun 0:00 1:00 D -Rule Mont 1938 1939 - Sep lastSun 0:00 0 S +Rule Mont 1927 only - May 1 0:00 1:00 D +Rule Mont 1927 1932 - Sep lastSun 0:00 0 S +Rule Mont 1928 1931 - Apr lastSun 0:00 1:00 D +Rule Mont 1932 only - May 1 0:00 1:00 D +Rule Mont 1933 1940 - Apr lastSun 0:00 1:00 D +Rule Mont 1933 only - Oct 1 0:00 0 S +Rule Mont 1934 1939 - Sep lastSun 0:00 0 S Rule Mont 1946 1973 - Apr lastSun 2:00 1:00 D Rule Mont 1945 1948 - Sep lastSun 2:00 0 S Rule Mont 1949 1950 - Oct lastSun 2:00 0 S @@ -973,12 +986,14 @@ Rule Toronto 1922 1926 - Sep Sun>=15 2:0 Rule Toronto 1924 1927 - May Sun>=1 2:00 1:00 D Rule Toronto 1927 1928 - Sep lastSun 2:00 0 S Rule Toronto 1928 only - Apr lastSun 2:00 1:00 D -Rule Toronto 1929 only - Apr lastSun 0:00 1:00 D -Rule Toronto 1929 only - Sep lastSun 0:00 0 S -Rule Toronto 1930 1937 - Apr lastSat 24:00 1:00 D -Rule Toronto 1930 1937 - Sep lastSat 24:00 0 S -Rule Toronto 1938 1940 - Apr lastSun 0:00 1:00 D -Rule Toronto 1938 1939 - Sep lastSun 0:00 0 S +Rule Toronto 1929 only - Apr lastSun 2:00 1:00 D +Rule Toronto 1929 only - Sep lastSun 2:00 0 S +Rule Toronto 1930 1931 - Apr lastSun 2:00 1:00 D +Rule Toronto 1930 1932 - Sep lastSun 2:00 0 S +Rule Toronto 1932 only - May 1 2:00 1:00 D +Rule Toronto 1933 1940 - Apr lastSun 2:00 1:00 D +Rule Toronto 1933 only - Oct 1 2:00 0 S +Rule Toronto 1934 1939 - Sep lastSun 2:00 0 S Rule Toronto 1945 1946 - Sep lastSun 2:00 0 S Rule Toronto 1946 only - Apr lastSun 2:00 1:00 D Rule Toronto 1947 1949 - Apr lastSun 0:00 1:00 D
participants (3)
-
Olson, Arthur David (NIH/NCI) -
Paul Eggert -
Rodrigo Severo