On Fri, Oct 12, 2012 at 9:24 AM, Todd C. Miller
<Todd.Miller@courtesan.com> wrote:
For this bit in date.c:
- found = select(FD_SETSIZE, &ready, (fd_set *)0, (fd_set *)0, &tout);
+ found = select(FD_SETSIZE, &ready, 0, 0, &tout);
You probably want to use NULL, not a bare 0 for the 3rd and 4th
arguments.
Assuming that there is a prototoype in
scope, the 0 should be safe. There is some justice in saying that NULL
would be safer, but it is not strictly necessary.
Also, I believe irealloc() is still needed if you are targetting
C89 as the behavior where realloc(NULL, n) being equivalent to
malloc(n) was standardized in C99, not C89.
Which part of C89 do you think is not equivalent?
9899:1990 (copied from Schildt's "The Annotated ANSI C Standard" — the standard text is useful; the annotations are not).
§7.10.3.4 The realloc function
Synopsis
#include <stdlib.h>
void *realloc(void *ptr, size_t size);
Description
The
realloc function changes the size of the object pointed to by ptr to
the size specified by size. The contents of the object shall be
unchanged up to the lesser of the new and old sizes. If the new size is
larger, the value of the newly allocated portion of the object is
indeterminate. If ptr is a null pointer, the realloc function behaves
like the malloc function for the specified size. Otherwise, if ptr does
not match a pointer earlier returned by the calloc, malloc, or realloc
function, or if the space has been deallocated by a call to the free or
realloc function, the behaviour is undefined. If the space cannot be
allocated, the object pointed to by ptr is unchanged. If size is zero
and ptr is not a null pointer, the object it points to is freed.
Returns
The realloc function returns either a null pointer or a pointer to the possibly moved allocated space.